From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751642AbcFSQMF (ORCPT ); Sun, 19 Jun 2016 12:12:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50073 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907AbcFSQL5 (ORCPT ); Sun, 19 Jun 2016 12:11:57 -0400 Subject: Re: [PATCH v10 7/9] irqchip/gicv3-its: register the MSI global doorbell To: Jean-Philippe Brucker References: <1465315288-5931-1-git-send-email-eric.auger@redhat.com> <1465315288-5931-8-git-send-email-eric.auger@redhat.com> <20160617163327.GA26522@e106794-lin.localdomain> Cc: eric.auger.pro@gmail.com, robin.murphy@arm.com, alex.williamson@redhat.com, will.deacon@arm.com, joro@8bytes.org, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, christoffer.dall@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bharat.Bhushan@freescale.com, pranav.sawargaonkar@gmail.com, p.fedin@samsung.com, iommu@lists.linux-foundation.org, julien.grall@arm.com, yehuday@marvell.com From: Auger Eric Message-ID: Date: Sun, 19 Jun 2016 18:11:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160617163327.GA26522@e106794-lin.localdomain> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Sun, 19 Jun 2016 16:11:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jean-Philippe, On 17/06/2016 18:33, Jean-Philippe Brucker wrote: > Hi Eric, > > On Tue, Jun 07, 2016 at 04:01:26PM +0000, Eric Auger wrote: >> This patch adds the registration of the MSI global doorbell in >> gicv3-its driver. >> >> This will allow the msi layer to iommu_map this doorbell when >> requested. >> >> Signed-off-by: Eric Auger >> --- >> drivers/irqchip/irq-gic-v3-its.c | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c >> index 5eb1f9e..ed9dfce 100644 >> --- a/drivers/irqchip/irq-gic-v3-its.c >> +++ b/drivers/irqchip/irq-gic-v3-its.c >> @@ -29,6 +29,8 @@ >> #include >> #include >> #include >> +#include >> +#include >> >> #include >> #include >> @@ -1607,6 +1609,7 @@ static int __init its_probe(struct device_node *node, >> >> if (of_property_read_bool(node, "msi-controller")) { >> struct msi_domain_info *info; >> + phys_addr_t translater; >> >> info = kzalloc(sizeof(*info), GFP_KERNEL); >> if (!info) { >> @@ -1614,10 +1617,21 @@ static int __init its_probe(struct device_node *node, >> goto out_free_tables; >> } >> >> + translater = its->phys_base + GITS_TRANSLATER; >> + err = msi_doorbell_register_global(its, translater, >> + sizeof(u32), >> + IOMMU_WRITE | IOMMU_MMIO, true); > > This doesn't work :( Sorry to hear that. Thank you for testing with ITS. As mentioned in the part 3 cover letter, I could not test assignment with this MSI controller; I now have access to it so I am going to test it from next release onwards. > > First we have its_probe registering the global mapping with > doorbell->chip_data = its, which is a pointer to an its_node structure. > > But when enabling MSIs for a device, its_irq_domain_alloc puts a pointer > to an *its_device* into irq_data->chip_data. This seems to be a > per-device structure, allocated by its_msi_prepare. Hum OK, I missed the fact the chip_data was overwritten on its_irq_domain_alloc. I will investigate what we have as other alternatives. Thank you for the time spent on debugging that ;-) Best Regards Eric > > The following call to msi_doorbell_lookup won't ever succeed, because it > will compare its_node to its_device. I can't figure out how to fix it > cleanly at the moment. > > Jean-Philippe > >> + if (err) { >> + kfree(info); >> + goto out_free_tables; >> + } >> + >> + >> inner_domain = irq_domain_add_tree(node, &its_domain_ops, its); >> if (!inner_domain) { >> err = -ENOMEM; >> kfree(info); >> + msi_doorbell_unregister(its); >> goto out_free_tables; >> } >> >> -- >> 1.9.1 >>