From: "Arnd Bergmann" <arnd@arndb.de>
To: "Randy Dunlap" <rdunlap@infradead.org>,
"Lai Jiangshan" <jiangshanlai@gmail.com>
Cc: linux-kernel@vger.kernel.org, "Tejun Heo" <tj@kernel.org>
Subject: Re: [RFC PATCH] workqueue: fix cast warnings on i386
Date: Mon, 08 May 2023 15:41:15 +0200 [thread overview]
Message-ID: <eabf596d-8e19-484d-87b6-11222a5832eb@app.fastmail.com> (raw)
In-Reply-To: <4143448b-fb4f-860d-da67-b864e5b33020@infradead.org>
On Mon, May 1, 2023, at 06:42, Randy Dunlap wrote:
> On 4/30/23 21:37, Lai Jiangshan wrote:
>> Both the type of the "data" and WORK_STRUCT_WQ_DATA_MASK are
>> "unsigned long", so I don't think "(data & WORK_STRUCT_WQ_DATA_MASK)"
>> needs to be converted to "unsigned long".
>>
>> WORK_STRUCT_FLAG_MASK = (1UL << WORK_STRUCT_FLAG_BITS) - 1,
>> WORK_STRUCT_WQ_DATA_MASK = ~WORK_STRUCT_FLAG_MASK,
>>
>> This simple fix might hide the real problem.
>
> Thanks for replying.
>
> Do you have any suggestions for how to eliminate these warnings on i386
> and ARCH=um SUBARCH=i386?
I'm pretty sure the patch I posted earlier is the correct one, see
https://lore.kernel.org/all/20230117164041.1207412-1-arnd@kernel.org/
Sorry I never followed up on this after the initial post, I have
a backlog of patches that I sent out as build fixes but that for
some reason have not made it in.
Arnd
next prev parent reply other threads:[~2023-05-08 13:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-29 4:45 Randy Dunlap
2023-05-01 4:37 ` Lai Jiangshan
2023-05-01 4:42 ` Randy Dunlap
2023-05-08 13:41 ` Arnd Bergmann [this message]
2023-05-08 19:06 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eabf596d-8e19-484d-87b6-11222a5832eb@app.fastmail.com \
--to=arnd@arndb.de \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®