From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEAB4C77B6E for ; Thu, 6 Apr 2023 18:30:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240196AbjDFSaD (ORCPT ); Thu, 6 Apr 2023 14:30:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237250AbjDFSaB (ORCPT ); Thu, 6 Apr 2023 14:30:01 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC35B5B88 for ; Thu, 6 Apr 2023 11:29:59 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id x17so52044143lfu.5 for ; Thu, 06 Apr 2023 11:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680805798; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Neijv2zq96R0GfdQjQwNKcSFKV86CYJRcfc1aaFu1qk=; b=XlOX4iBsYDzB8wgJK6e2EygD58sqmxulgjX5qqPLTfJEt8z15r/HdkriynKKcYX2Bq Msof2eYI5neCNb+upoBnjZHBmUVqRYQHHGYJctHDxezQ4Cb9QfWZzNAq/MetS9UXCAgd AdnCCJmHS/gE6xkAUmP7rR5yETIcYFo5XIMXKbK+khXUj12Jqx5BVIqCi0XL/f+/Wwv6 lAbd/OFVk9+4dNyuccCRWlfk48MwAQMQga7khS4+oI1Gq1pvaRyvlMYYRM5Uw+Wr8wa5 4FsvJziidvPZmQeAMtyo6xWUS1iLQaI5TSLJ/dGUfel7N/MHZrd95B0d5YoeFnrHlrJk r3uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680805798; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Neijv2zq96R0GfdQjQwNKcSFKV86CYJRcfc1aaFu1qk=; b=KaWGuOipazgVuRbMo+TS/8OXnlwuhQJhnwFZrIpdK7DFuZgAFMkPDFO+13LftmD7p+ sTywzBS3RxtB5iQGl7EuqlRr7IVeCeuplFR+GR1SlmD5NSaCh9ZtdipA5Xk+U51PgFhm FtefxuJvlleLnQkI4Skme815q1Bv7eDf5ZTFBCVj0YcajSjD3b+m+62xALf7mFsRr5JS FwLg8uTG04iW4YZOez8VVY+7M4WgLg5sT1fq28gvIj9gxbVDDra+iB54jnHu0MnFKsl/ dN/2KUF5ajmi8g65N9H9pr+Y7w9+KLAbkNf7kDz65RHmIIV3yH9cdB/lfGbRaYnGWw3+ O9ZA== X-Gm-Message-State: AAQBX9dMEz8y1JMKzDXZ7+1GuKY3wwzaleBgDnOqc0kO6pzppQo252Vv Pgt6ZGFO/d0WyV6DwSnejaW15w== X-Google-Smtp-Source: AKy350ZEODeEm9sOvgyuO0IIzT81OsrB7gbD3ClS6luG0xT13OBKwnwD8262UKlr8jcIal295NttLw== X-Received: by 2002:a19:f508:0:b0:4db:3a70:e9f3 with SMTP id j8-20020a19f508000000b004db3a70e9f3mr35061lfb.69.1680805797945; Thu, 06 Apr 2023 11:29:57 -0700 (PDT) Received: from [192.168.1.101] (abxh37.neoplus.adsl.tpnet.pl. [83.9.1.37]) by smtp.gmail.com with ESMTPSA id r15-20020ac25a4f000000b004e848782e2esm371641lfn.57.2023.04.06.11.29.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 11:29:57 -0700 (PDT) Message-ID: Date: Thu, 6 Apr 2023 20:29:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/4] arm64: dts: qcom: sm6115-j606f: Add ramoops node Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Kees Cook , Tony Luck , "Guilherme G. Piccoli" Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20230406-topic-lenovo_features-v1-0-c73a5180e48e@linaro.org> <20230406-topic-lenovo_features-v1-1-c73a5180e48e@linaro.org> <9554be2b-c80d-8c5b-48e3-2508a7b4ecd1@linaro.org> From: Konrad Dybcio In-Reply-To: <9554be2b-c80d-8c5b-48e3-2508a7b4ecd1@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6.04.2023 19:54, Dmitry Baryshkov wrote: > On 06/04/2023 18:25, Konrad Dybcio wrote: >> Add a ramoops node to enable retrieving crash logs. >> >> Signed-off-by: Konrad Dybcio >> --- >>   arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 11 +++++++++++ >>   1 file changed, 11 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts >> index 10c9d338446c..fd064899791c 100644 >> --- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts >> +++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts >> @@ -52,6 +52,17 @@ key-volume-up { >>               wakeup-source; >>           }; >>       }; >> + >> +    reserved-memory { >> +        ramoops@ffc00000 { >> +            compatible = "ramoops"; >> +            reg = <0x0 0xffc00000 0x0 0x100000>; >> +            record-size = <0x1000>; >> +            console-size = <0x40000>; > > no ftrace-size? It could use some! > >> +            ecc-size = <16>; >> +            no-map; > > I see that other ramoops defines are not marked with no-map. Is there any reason for that? Hm, not really. I can get rid of it for v2. Konrad > >> +        }; >> +    }; >>   }; >>     &dispcc { >> >