From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH v4] KVM: emulate: Don't inject #GP when emulating RDMPC if CR0.PE=0
Date: Wed, 20 Oct 2021 11:01:58 +0200 [thread overview]
Message-ID: <ead08efc-ab79-7646-3d19-6d808097f688@redhat.com> (raw)
In-Reply-To: <1634719951-73285-1-git-send-email-wanpengli@tencent.com>
On 20/10/21 10:52, Wanpeng Li wrote:
> From: Wanpeng Li<wanpengli@tencent.com>
>
> SDM mentioned that we should #GP for rdpmc if ECX is not valid or
> (CR4.PCE is 0 and CPL is 1, 2, or 3 and CR0.PE is 1).
>
> Let's add the CR0.PE is 1 checking to rdpmc emulate, though this isn't
> strictly necessary since it's impossible for CPL to be >0 if CR0.PE=0.
>
> Reviewed-by: Sean Christopherson<seanjc@google.com>
> Signed-off-by: Wanpeng Li<wanpengli@tencent.com>
> ---
> v3 -> v4:
> * add comments instead of pseudocode
No, the commit message was fine. What I meant is there's no need to
change the code. Just add a comment about why CR0.PE isn't tested.
Paolo
next prev parent reply other threads:[~2021-10-20 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 8:52 Wanpeng Li
2021-10-20 9:01 ` Paolo Bonzini [this message]
2021-10-20 10:15 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ead08efc-ab79-7646-3d19-6d808097f688@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®