From: Yicong Yang <yangyicong@huawei.com>
To: Junhao He <hejunhao3@huawei.com>, <will@kernel.org>,
<jonathan.cameron@huawei.com>, <linux-kernel@vger.kernel.org>
Cc: <yangyicong@hisilicon.com>,
<linux-arm-kernel@lists.infradead.org>, <linuxarm@huawei.com>,
<prime.zeng@hisilicon.com>
Subject: Re: [PATCH] drivers/perf: hisi: Fix some event id for HiSilicon UC pmu
Date: Tue, 5 Dec 2023 11:56:32 +0800 [thread overview]
Message-ID: <ead56142-e0a5-d061-b8f9-02add7a3b211@huawei.com> (raw)
In-Reply-To: <20231204110425.20354-1-hejunhao3@huawei.com>
On 2023/12/4 19:04, Junhao He wrote:
> Some event id of HiSilicon uncore UC PMU driver is incorrect, fix them.
>
> Fixes: 312eca95e28d ("drivers/perf: hisi: Add support for HiSilicon UC PMU driver")
> Signed-off-by: Junhao He <hejunhao3@huawei.com>
Reviewed-by: Yicong Yang <yangyicong@hisilicon.com>
> ---
> drivers/perf/hisilicon/hisi_uncore_uc_pmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/perf/hisilicon/hisi_uncore_uc_pmu.c b/drivers/perf/hisilicon/hisi_uncore_uc_pmu.c
> index 63da05e5831c..636fb79647c8 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_uc_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_uc_pmu.c
> @@ -383,8 +383,8 @@ static struct attribute *hisi_uc_pmu_events_attr[] = {
> HISI_PMU_EVENT_ATTR(cpu_rd, 0x10),
> HISI_PMU_EVENT_ATTR(cpu_rd64, 0x17),
> HISI_PMU_EVENT_ATTR(cpu_rs64, 0x19),
> - HISI_PMU_EVENT_ATTR(cpu_mru, 0x1a),
> - HISI_PMU_EVENT_ATTR(cycles, 0x9c),
> + HISI_PMU_EVENT_ATTR(cpu_mru, 0x1c),
> + HISI_PMU_EVENT_ATTR(cycles, 0x95),
> HISI_PMU_EVENT_ATTR(spipe_hit, 0xb3),
> HISI_PMU_EVENT_ATTR(hpipe_hit, 0xdb),
> HISI_PMU_EVENT_ATTR(cring_rxdat_cnt, 0xfa),
>
next prev parent reply other threads:[~2023-12-05 4:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 11:04 Junhao He
2023-12-05 3:56 ` Yicong Yang [this message]
2023-12-05 15:16 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ead56142-e0a5-d061-b8f9-02add7a3b211@huawei.com \
--to=yangyicong@huawei.com \
--cc=hejunhao3@huawei.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=prime.zeng@hisilicon.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®