From: "Tim Pepper" <lnxninja@us.ibm.com>
To: pbadari@us.ibm.com
Cc: "Andrew Morton" <akpm@osdl.org>, "Nathan Scott" <nathans@sgi.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] change buffer_head.b_size to size_t
Date: Mon, 6 Mar 2006 11:54:45 -0800 [thread overview]
Message-ID: <eada2a070603061154p3528a099if5e640d6da2ca9e1@mail.gmail.com> (raw)
In-Reply-To: <20060301185616.69986425.akpm@osdl.org>
If you're looking for nice wording: I forget if it is Linux Device
Drivers, Understanding the Linux Kernel or Linux Kernel Development,
but more or less combined they manage to describe the bastard state of
what struct buffer_head used to be and how bio coming along leaves bh
primarily as mapping between a memory buffer and a disk block. With
block related things being abstracted cleaner as of 2.6 (and that
hopefully being a continuing goal) I'd vote for any change to this
struct's comment focusing on what the struct is meant to do, not what
abstractions have been (ab)used to accomplish different things over
time.
Tim
next prev parent reply other threads:[~2006-03-06 19:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-27 21:20 [PATCH 0/4] map multiple blocks in get_block() and mpage_readpages() Badari Pulavarty
2006-02-27 21:22 ` [PATCH 1/4] change buffer_head.b_size to size_t Badari Pulavarty
2006-03-02 1:51 ` Andrew Morton
2006-03-02 1:51 ` Andrew Morton
2006-03-02 2:22 ` Nathan Scott
2006-03-02 2:56 ` Andrew Morton
2006-03-06 19:54 ` Tim Pepper [this message]
2006-02-27 21:23 ` [PATCH 2/4] pass b_size to ->get_block() Badari Pulavarty
2006-03-02 1:52 ` Andrew Morton
2006-03-03 17:17 ` Badari Pulavarty
2006-02-27 21:24 ` [PATCH 3/4] map multiple blocks for mpage_readpages() Badari Pulavarty
2006-03-02 4:45 ` Andrew Morton
2006-03-03 16:51 ` Badari Pulavarty
2006-02-27 21:24 ` [PATCH 4/4] remove ->get_blocks() support Badari Pulavarty
2006-03-02 1:52 ` [PATCH 0/4] map multiple blocks in get_block() and mpage_readpages() Andrew Morton
2006-03-03 17:05 ` Badari Pulavarty
2006-03-03 20:32 ` Andrew Morton
2006-03-03 21:54 ` Badari Pulavarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eada2a070603061154p3528a099if5e640d6da2ca9e1@mail.gmail.com \
--to=lnxninja@us.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathans@sgi.com \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®