From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74BF8340415 for ; Tue, 19 May 2026 14:04:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779199476; cv=none; b=I4L/l9r0Oe+kDp3Y8JWwodlkJ0xC/7263jcWHefE731Npk3R8KhaZgL/RInj56losHtMyWNi8meWyRJNmsYlWFyDTA11CM42WXhJIa85PpWceg2p2Tju/n0KDaiZNL5my9nRjBMraXO6UDBQRvsG5xr1jfA5NDAjuL3PJUgO9to= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779199476; c=relaxed/simple; bh=FMaMUKz/x8QbjfR3g5V6+iL3OxM0o0sNRaKeIldoQQ0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GKHYehA9AezAFb9e33ddMlScLhhi+xRvrpJWWvZnzdqCalfKveYTpHyX1X//NbVKHC2IqoxTb3a7Ca1lnup3effiCQ+ZLcn4TstCI+wkMMdVzDUoY2iPLXtWDG8tEZl4sRqatTHyOCzR/IP6Zru9GsUCJVa6FMxbtg292nhihpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DlxNFjN3; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=BwGqlPGP; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DlxNFjN3"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="BwGqlPGP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779199471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JyK79IEx4ySepGt4cTN7KOjcr0GF19I7WDCAu3CkGGI=; b=DlxNFjN3lyvNeNWdth2K8s1+gqMkhAWouoKTLoCcoB36t5YuyhcVqkRJJ3Ir9dgp+4xAkD BA+y0buyHlQ2eKLRWThCA2Jsd2dp8MZQTh9CQeXXBAPBRDZ57BQVjAkHuhW+2MCGb5AB6b iYdfBmAzkt5hB88fr9l2c+nhfwIaY3g= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-322-rdy-vfM9OVWJw7LvggeQrA-1; Tue, 19 May 2026 10:04:18 -0400 X-MC-Unique: rdy-vfM9OVWJw7LvggeQrA-1 X-Mimecast-MFC-AGG-ID: rdy-vfM9OVWJw7LvggeQrA_1779199457 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-43ff19e54beso2451308f8f.2 for ; Tue, 19 May 2026 07:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779199456; x=1779804256; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JyK79IEx4ySepGt4cTN7KOjcr0GF19I7WDCAu3CkGGI=; b=BwGqlPGPyTAEKuDwo8sJ84HiXt9d6LyIl3O6pJQ3hFJOV4X0PKuplQNp5LYIT5tB3W jvYM2P1TV4Ezar8/q2HeMsjw+6oduw9NQD8f/Hb0CxUzal9g5uUqJrYPYRRryByceluC dN+sGVRQWEkkApEI9FS4l42ymmv6oRo5fa4yDkCGQYSpQJ+2Kw/S4P2ZS7+TICNjVrMc /H2GzVj7PBn6KpvYWQafxXhQfq5dJT5yS3XCF4/o9+sEC6gxlvL4jze434UqMaL0jH3F ekmJ6zok9+j/itf1kcEJY5lMyadAa/kjXBfmEp9QEGC+/nTaVVsIpHljlx5YsJjmxU2W G0Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779199456; x=1779804256; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JyK79IEx4ySepGt4cTN7KOjcr0GF19I7WDCAu3CkGGI=; b=FZ2WVgl+oN+Fhf+xYYU87TYY05v5JQ725R9TGiQkG0rAF9qWJcSWjyjDtv9N3Mge3d pjoGr8/NxsNzF3vbdx6f8lFzeqWtSFcWw10pARSzr0OVsTyJkpJBzvAlC4h72Vq6tMyp QiwwL4GWgxM/DbKRf/9xice5b0kmn2OGGq/4uP/sRHvaItUA6VyKT0Ebt8Rmjc4HMFV2 IECDoD1VT/80nmJZBMFbGX0x6A+tjAoKKeYQMXoAMEBBjihjSb7nuHSwRzUeqjamyOqq tLM8bf5mXApM8zq4qgR5KIV4AVU6Sdfjid51bXY9YTqErrWOFGKPP7Z3DCj8ss8w6D2y K3mA== X-Forwarded-Encrypted: i=1; AFNElJ+0ddRz0TeLvuz6vPVEz5Dx8auMXQwR1PujDnumgc+x1x7CLQ8bZUg5vgoWwa3aKm0CWVy+cAPxEeNWHBk=@vger.kernel.org X-Gm-Message-State: AOJu0YyPPQgbQeEE6S34sp+z+SUYt7AkshgWu+s4LdgyIBzuiGfLY4bB EKZYx/HQZIUQkmBzzekbPNsAeTTGBHhCASRDxjbbV9tgJ82ZIrAcn8IJBdooDctpxzA5XDvZh+V eZ9ohaT6RkP/lHl/n4Eg8KDe9zlQ077zZQchOaDf/hm9Aey/5My6c/qC6UUvSJC99RA== X-Gm-Gg: Acq92OEwrazcyWV2NvtD9qRE6jDh4o955OQie1pLUVhfCFXLd3324ebqrbhuCgM2NQU 8knrafhP8wwmWtsDS1p/ieqTzXissxLoKt2EGn1sxR9hYmqJn3hHUsT2Wb5ym+XMObzFivHdtQy LLPVr9uZMYupheh7TEuq7hgUgYq0aPLB6HL6Pc8FhEUkDl9zzmu30tF4vhoEdBNg/OfhmlX4nbI Zuda+r1Bm8h6LyOpU/7hbN/YlhVMGiQSnYfdmSe+SmuVCWEHr01y1ICm5VMNQpkO6IP2de8g4pe BBuAWI/UMVHZLfzB3SW4jgdbW8a/pdJFnwjd+d5rhbnSqBjQ1BAbHMWAO/C6SoLK8uJF7+tR7FS zr3mSJFqVYw322ESS2SpI2b+SVYQASPbN0UQFqPJlkWbFjZO3gyC7sV8= X-Received: by 2002:a05:600c:34cd:b0:488:936a:6220 with SMTP id 5b1f17b1804b1-48fe61f2c03mr335533525e9.21.1779199456385; Tue, 19 May 2026 07:04:16 -0700 (PDT) X-Received: by 2002:a05:600c:34cd:b0:488:936a:6220 with SMTP id 5b1f17b1804b1-48fe61f2c03mr335532795e9.21.1779199455912; Tue, 19 May 2026 07:04:15 -0700 (PDT) Received: from [192.168.88.32] ([150.228.25.33]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe57943b2sm337222105e9.8.2026.05.19.07.04.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 07:04:15 -0700 (PDT) Message-ID: Date: Tue, 19 May 2026 16:04:12 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 3/7] atm: convert to getsockopt_iter To: Breno Leitao , Chas Williams <3chas3@gmail.com>, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , Magnus Karlsson , Maciej Fijalkowski , Stanislav Fomichev , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Jon Maloy , Alexandra Winter , Thorsten Winkler , James Chapman , David Howells , Marc Dionne , David Heidelberg , Samuel Ortiz Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-s390@vger.kernel.org, linux-afs@lists.infradead.org, oe-linux-nfc@lists.linux.dev, kernel-team@meta.com References: <20260515-getsock_four-v2-0-0d8eed952627@debian.org> <20260515-getsock_four-v2-3-0d8eed952627@debian.org> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260515-getsock_four-v2-3-0d8eed952627@debian.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/15/26 10:32 AM, Breno Leitao wrote: > @@ -797,13 +798,13 @@ int vcc_setsockopt(struct socket *sock, int level, int optname, > } > > int vcc_getsockopt(struct socket *sock, int level, int optname, > - char __user *optval, int __user *optlen) > + sockopt_t *opt) > { > struct atm_vcc *vcc; > + int val; I *think* you should use 'unsigned long' here to avoid user-visible changes due to put_user() replacement. /P