From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Helge Deller <deller@gmx.de>, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v2] vt: modify a constant prefix that looks like a ReST target
Date: Tue, 17 Nov 2026 16:15:34 -0800 [thread overview]
Message-ID: <eaecfa26-bb29-45ad-9bed-9c766f3c7b62@infradead.org> (raw)
In-Reply-To: <20261104182258.3226665-1-rdunlap@infradead.org>
ping?
On 11/4/26 10:22 AM, Randy Dunlap wrote:
> Use CUR_* (could also be something like CUR_x) instead of just "CUR_"
> because the ending '_' indicates a documentation target name, so
> unconfuse the name.
> Precede it with '%' to indicate that it is a constant.
>
> Prevents these warnings:
>
> Documentation/driver-api/tty/console:36: drivers/tty/vt/vt.c:275: ERROR: Unknown target name: "cur". [docutils]
> Documentation/driver-api/tty/console:36: drivers/tty/vt/vt.c:317: ERROR: Unknown target name: "cur". [docutils]
> Documentation/driver-api/tty/console:36: drivers/tty/vt/vt.c:353: ERROR: Unknown target name: "cur". [docutils]
>
> Fixes: 1438d00569c4 ("vt: Add cursor-size helpers")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> v2: Precede "CUR_*" with a '%' to indicate constant. (Jiri)
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jirislaby@kernel.org>
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-serial@vger.kernel.org
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Helge Deller <deller@gmx.de>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Shuah Khan <skhan@linuxfoundation.org>
> Cc: linux-doc@vger.kernel.org
>
> drivers/tty/vt/vt.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- linux-next-20261102.orig/drivers/tty/vt/vt.c
> +++ linux-next-20261102/drivers/tty/vt/vt.c
> @@ -273,7 +273,7 @@ EXPORT_SYMBOL_GPL(vc_font_size);
> * vc_cursor_valid_size - Computes a valid cursor size from the given value
> * @cursor_size: The size constant of cursor pattern
> *
> - * The argument given in @cursor_size is one of the CUR_ constants, as stored
> + * The argument given in @cursor_size is one of the %CUR_* constants, as stored
> * in struct @vc_data.vc_cursor_type. For unknown values, the helper draws the
> * default cursor or an underline dash.
> *
> @@ -317,7 +317,7 @@ EXPORT_SYMBOL_GPL(vc_cursor_valid_size);
> *
> * The parameter @cell_height is the height of the character cell as
> * displayed by the console. The argument given in @cursor_size is one
> - * of the CUR_ constants. See vc_cursor_valid_size() for how to get a
> + * of the %CUR_* constants. See vc_cursor_valid_size() for how to get a
> * valid cursor-size constant.
> *
> * Returns:
> @@ -353,7 +353,7 @@ EXPORT_SYMBOL_GPL(vc_cursor_start);
> *
> * The parameter @cell_height is the height of the character cell as
> * displayed by the console. The argument given in @cursor_size is one
> - * of the CUR_ constants. See vc_cursor_valid_size() for how to get a
> + * of the %CUR_* constants. See vc_cursor_valid_size() for how to get a
> * valid cursor-size constant.
> *
> * Returns:
>
--
~Randy
prev parent reply other threads:[~2026-11-18 0:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 18:22 Randy Dunlap
2026-11-18 0:15 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaecfa26-bb29-45ad-9bed-9c766f3c7b62@infradead.org \
--to=rdunlap@infradead.org \
--cc=corbet@lwn.net \
--cc=deller@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®