From: Markus Elfring <Markus.Elfring@web.de>
To: Ma Ke <make24@iscas.ac.cn>,
dmaengine@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Vinod Koul <vkoul@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: axi-dmac: Add check for dma_set_max_seg_size
Date: Sun, 23 Jun 2024 15:23:40 +0200 [thread overview]
Message-ID: <eaf19171-ef94-4370-a774-1f67d0eb878d@web.de> (raw)
In-Reply-To: <20240623081644.2089695-1-make24@iscas.ac.cn>
> To avoid possible failure of the dma_set_max_seg_size(),
Really?
It is desirable to detect a failed function call, isn't it?
> we should better check the return value of the dma_set_max_seg_size().
1. Please choose an imperative wording for an improved change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc4#n94
2. Would you like to add any tags (like “Fixes” and “Cc”) accordingly?
3. How do you think about to append the text “() in axi_dmac_probe()”
to the summary phrase?
Regards,
Markus
prev parent reply other threads:[~2024-06-23 13:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 8:16 Ma Ke
2024-06-23 13:23 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaf19171-ef94-4370-a774-1f67d0eb878d@web.de \
--to=markus.elfring@web.de \
--cc=dmaengine@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®