mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Vyukov <dvyukov@google.com>
To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	 dave.hansen@linux.intel.com, x86@kernel.org
Cc: linux-kernel@vger.kernel.org, syzkaller@googlegroups.com,
	elver@google.com,  glider@google.com, nogikh@google.com,
	tarasmadan@google.com,  Dmitry Vyukov <dvyukov@google.com>
Subject: [PATCH v2 4/4] x86: Ignore stack unwinding in KCOV
Date: Tue, 11 Jun 2024 09:50:33 +0200	[thread overview]
Message-ID: <eaf54b8634970b73552dcd38bf9be6ef55238c10.1718092070.git.dvyukov@google.com> (raw)
In-Reply-To: <cover.1718092070.git.dvyukov@google.com>

Stack unwinding produces large amounts of uninteresting coverage.
It's called from KASAN kmalloc/kfree hooks, fault injection, etc.
It's not particularly useful and is not a function of system call args.
Ignore that code.

Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
Reviewed-by: Alexander Potapenko <glider@google.com>
Reviewed-by: Marco Elver <elver@google.com>
Cc: x86@kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: syzkaller@googlegroups.com
---
 arch/x86/kernel/Makefile | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
index 20a0dd51700a..cd49ebfae984 100644
--- a/arch/x86/kernel/Makefile
+++ b/arch/x86/kernel/Makefile
@@ -39,6 +39,14 @@ KMSAN_SANITIZE_sev.o					:= n
 # first second.
 KCOV_INSTRUMENT_head$(BITS).o				:= n
 KCOV_INSTRUMENT_sev.o					:= n
+# These are called from save_stack_trace() on debug paths,
+# and produce large amounts of uninteresting coverage.
+KCOV_INSTRUMENT_stacktrace.o				:= n
+KCOV_INSTRUMENT_dumpstack.o				:= n
+KCOV_INSTRUMENT_dumpstack_$(BITS).o			:= n
+KCOV_INSTRUMENT_unwind_orc.o				:= n
+KCOV_INSTRUMENT_unwind_frame.o				:= n
+KCOV_INSTRUMENT_unwind_guess.o				:= n
 
 CFLAGS_irq.o := -I $(src)/../include/asm/trace
 
-- 
2.45.2.505.gda0bf45e8d-goog


  parent reply	other threads:[~2024-06-11  7:50 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11  7:50 [PATCH v2 0/4] KCOV fixes Dmitry Vyukov
2024-06-11  7:50 ` [PATCH v2 1/4] x86/entry: Remove unwanted instrumentation in common_interrupt() Dmitry Vyukov
2024-06-19 11:19   ` Peter Zijlstra
2024-06-19 13:05     ` Dmitry Vyukov
2024-08-08 15:49   ` [tip: x86/build] " tip-bot2 for Dmitry Vyukov
2024-06-11  7:50 ` [PATCH v2 2/4] kcov: add interrupt handling self test Dmitry Vyukov
2024-06-11  9:29   ` Marco Elver
2024-06-13 23:01   ` Andrey Konovalov
2024-06-19 11:13   ` Peter Zijlstra
2024-06-19 11:18     ` Dmitry Vyukov
2024-06-19 11:26       ` Peter Zijlstra
2024-08-08 15:49   ` [tip: x86/build] kcov: Add " tip-bot2 for Dmitry Vyukov
2024-06-11  7:50 ` [PATCH v2 3/4] module: Fix KCOV-ignored file name Dmitry Vyukov
2024-06-11  9:29   ` Marco Elver
2024-06-13 22:55   ` Andrey Konovalov
2024-08-08 15:49   ` [tip: x86/build] " tip-bot2 for Dmitry Vyukov
2024-06-11  7:50 ` Dmitry Vyukov [this message]
2024-06-13 22:51   ` [PATCH v2 4/4] x86: Ignore stack unwinding in KCOV Andrey Konovalov
2024-06-19 11:23   ` Peter Zijlstra
2024-06-19 13:10     ` Dmitry Vyukov
2024-08-08 15:49   ` [tip: x86/build] " tip-bot2 for Dmitry Vyukov
2024-06-11  9:31 ` [PATCH v2 0/4] KCOV fixes Dmitry Vyukov
2024-06-19  5:20   ` Dmitry Vyukov
2024-06-19  8:30     ` Borislav Petkov
2024-08-05 12:52       ` Andrey Konovalov
2024-08-08 15:18         ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eaf54b8634970b73552dcd38bf9be6ef55238c10.1718092070.git.dvyukov@google.com \
    --to=dvyukov@google.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=elver@google.com \
    --cc=glider@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nogikh@google.com \
    --cc=syzkaller@googlegroups.com \
    --cc=tarasmadan@google.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®