From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753301AbcGTC6n (ORCPT ); Tue, 19 Jul 2016 22:58:43 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:35302 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752577AbcGTC6i (ORCPT ); Tue, 19 Jul 2016 22:58:38 -0400 X-Auth-Info: HXgQP1OQ6o7BHLJ8OFppfu2NL62Y1ljDT24Q1y5RTs4= Subject: Re: [PATCH] mtd: spi-nor: don't build Cadence QuadSPI on non-ARM To: Brian Norris References: <201607190315.0nkQuD2W%fengguang.wu@intel.com> <20160718202026.GB137880@google.com> <578DC294.5090605@denx.de> <20160719200541.GA854@google.com> <3a769a42-f856-5b48-dd18-ef76a7bf4c91@denx.de> <20160720025027.GA131957@google.com> Cc: Stefan Roese , kbuild test robot , x86@kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, kbuild-all@01.org, Graham Moore From: Marek Vasut Message-ID: Date: Wed, 20 Jul 2016 04:58:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160720025027.GA131957@google.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/20/2016 04:50 AM, Brian Norris wrote: > On Wed, Jul 20, 2016 at 03:50:27AM +0200, Marek Vasut wrote: >> On 07/19/2016 10:05 PM, Brian Norris wrote: >>> On Tue, Jul 19, 2016 at 08:03:00AM +0200, Stefan Roese wrote: >>>> On 18.07.2016 22:20, Brian Norris wrote: >>>>> Hmm, does x86 not define readsl()/writesl()? I can never tell what >>>>> accessors are supposed to be "standard" across architectures. >>>>> >>>>> Either we need to drop the COMPILE_TEST or maybe make it (!X86 && >>>>> COMPILE_TEST). >>>> >>>> iowrite32_rep() etc should work for x86 as well. >>> >>> Looks like it might. I'm not sure the original submitter can retest >>> right now (travel), so I'd probably rather just take the easy fix for >>> now, and we can widen to COMPILE_TEST later if desired. >> >> Isn't there a generic readsl() and writesl() implementation in >> include/asm-generic/io.h ? > > Yes, but somehow x86 has managed to avoid that. I guess it's optional > for arch//include/asm/io.h to include ? At any > rate, I double-checked myself by adding '#error "blah"' to > include/asm-generic/io.h, and x86 still seemed to build fine (at least > for the modules I was checking, like cadence-quadspi.o). Yep, I just checked the same and it's not included from arch/x86/include/asm/io.h for whatever reason. Maybe this needs to be fixed on x86 level? >>> If I could get an ack on something like this, I'll apply it soon: >> >> This is fine, I am making a note to revisit this. > > Cool. In that case... > >>> ---8<--- >>> From: Brian Norris >>> Date: Tue, 19 Jul 2016 13:02:40 -0700 >>> Subject: [PATCH] mtd: spi-nor: don't build Cadence QuadSPI on non-ARM >>> >>> This controller driver is used only on ARM but is mostly written >>> portably so it can build on other arch'es. Unfortunately, at least x86 >>> doesn't provibe readsl()/writesl() accessors. We could possibly fix this >>> issue in the future by using io{read,write}32_rep() instead, but let's >>> just drop the architectures we aren't using for now. >>> >>> Signed-off-by: Brian Norris > > Applied. Thanks > Brian > -- Best regards, Marek Vasut