From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E82335F184 for ; Tue, 7 Jul 2026 05:41:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783402912; cv=none; b=MFXWwfS8D2NEvE5jW63B8jW2OO2aXYX4ILFh+8UuxWtk6+A3fWRpJQmKkMEVhW72PRK65RIahQ2cEf1Ty7/3te9xCt8kq9kRZGgeor/r3ScKjhQKyov8oHXFII6GaziKZowf6k/c0FGKGHS3xG/3JX2CaVPMBay0AyYvlAODVw0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783402912; c=relaxed/simple; bh=l5COQz7+rKfKHFX3vjfY9rDdWBq8Vjg4dSzVshOnYuw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g3mLjWVn6Rw0TZdYBKWvdKWThZVcBm3Jf8x/ghTMeVQMpoOJFu3o0K6BNzPskfMFlkaWntRjFuByXeLjZhswjnH3LGxvEaJPovvYqrK3gpxkJl0jhlbZe7BLciaSJRInc3S6utbzChiAOUOUH9nnBFiT59tdqT0noa/+vbYga1A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZHhxHNv3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IxG0epPv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZHhxHNv3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IxG0epPv" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66748qLq2687488 for ; Tue, 7 Jul 2026 05:41:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ow/eYL8dueLqt/B+l/aviyIZSIeIrdYbf3Z3NhMMHok=; b=ZHhxHNv3oNKYdllQ HccPBJl83ODUJG7oL7Kx2LsFfGE5GuDSMP6LgfHNgnxLzfUtVuj1V32G7gHx1pAk y0TKnf6j7RkHtdxQVal94OSBWhHZc9llnTlrkltz0+dE7GcY+Gv9yfsrYXY0uuCo uC/T+eZ5yDlQHgquP6cTsihcMV2VQo+IOPLgYlr/ISrEJwNsYouQRZFnFr9Hy0pC Jqzyr5jwN+pBbnb8ZRorxlOktNjIH7bD5lgMVUsUGJF4CDnhgOZfxV27jo6zBkh6 0Yaw6nUkwSANqapnogCMEdFFKVzefTjl7lZlq/4KchuaEbRz89/M9R0+e9R5IFCU 1vl4oQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8a3gvbfr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 05:41:50 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84622d6102dso5384866b3a.1 for ; Mon, 06 Jul 2026 22:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783402910; x=1784007710; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ow/eYL8dueLqt/B+l/aviyIZSIeIrdYbf3Z3NhMMHok=; b=IxG0epPvdaVVTDq8VL8zamQYBX4j4bcknJddBPuNjfZvsxegbIb/JSCnDHwJHEDefV 7piNRtNCqFV0trAtcyFN+qghkhFxfSglJ6wbHnWUYTcB2UmKZRTOd0b0VhwjizKGvVSw sXDCXHpVp/BkutqgDdVbBy5VoEVi/R5lxZnGOLrPO1Od6kjtKlANOxS7Wp21PGR3SpkB 3pZFubKEEvrJPCHkwgXG0XLrGcgiWs3ibm2paRBZBTpIZvqTImY8GykrkhJtfyOxNzr+ 2fwMzhDpv4ihI394tk5oXAFu5m5esslSrUS25vU1tnxfKdbqpF7AfCLLaV7If2UzEAVG w5XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783402910; x=1784007710; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ow/eYL8dueLqt/B+l/aviyIZSIeIrdYbf3Z3NhMMHok=; b=dVeZZgLaVVrdk09yg39l8vGNO/FAvnkH85eF/kPAAtwZgEBT5JSUHRvoDBvQvprMqA qweBxoXJRFjv3yjkQ3Q9nCa1ooomcIRdeHdhna3RhHyuUdOvmUAm4L4g5zzlupeo1EUe ZY1qlMrJgTSZK6v1oTMVnRzfGNARsgs5Ehjx+G4tbEI4RC6KJC5/PEW3Bfi7mkaI4nAW YS+Bx1sPSY/ialkNPn1GlKW6yZbGeVZRjsyDGBrtHaWbH+7OnYS5Kv4NE/59/f6jJBNC oqWS4mAmQ6ouHcebgdjNqOM/DEnMi/4laeo7xhe9qogRzTYxrpyQ7mRAcvN/CbZwz47c /Wew== X-Forwarded-Encrypted: i=1; AHgh+Rqb4yWAlnE/r+/A3LsJpHFnTRlGUzefEhcQc3NuFBbElWXbLFixok5moz8sA4hQvAjggfAD1pteJoKitHY=@vger.kernel.org X-Gm-Message-State: AOJu0YyOyV7q1xFJ2y0UGkvS7V+IGz1KTPhLPcf27b7a7KUp8Q02pZVK 7lsjwCdCw2UbEE4sS+SL2eMLAyBpear/Ajm25jqtNTKQH3fD+kyHqIAQ+LByNgMs8FKeyZ6OM7b +nVD6A+jcBvfCyFtlcYQh3lO7H4cB4nTrGUwXUIpLnpTAn38SpBd6L08TvJ9TdA3oJto= X-Gm-Gg: AfdE7ckCUgCB7nABDPUm3ftKHO23Z8zKq2FtDogmp7vIj7KE7FOb95BQNSacYCycCJx hW5dqZfXYQrP/HkNcIMsPefj5+7a7DXvj7p1+ag7xuBW7tN0I+YC/b0OB1EpEmaFhEYQQU3P9x+ Hc+ZMQsPVS82qhUNXgOwGggcYn8lco3HM7cH0Im9YyoSepKAx4agS+/LDFOEEz6eNdW8vrDKyaG rKObVXEYCoofjkmE4cLr44ZgkEjYKLlXLNaUxVYJd6WvZjPfCsPly3u8qIWDFP/w3EQn0xvJ19J aMORq0hEMBKtQI2pjYyahFvCwlnGA3mw6SaOuVAvs+g8/w15q0h+vUKd0npEqr+sqEmC96DiX1j 8VLZmvkGOAI1xyNcb6BHoJRDULP/4JoIvSzfhwfhVzhDcfsbBDxF12x+QeWcEr4w4CUH0BpgXfk wFIOFb X-Received: by 2002:a05:6a00:4fc1:b0:847:9c06:2bef with SMTP id d2e1a72fcca58-84826d3e5fbmr3666413b3a.29.1783402909994; Mon, 06 Jul 2026 22:41:49 -0700 (PDT) X-Received: by 2002:a05:6a00:4fc1:b0:847:9c06:2bef with SMTP id d2e1a72fcca58-84826d3e5fbmr3666389b3a.29.1783402909456; Mon, 06 Jul 2026 22:41:49 -0700 (PDT) Received: from ?IPV6:2405:201:c409:b03f:6d0b:bb83:7a67:4093? ([2405:201:c409:b03f:6d0b:bb83:7a67:4093]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6d7a96fsm4763011b3a.46.2026.07.06.22.41.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jul 2026 22:41:49 -0700 (PDT) Message-ID: Date: Tue, 7 Jul 2026 11:11:42 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/9] dt-bindings: PCI: qcom: Document the Shikra PCIe Controller To: "Rob Herring (Arm)" Cc: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Konrad Dybcio , Bjorn Andersson , Vinod Koul , Chaitanya Chundru , Bjorn Helgaas , devicetree@vger.kernel.org, Manivannan Sadhasivam , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-msm@vger.kernel.org, Conor Dooley , Neil Armstrong , linux-pci@vger.kernel.org, Bartosz Golaszewski References: <20260701-shikra-upstream-v1-0-e1a721eb8943@oss.qualcomm.com> <20260701-shikra-upstream-v1-2-e1a721eb8943@oss.qualcomm.com> <178285172593.288348.3890129606237873483.robh@kernel.org> Content-Language: en-US From: Sushrut Shree Trivedi In-Reply-To: <178285172593.288348.3890129606237873483.robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: T5naL_GXznhIlgZoI8SMECiAKQPeLMU6 X-Proofpoint-ORIG-GUID: T5naL_GXznhIlgZoI8SMECiAKQPeLMU6 X-Authority-Analysis: v=2.4 cv=CPYamxrD c=1 sm=1 tr=0 ts=6a4c919e cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=g4xDkRcHy8dAf5eKVigA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDA1MSBTYWx0ZWRfXxf2LgxekiGsz 5sSutDx2eoXEdjIDAKo4n6BgjTqU6Xonu3LnH3wDg3yaYDt3BuPu/LdLxWStYY2V9HlUgTRm9/W JDthaIXIGx3eTrJHjUpDWO6eL2zsaQRTjQ7QbkATfJG+YccK1UxZ+rz14LaFvNgv7+Gej8LAgZM 8Oz1uGXuLuXhMjGnBi0c8JbrqlXda1+GpTotyQEEuklyY0SuYTGgmwZDyZFbgz+NZoDcQaJM243 KU43o8W6tpYbeFWDdEi/ntP0G1rm7cr1xdM8mdSOR9AmbafK04mZ0BDSHRMuSpWZNanTlFWYO5s 5i7/6un9R+VhUUuBbYXI+cI1cQdn9uQ5KLYz93PGo8kVl+W0TS/CQ+zmXbkhNYq7H+RE3lKDADW g4a+Wi5RGFFCeDLLHaWg2DhHzKdxf8ZE/UkLvlFIilgFTdCBknl19V8DowwRjmiveOcwkgTUFts AkKIfHj9DoZL8Ye3MNw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDA1MSBTYWx0ZWRfX26pAnV3hLtc8 k764eAk1rbQ3i2/WYxY5GN1BWWlBElLl6FYXDmge4kzuknZ3V+ORXAcJh5qJwCg+VlqkNOTZh5M qwKm/kJIPG7tikOMp0HofjmVp4k3wh0= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_01,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070051 On 7/1/2026 2:05 AM, Rob Herring (Arm) wrote: > On Wed, 01 Jul 2026 00:32:44 +0530, Sushrut Shree Trivedi wrote: >> Add a dedicated schema for the PCIe controller found on the Shikra >> platform. >> >> Signed-off-by: Sushrut Shree Trivedi >> --- >> .../devicetree/bindings/pci/qcom,shikra-pcie.yaml | 211 +++++++++++++++++++++ >> 1 file changed, 211 insertions(+) >> > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:57.29-36 Unexpected 'GIC_SPI' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:57.41-60 Unexpected 'IRQ_TYPE_LEVEL_HIGH' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:58.29-36 Unexpected 'GIC_SPI' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:58.41-60 Unexpected 'IRQ_TYPE_LEVEL_HIGH' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:59.29-36 Unexpected 'GIC_SPI' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:59.41-60 Unexpected 'IRQ_TYPE_LEVEL_HIGH' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:60.29-36 Unexpected 'GIC_SPI' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:60.41-60 Unexpected 'IRQ_TYPE_LEVEL_HIGH' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:61.29-36 Unexpected 'GIC_SPI' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:61.41-60 Unexpected 'IRQ_TYPE_LEVEL_HIGH' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:62.29-36 Unexpected 'GIC_SPI' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:62.41-60 Unexpected 'IRQ_TYPE_LEVEL_HIGH' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:63.29-36 Unexpected 'GIC_SPI' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:63.41-60 Unexpected 'IRQ_TYPE_LEVEL_HIGH' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:64.29-36 Unexpected 'GIC_SPI' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:64.41-60 Unexpected 'IRQ_TYPE_LEVEL_HIGH' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:65.29-36 Unexpected 'GIC_SPI' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:65.41-60 Unexpected 'IRQ_TYPE_LEVEL_HIGH' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:76.56-75 Unexpected 'IRQ_TYPE_LEVEL_HIGH' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:77.56-75 Unexpected 'IRQ_TYPE_LEVEL_HIGH' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:78.56-75 Unexpected 'IRQ_TYPE_LEVEL_HIGH' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:79.56-75 Unexpected 'IRQ_TYPE_LEVEL_HIGH' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:83.30-46 Unexpected 'GCC_PCIE_AUX_CLK' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:84.30-50 Unexpected 'GCC_PCIE_CFG_AHB_CLK' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:85.30-51 Unexpected 'GCC_PCIE_MSTR_AXI_CLK' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:86.30-50 Unexpected 'GCC_PCIE_SLV_AXI_CLK' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:87.30-54 Unexpected 'GCC_PCIE_SLV_Q2A_AXI_CLK' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:88.30-58 Unexpected 'GCC_DDRSS_MEMNOC_PCIE_SF_CLK' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:89.30-59 Unexpected 'GCC_PCIE_TILE_AXI_SYS_NOC_CLK' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:90.30-55 Unexpected 'GCC_QMIP_PCIE_CFG_AHB_CLK' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:100.39-55 Unexpected 'GCC_PCIE_AUX_CLK' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:103.44-58 Unexpected 'MASTER_PCIE2_0' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:103.59-73 Unexpected 'RPM_ALWAYS_TAG' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:104.40-53 Unexpected 'SLAVE_EBI_CH0' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:104.54-68 Unexpected 'RPM_ALWAYS_TAG' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:105.41-56 Unexpected 'MASTER_AMPSS_M0' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:105.57-71 Unexpected 'RPM_ACTIVE_TAG' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:106.43-56 Unexpected 'SLAVE_PCIE2_0' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:106.57-71 Unexpected 'RPM_ACTIVE_TAG' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:114.30-42 Unexpected 'GCC_PCIE_BCR' > Lexical error: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dts:117.37-50 Unexpected 'GCC_PCIE_GDSC' > FATAL ERROR: Syntax error parsing input tree > make[2]: *** [scripts/Makefile.dtbs:140: Documentation/devicetree/bindings/pci/qcom,shikra-pcie.example.dtb] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1669: dt_binding_check] Error 2 > make: *** [Makefile:248: __sub-make] Error 2 > > doc reference errors (make refcheckdocs): > > See https://patchwork.kernel.org/project/devicetree/patch/20260701-shikra-upstream-v1-2-e1a721eb8943@oss.qualcomm.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. ACK'd. Sushrut >