From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754010AbcI0Ipj (ORCPT ); Tue, 27 Sep 2016 04:45:39 -0400 Received: from bear.ext.ti.com ([198.47.19.11]:36375 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752680AbcI0Ipg (ORCPT ); Tue, 27 Sep 2016 04:45:36 -0400 Subject: Re: [PATCH] matroxfb: fix size of memcpy To: Sudip Mukherjee , Jean-Christophe Plagniol-Villard References: <1472147052-26921-1-git-send-email-sudipm.mukherjee@gmail.com> CC: , From: Tomi Valkeinen Message-ID: Date: Tue, 27 Sep 2016 11:45:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1472147052-26921-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uhNaBj2aPC0M4Mo1goUBeM24Wie2ONlj3" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --uhNaBj2aPC0M4Mo1goUBeM24Wie2ONlj3 Content-Type: multipart/mixed; boundary="0uKxo0FVH3lsCE7g7svmOpJuVqkAVcS14"; protected-headers="v1" From: Tomi Valkeinen To: Sudip Mukherjee , Jean-Christophe Plagniol-Villard Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Message-ID: Subject: Re: [PATCH] matroxfb: fix size of memcpy References: <1472147052-26921-1-git-send-email-sudipm.mukherjee@gmail.com> In-Reply-To: <1472147052-26921-1-git-send-email-sudipm.mukherjee@gmail.com> --0uKxo0FVH3lsCE7g7svmOpJuVqkAVcS14 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 25/08/16 20:44, Sudip Mukherjee wrote: > hw->DACreg has a size of 80 bytes and MGADACbpp32 has 21. So when > memcpy copies MGADACbpp32 to hw->DACreg it copies 80 bytes but > only 21 bytes are valid. >=20 > Signed-off-by: Sudip Mukherjee > --- > drivers/video/fbdev/matrox/matroxfb_Ti3026.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/video/fbdev/matrox/matroxfb_Ti3026.c b/drivers/vid= eo/fbdev/matrox/matroxfb_Ti3026.c > index 195ad7c..68fa037 100644 > --- a/drivers/video/fbdev/matrox/matroxfb_Ti3026.c > +++ b/drivers/video/fbdev/matrox/matroxfb_Ti3026.c > @@ -372,7 +372,7 @@ static int Ti3026_init(struct matrox_fb_info *minfo= , struct my_timming *m) > =20 > DBG(__func__) > =20 > - memcpy(hw->DACreg, MGADACbpp32, sizeof(hw->DACreg)); > + memcpy(hw->DACreg, MGADACbpp32, sizeof(MGADACbpp32)); > switch (minfo->fbcon.var.bits_per_pixel) { > case 4: hw->DACreg[POS3026_XLATCHCTRL] =3D TVP3026_XLATCHCTRL_16_1; = /* or _8_1, they are same */ > hw->DACreg[POS3026_XTRUECOLORCTRL] =3D TVP3026_XTRUECOLORCTRL_PSEUD= OCOLOR; >=20 Thanks, queued for 4.9. Tomi --0uKxo0FVH3lsCE7g7svmOpJuVqkAVcS14-- --uhNaBj2aPC0M4Mo1goUBeM24Wie2ONlj3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX6jGqAAoJEPo9qoy8lh71IKoP/RanklVW1qIlnnjMFzrABbwa 8ptetnRY/9S56c34Bc9qhd5mAmtXL353GcOOzTy9ijV/t8Hy3sRMed33Ys4qOLlm A48JjVkilSByiZJ81/2V7AXpIF6nAUgfUIxvURN27XJ5PixHZqrnxpobA9oW+82s sVGf/DFm5bKWUdWvJV7QQ6Ca5+KfbUSnHjFtb/mRfyJLD8cZ9Epf1qHiVVVoKk11 Vow1rxBaW9mbJUvR7aerdBTxWE7MG+HmR953jFiJeLknc+wLL/Z2adHODBpDKGeD T/qRr1jCuojo+WJomuXcBuezdKwzt2uvwaQ6q9ZMNttYE5qN9Yvb8bxYFyo7BI3C fgcCNBtPIO8MP+pvf/SJWov+Ub1MF0A/KCQ2zLoezpFrHBB/Uzs0hLctKfQ60Zmd ctgLo5tvfDYyrpDAKCd+m45kWldWEtk+M1VoCEvZbomuyl0o4penxvlUwv+olY1Z PkHdg8yrC52hB+LrqeTA/i7uXM1SnYUh0nEjDW9fpYWZrEizE72rON00BCs95O2q Y9aLTa0DgwUTNzKpRVDcOhAjoGM5wvKEBPsct3e4e/yDNwdFu2x843uudpXjYzIq OLyrrp564vsOA7Hsafj49+h5ctycO+v7b88xXPwj9j/zQjeLqDNBiy+rFtHHgP2v QiDE2o1djTrhCmYtvsxu =zLyk -----END PGP SIGNATURE----- --uhNaBj2aPC0M4Mo1goUBeM24Wie2ONlj3--