From: Sinan Kaya <okaya@codeaurora.org>
To: Oza Oza <oza.oza@broadcom.com>, Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Jon Mason <jonmason@broadcom.com>,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
Andy Gospodarek <gospo@broadcom.com>,
linux-pci <linux-pci@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Oza Pawandeep <oza.pawandeep@gmail.com>,
Timur Tabi <timur@codeaurora.org>,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH v7 1/2] PCI: iproc: Retry request when CRS returned from EP
Date: Wed, 23 Aug 2017 11:52:40 -0400 [thread overview]
Message-ID: <eb01a01b-ee8a-1c51-69ba-838bfe94b6f6@codeaurora.org> (raw)
In-Reply-To: <CAMSpPPf5c2=zO81-7TEidOHbB8K0L3T2_wV4+9Gem5DB6rHWFw@mail.gmail.com>
Hi Oza,
> In working Enumuration case I get following:
> [ 9.125976] pci 0000:00:00.0: bridge configuration invalid ([bus
> 00-00]), re-configuring
> [ 9.134267] where=0x0 val=0xffff0001
> [ 9.146946] where=0x0 val=0xffff0001
> [ 9.158943] where=0x0 val=0xffff0001
> [ 9.170945] where=0x0 val=0xffff0001
> [ 9.186945] where=0x0 val=0xffff0001
> [ 9.210944] where=0x0 val=0xffff0001
> [ 9.250943] where=0x0 val=0xffff0001
> [ 9.322942] where=0x0 val=0xffff0001
> [ 9.458943] where=0x0 val=0xffff0001
> [ 9.726942] where=0x0 val=0x9538086 >> actual vendor and device id.
>
> so I think I have to retry in RC driver, so the old code still holds good.
> except that I have to do factoring out
You need to return 0xFFFF0001 for vendor ID register and return 0xFFFFFFFF for
other registers like COMMAND register during the CRS period.
>
> please let me know If I missed anything, or you want me to try anything else.
Sinan
next prev parent reply other threads:[~2017-08-23 15:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 15:58 [PATCH v7 0/2] PCI: iproc: SOC specific fixes Oza Pawandeep
2017-08-21 15:58 ` [PATCH v7 1/2] PCI: iproc: Retry request when CRS returned from EP Oza Pawandeep
2017-08-22 20:33 ` Bjorn Helgaas
2017-08-23 10:27 ` Oza Oza
2017-08-23 13:51 ` Bjorn Helgaas
2017-08-23 15:42 ` Oza Oza
2017-08-23 15:52 ` Sinan Kaya [this message]
2017-08-23 16:02 ` Oza Oza
2017-08-23 18:00 ` Bjorn Helgaas
2017-08-24 4:40 ` Oza Oza
2017-08-21 15:58 ` [PATCH v7 2/2] PCI: iproc: add device shutdown for PCI RC Oza Pawandeep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb01a01b-ee8a-1c51-69ba-838bfe94b6f6@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=alex.williamson@redhat.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=gospo@broadcom.com \
--cc=helgaas@kernel.org \
--cc=jonmason@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=oza.oza@broadcom.com \
--cc=oza.pawandeep@gmail.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®