From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 330DA34678E for ; Mon, 18 May 2026 11:44:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779104672; cv=none; b=uRchVkCSXDMrh5N4nMajJtNaRvrAgTh1rP5YVg3aqZUwnncxk+CJt9I+frmQ08Smbl92UyGHNoIk8KWtu8omB3xuhUFBIJio/WQSVMTxxRdceJsuRuiijOcYdLreSu4hUVSNNU4D1pJt5gkm6uD2bhvp7y4PQBXBOc2aF9h+x7A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779104672; c=relaxed/simple; bh=AgIcKUKxDlCgW6U/kszhR4FW2rEpaaGgBGwYrc4s2os=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ty4uC0zlAapv7dFyoMn4fs1XnGQDVJXpph2MOSm+nxLke2l8vmf41UnnyM3q+YfIdX22seTgeVK8gGMYEDirGGt+jcMzojQ2HQZeVZKkeKI5G4ai/BYbAaApJNiH5byKmM9E6vERJNEhMlKiUi0roWHfhjlU7Xt0/v4gbSktHSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hNRcAChD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NzgxW/i4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hNRcAChD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NzgxW/i4" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64IBHQsA2482382 for ; Mon, 18 May 2026 11:44:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= crnJptzUEns7NytfTpu/gd6vjFfjq64UULyy/cb5MAc=; b=hNRcAChD7hg/HwgQ k7/8BmqwwEWZrWpDuvAYRultwSlx0F6PkPMO5fsQGtTUQG26Azi/KcM+nS6jAc7a onPpiSqDph+bB92du+ZcBmRjhi4VdcwJRutglyCRniRuwlxq7QW/F4dPe68ngpOs 3warPGI9Ir+TfFXNVjo1fyixNLEwv4PbolvWUotxpMHOFoq072D1XDrrNpNwWnQM N8HOvC9yc8HS3Tyrq0LxTBhT+t1cr6vfmN8JLVX3Z5FdZlgM+3TeTJMn92MAtchb zMlfK2Gnuak+jKOpqkKbkmtre2BJ6r/Q184DJ/PoOuSTtZVw65ZzVcbb9JhdyjJA QtoUTg== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e81rvg2up-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 11:44:30 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50fb98b09d3so7948251cf.2 for ; Mon, 18 May 2026 04:44:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779104669; x=1779709469; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=crnJptzUEns7NytfTpu/gd6vjFfjq64UULyy/cb5MAc=; b=NzgxW/i4OCYKhlRzYU6W5R048IbBMl74nthOQ/C3KFA/wlnd+nV5nPOiB5/GVhLFC+ tV1xTZKgoUEMtjW8WXd3jvt2tIpJjnqvSWzl8FoLWDMASqiIL1Qn8X6KSFJkKuZm+rPp 57v3zcSmZkj3hhlEjZ5VIKhsfr3NvRaRI9zaHnTGz7JyzOW1mflzA9BlEjhPgsWNw+VM B+YPeho5tXNNHTHuojTuuWJjD7+HnRnVxPYIG0TUj5HM2I8gq7NZggzsjpeImbL7o7bZ duZBI6k2984/uBtNIbBLi2zDOUaRc8snUBXMwXPlsz6viGxnfNf4TKqEuagtiengmzln upFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779104669; x=1779709469; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=crnJptzUEns7NytfTpu/gd6vjFfjq64UULyy/cb5MAc=; b=plAcl+Khj3S1mPAZuty9EZDHklmKl/A6a6sOXfv37cmgkchSFF+OqScVutkLgXmc32 zLMjSEVw0MTnGhqECCzm9pkU3AxcwQBxZXoTgGDzp7iPm7k5a9j8j2uOm7V4a1kiuTdu dZEaJduBjX0hJDRWAeZ1zoFvOWRY9GPxC7C8fDxD8dbno3EJhVGfyK4D8UTHQ+o1fl46 /TJmEdY/9Dwta7EMYtNQMnpK6xIPFp5WuxKnv4Rrsj988WYtyspRNzsi4CPQpKsKhTBs C4TQwncyP523iT9MbMfsKNHK/fl7pw/zHbCXSJJbFD59bAzizVgx/4NsOk/oAnzvZywS /fEg== X-Forwarded-Encrypted: i=1; AFNElJ9AdPKb3b1nNOvkSyNc9OOJe6GgOk20nivPRyXA70BHW5QkysXcQAPRr8TLpw1cb6Aix1tpX4hIqSSc+wo=@vger.kernel.org X-Gm-Message-State: AOJu0YxVjaClSg4Pwb6GfdBK/SI007gxarw/ToLzl8OjQLrzyVPdQohY iiLzTc12wabsgV+YzyCsBl0xHajuu2AI9iLT1ls+9VWE2K/xDWwV/pdJs237b9hNmZJd4Kzz3CJ DyG5jpe84XiKnR1Ofv0/AxmRf3AaWkjVdjwxP/VME3R73ppJGyaU3SrVq59JVNr6gnAgmyYAn3G 4= X-Gm-Gg: Acq92OEpdndEqvo8Tw+knJKqOWPQn2vFfzyBrqJT5gpc5aBnniQSZEe4fPexcLBrrpR Vl4CSOH9bDpI+S+ruDJPTOIlqglpa/dYDLxX9hxIjAiBlXmSkrgksWN4NVwmG7GFnfrvWKsA6GJ y1OLyv8uuDy9iD8ngL3XfVaavl/cI3ONnGDJG8zfhBblWYCXzrUqCPEAm7yIAYwaEYbuIV9dedp nIIlU2k897YdIftlo7Fj5FtSP8xKhsbaT7v0jEKtWQVJEeh87VHGOTbOjpJAq2ZyE2PymcX3Zqo nLBXEHwWq61BKecugzY+WLNxOJS6zu6/s4a3BS3X/fstNTE17v8RvTKiQSRpW/nJeIOILU85IFO QlGLPZtM/y0yNUJwvOHZcUlWgvKUoS7QKhjj/Svu5E2WdbblA/TPwteH83nsCEKENcKMDUb+Nk6 Hhks0= X-Received: by 2002:ac8:7dc4:0:b0:510:144a:636 with SMTP id d75a77b69052e-5165a22eb4emr136431031cf.8.1779104669374; Mon, 18 May 2026 04:44:29 -0700 (PDT) X-Received: by 2002:ac8:7dc4:0:b0:510:144a:636 with SMTP id d75a77b69052e-5165a22eb4emr136430741cf.8.1779104668920; Mon, 18 May 2026 04:44:28 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bd4f4e21235sm549218366b.43.2026.05.18.04.44.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 04:44:28 -0700 (PDT) Message-ID: Date: Mon, 18 May 2026 13:44:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/3] arm64: dts: qcom: Add Vicharak Axon Mini To: Ajit Singh , Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260518110435.16262-1-blfizzyy@gmail.com> <20260518110435.16262-4-blfizzyy@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260518110435.16262-4-blfizzyy@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDExMyBTYWx0ZWRfX+OOLKyxdG6kc 8FawV6NTDwGCio2vkQWmvpuJ9nBdjXCdOLFkw7KaRVyOva4uOu9h6Vu6xjZFJrmZiAu/NoIWIIg 3/6ZExlRsmNhmlx8+TPjQptMM8lm3fBB3QH3Hp3YIk4+MnNpLp4ZagJGcZ8cKStvK8Z4bsEsK2+ A8s+RmarDy57Od8MlfSYjos//w9hBXG3Cg6Pa38ot3LfccYX/lCqpG6EWZ/qzWh06PwaiIpWed1 u2iokjF7zckr0BhzJE4e1cbqay8HC0JIIu+DN8/uLOphYt/KzKyyW1Ox14O6gmR60U9Dm6hR+E/ HkRT5omESk/w1SJUyZAFeYZi0CLA0TBFzclkN3uJEqBSJbG6MXJ6l8hAwHtU99mHv2DFR7xswdK ONvYvmHGTmKpYF9QyblbTA66DILXZHXvYmgkNCxv1XZaoz/VTQIJHtREVupvo98tXw9Odmkm3v5 KyewhAxCbc3hOqGJizQ== X-Proofpoint-GUID: eBcvTr5hnF5a3W0emJb9-lJbHfgNXYPO X-Proofpoint-ORIG-GUID: eBcvTr5hnF5a3W0emJb9-lJbHfgNXYPO X-Authority-Analysis: v=2.4 cv=Lf0MLDfi c=1 sm=1 tr=0 ts=6a0afb9e cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=pGLkceISAAAA:8 a=8Y9wC8B1MoRLc4_sRv8A:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_03,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 adultscore=0 clxscore=1015 impostorscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180113 On 5/18/26 1:04 PM, Ajit Singh wrote: > Add DTS for the Vicharak Axon Mini board based on the Qualcomm > QCS6490 SoC. > > This adds debug UART, eMMC, UFS, SDIO WLAN, USB 2.0 host, PCIe, > support along with regulators. > > Signed-off-by: Ajit Singh > --- Hello, this looks good overall, I have a couple comments below [...] > + vcc_3v3: regulator-vcc-3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "vcc_3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + vin-supply = <&vcc_5v0>; > + > + gpio = <&tlmm 113 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&vcc_3v3_en>; nit: Please put property-n property-names in this order, consistently [...] > +&usb_2 { > + dr_mode = "host"; > + status = "okay"; Let's also keep a \n before the 'status' property, file-wide > +}; > + > +&eud { > + status = "disabled"; > +}; It's already disabled in kodiak.dtsi, you can drop this override > + > +&usb_2_hsphy { Please sort the top-level &label references alphabetically [...] > +&ice { > + status = "disabled"; It should be working fine, any reason? [...] > +&ufs_mem_hc { > + reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>; > + vcc-supply = <&vreg_l7b_2p96>; > + vcc-max-microamp = <800000>; > + vccq-supply = <&vreg_l9b_1p2>; > + vccq-max-microamp = <900000>; > + vccq2-supply = <&vreg_l9b_1p2>; > + vccq2-max-microamp = <900000>; > + > + status = "okay"; > + > + /delete-property/ qcom,ice; similarly here [...] > +&pcie0 { > + perst-gpios = <&tlmm 87 GPIO_ACTIVE_LOW>; > + wake-gpios = <&tlmm 89 GPIO_ACTIVE_HIGH>; > + > + pinctrl-0 = <&pcie0_clkreq_n>, <&pcie0_reset_n>, <&pcie0_wake_n>; > + pinctrl-names = "default"; > + > + status = "okay"; Is there anything interesting connected to these buses? Konrad