From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B83C2CDB474 for ; Tue, 17 Oct 2023 15:42:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344102AbjJQPmE (ORCPT ); Tue, 17 Oct 2023 11:42:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344429AbjJQPl6 (ORCPT ); Tue, 17 Oct 2023 11:41:58 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 597E9B6 for ; Tue, 17 Oct 2023 08:41:56 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-405361bb9f7so57342895e9.2 for ; Tue, 17 Oct 2023 08:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697557315; x=1698162115; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fhb/VbAKqWW2bljNb3g4iYW+C+1SCZk6etl2bAcOYLg=; b=ndGJ0F+DYASH3lA6ZKOvJYiP4KYDBFMW8JyLPkmpwxPPg9lrGLWpJH5WQ/VE82eoiC XyjJ9lyyS6QWOvORIcyWlczwFugb2H9nKNcN0jTxdDfnJJEEyVSHcUZSy+absxhtToH4 NyMJjTmGCoJZ9WtIupircSl1mOxEgFn2xVDfoPy7tunE3/p8UBM3nD9D08wB07a//bWk Gy3VzjYEg1ekfQ+agevrBHc1uEG4EanU2nOoGLL454oi2C/WjxpN3T0JGYGyQuH/plef FZMVdpdC5FAzCDrwKvffNvkqphKm3Hw0L+BFM/1x/3h0wWJPK0OWh84nuautTVIpyrLY +jUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697557315; x=1698162115; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fhb/VbAKqWW2bljNb3g4iYW+C+1SCZk6etl2bAcOYLg=; b=kLZPc+gshIyX07ubXnyg4b38YFwERzKKRp8Xh+ikOA5b8Ut6r0pQacbycSDP7EsLUi 4ky/DObOdFwvtuTUewhtVMxZX4iYEVMgHVEiWlnxWSEHmEm26wOBbRrPz1OfsR6F0fAl 2AqwGjgJ0VB4ruFPxqKE2WEHsrjUeFDNwhRSpfB05rt4+jJpKSECmdY35HnO6v89OKuI 3yMvCJPYXkb4IF0h8HWUyB/b+L6vFLmk1TGW9iGzIA3fp0xAHVgvnRSSc/RZlWloAqjP wuhJc4cfMKt1xi8RvncY9W5VLR7GiKU6n+wMHKwN9qDBiaQlVll5j9vtlwAAwPFwYAeh j1sA== X-Gm-Message-State: AOJu0Yy7vOjC+ucjzesVLwPwrCjYFIoNjvLNYDhPKLpGo90wHPR0nwYQ gp0dYMN/0VOpXUjh3hm+o0o8cQ== X-Google-Smtp-Source: AGHT+IEBdPfJkKsMwqOR6v2jaw8Ctfjv771N7HSdvQQL35i0TEr+3Xf1Wr87PCO+t6DIWat/o2wyKA== X-Received: by 2002:adf:fac9:0:b0:32d:8401:404a with SMTP id a9-20020adffac9000000b0032d8401404amr2001007wrs.10.1697557314693; Tue, 17 Oct 2023 08:41:54 -0700 (PDT) Received: from [172.30.204.57] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id e11-20020adffd0b000000b0032dbf26e7aesm38382wrr.65.2023.10.17.08.41.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Oct 2023 08:41:54 -0700 (PDT) Message-ID: Date: Tue, 17 Oct 2023 17:41:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/7] drm/msm/adreno: Add ZAP firmware name to A635 To: Rob Clark , Akhil P Oommen Cc: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , cros-qcom-dts-watchers@chromium.org, Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephen Boyd , Marijn Suijten , Luca Weiss , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20230926-topic-a643-v1-0-7af6937ac0a3@linaro.org> <20230926-topic-a643-v1-2-7af6937ac0a3@linaro.org> <43q6mui3lofa4rqh667o54b2qcbqn5fg34ss5o7y7k7uxbxsro@dxgovofsrvqx> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/17/23 09:33, Rob Clark wrote: > On Mon, Oct 16, 2023 at 1:12 PM Akhil P Oommen wrote: >> >> On Tue, Sep 26, 2023 at 08:24:37PM +0200, Konrad Dybcio wrote: >>> >>> Some (many?) devices with A635 expect a ZAP shader to be loaded. >>> >>> Set the file name to allow for that. >>> >>> Signed-off-by: Konrad Dybcio >>> --- >>> drivers/gpu/drm/msm/adreno/adreno_device.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c >>> index fa527935ffd4..16527fe8584d 100644 >>> --- a/drivers/gpu/drm/msm/adreno/adreno_device.c >>> +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c >>> @@ -454,6 +454,7 @@ static const struct adreno_info gpulist[] = { >>> .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT | >>> ADRENO_QUIRK_HAS_HW_APRIV, >>> .init = a6xx_gpu_init, >>> + .zapfw = "a660_zap.mbn", >> >> sc7280 doesn't have a TZ and so no zap shader support. Can we handle >> this using "firmware-name" property in your top level platform dt? Zap >> firmwares are signed with different keys for each OEMs. So there is >> cross-compatibility anyway. > > I think this ends up working out because the version of sc7280 that > doesn't have TZ also doesn't have the associated mem-region/etc.. Yes > but > maybe we should deprecate the zapfw field as in practice it isn't > useful (ie. always overriden by firmware-name). Also yes, we've discussed that on IRC once > > Fwiw there are windows laptops with sc7180/sc7280 which do use zap fw. Correct, e.g. the SC7180 Acer Aspire 1 that is supported upstream. Konrad Konrad