From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A18BDCA9EA0 for ; Sat, 26 Oct 2019 01:38:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7735E21872 for ; Sat, 26 Oct 2019 01:38:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726168AbfJZBiH (ORCPT ); Fri, 25 Oct 2019 21:38:07 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:5189 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725899AbfJZBiH (ORCPT ); Fri, 25 Oct 2019 21:38:07 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 2FF9ED41810365E8BC66; Sat, 26 Oct 2019 09:38:03 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 26 Oct 2019 09:37:58 +0800 Subject: Re: [PATCH 2/2] f2fs: Add f2fs stats to sysfs To: Jaegeuk Kim CC: Hridya Valsaraju , , LKML , Android Kernel Team References: <20191023214821.107615-1-hridya@google.com> <20191023214821.107615-2-hridya@google.com> <96f89e7c-d91e-e263-99f7-16998cc443a7@huawei.com> <20191025182229.GB24183@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: Date: Sat, 26 Oct 2019 09:37:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191025182229.GB24183@jaegeuk-macbookpro.roam.corp.google.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/10/26 2:22, Jaegeuk Kim wrote: > On 10/25, Chao Yu wrote: >> On 2019/10/25 11:51, Hridya Valsaraju wrote: >>> On Thu, Oct 24, 2019 at 2:26 AM Chao Yu wrote: >>>> >>>> On 2019/10/24 5:48, Hridya Valsaraju wrote: >>>>> Currently f2fs stats are only available from /d/f2fs/status. This patch >>>>> adds some of the f2fs stats to sysfs so that they are accessible even >>>>> when debugfs is not mounted. >>>> >>>> Why don't we mount debugfs first? >>> >>> Thank you for taking a look at the patch Chao. We will not be mounting >>> debugfs for security reasons. >> >> Hi, Hridya, >> >> May I ask is there any use case for those new entries? >> >> So many sysfs entries exist, if there is real use case, how about backuping >> entire /d/f2fs/status entry into /proc/fs/f2fs// directory rather than >> adding some of stats as a single entry in sysfs directory? > > These will be useful to keep a track on f2fs health status by one value > per entry, which doesn't require user-land parsing stuff. Of course, Android > can exploit them by IdleMaint, rollback feature, and so on. Alright, I suggest to add a sub-directory for those statistic entries, we can manage them more easily isolated from those existed switch entries. Thanks, > >> >> Thanks, >> >>> >>> Regards, >>> Hridya >>> >>>> >>>> Thanks, >>> . >>> > . >