From: Krishna Kurapati <quic_kriskura@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: <linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
<linux-arm-msm@vger.kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
Bjorn Andersson <quic_bjorande@quicinc.com>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Saravana Kannan <saravanak@google.com>,
Felipe Balbi <balbi@kernel.org>
Subject: Re: [PATCH v2 4/7] usb: dwc3: core: Expose core driver as library
Date: Mon, 19 Aug 2024 23:18:15 +0530 [thread overview]
Message-ID: <eb0d4f62-5dde-4a63-8515-23081ec9962c@quicinc.com> (raw)
In-Reply-To: <20240811-dwc3-refactor-v2-4-91f370d61ad2@quicinc.com>
On 8/12/2024 8:42 AM, Bjorn Andersson wrote:
> From: Bjorn Andersson <quic_bjorande@quicinc.com>
>
> The DWC3 IP block is handled by three distinct device drivers: XHCI,
> DWC3 core and a platform specific (optional) DWC3 glue driver.
>
> This has resulted in, at least in the case of the Qualcomm glue, the
> presence of a number of layering violations, where the glue code either
> can't handle, or has to work around, the fact that core might not probe
> deterministically.
>
> An example of this is that the suspend path should operate slightly
> different depending on the device operating in host or peripheral mode,
> and the only way to determine the operating state is to peek into the
> core's drvdata.
>
> The Qualcomm glue driver is expected to make updates in the qscratch
> register region (the "glue" region) during role switch events, but with
> the glue and core split using the driver model, there is no reasonable
> way to introduce listeners for mode changes.
>
> Split the dwc3 core platform_driver callbacks and their implementation
> and export the implementation, to make it possible to deterministically
> instantiate the dwc3 core as part of the dwc3 glue drivers and to
> allow flattening of the DeviceTree representation.
>
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
...
> -static int dwc3_probe(struct platform_device *pdev)
> +struct dwc3 *dwc3_probe(struct platform_device *pdev, struct resource *res,
> + bool ignore_clocks_and_resets, void *glue)
> {
> struct device *dev = &pdev->dev;
> - struct resource *res, dwc_res;
> + struct resource dwc_res;
> unsigned int hw_mode;
> void __iomem *regs;
> struct dwc3 *dwc;
> @@ -2087,15 +2089,10 @@ static int dwc3_probe(struct platform_device *pdev)
>
> dwc = devm_kzalloc(dev, sizeof(*dwc), GFP_KERNEL);
> if (!dwc)
> - return -ENOMEM;
> + return ERR_PTR(-ENOMEM);
>
> dwc->dev = dev;
> -
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(dev, "missing memory resource\n");
> - return -ENODEV;
> - }
...
> +static int dwc3_plat_probe(struct platform_device *pdev)
> {
> - struct dwc3 *dwc = platform_get_drvdata(pdev);
> + struct resource *res;
> + struct dwc3 *dwc;
> +
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res) {
> + dev_err(&pdev->dev, "missing memory resource\n");
> + return -ENODEV;
> + }
>
> - pm_runtime_get_sync(&pdev->dev);
> + dwc = dwc3_probe(pdev, res, false, NULL);
> + if (IS_ERR(dwc))
> + return PTR_ERR(dwc);
> +
> + platform_set_drvdata(pdev, dwc);
This setting of platform drvdata is redundant I believe. We already do
it in dwc3_probe.
> +
> + return 0;
> +}
> +
next prev parent reply other threads:[~2024-08-19 17:48 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 3:11 [PATCH v2 0/7] usb: dwc3: qcom: Flatten dwc3 structure Bjorn Andersson
2024-08-12 3:11 ` [PATCH v2 1/7] dt-bindings: usb: snps,dwc3: Split core description Bjorn Andersson
2024-08-18 14:33 ` Rob Herring
2024-08-12 3:11 ` [PATCH v2 2/7] dt-bindings: usb: Introduce qcom,snps-dwc3 Bjorn Andersson
2024-08-12 4:32 ` Rob Herring (Arm)
2024-08-12 3:12 ` [PATCH v2 3/7] of: dynamic: Don't discard children upon node attach Bjorn Andersson
2024-08-12 20:24 ` Rob Herring
2024-08-12 21:21 ` Bjorn Andersson
2024-08-12 3:12 ` [PATCH v2 4/7] usb: dwc3: core: Expose core driver as library Bjorn Andersson
2024-08-12 12:21 ` kernel test robot
2024-08-12 19:00 ` Bjorn Andersson
2024-08-12 12:21 ` kernel test robot
2024-08-13 18:15 ` Frank Li
2024-08-14 1:01 ` Thinh Nguyen
2024-08-19 21:35 ` Bjorn Andersson
2024-08-14 0:56 ` Thinh Nguyen
2024-08-19 21:14 ` Bjorn Andersson
2024-08-19 17:48 ` Krishna Kurapati [this message]
2024-08-19 21:36 ` Bjorn Andersson
2024-09-12 22:21 ` Masahiro Yamada
2024-09-13 2:34 ` Bjorn Andersson
2024-08-12 3:12 ` [PATCH v2 5/7] usb: dwc3: qcom: Don't reply on drvdata during probe Bjorn Andersson
2024-08-13 18:18 ` Frank Li
2024-08-19 21:17 ` Bjorn Andersson
2024-09-12 22:21 ` Masahiro Yamada
2024-08-12 3:12 ` [PATCH v2 6/7] usb: dwc3: qcom: Transition to flattened model Bjorn Andersson
2024-08-12 13:33 ` kernel test robot
2024-08-12 21:21 ` Rob Herring
2024-08-12 22:16 ` Bjorn Andersson
2024-08-13 15:06 ` Rob Herring
2024-08-13 18:33 ` Frank Li
2024-08-19 21:28 ` Bjorn Andersson
2024-08-12 3:12 ` [PATCH v2 7/7] arm64: dts: qcom: sc8280x: Flatten the USB nodes Bjorn Andersson
2024-08-13 18:07 ` [PATCH v2 0/7] usb: dwc3: qcom: Flatten dwc3 structure Frank Li
2024-10-08 20:09 ` Frank Li
2024-10-09 2:54 ` Bjorn Andersson
2025-01-10 16:55 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb0d4f62-5dde-4a63-8515-23081ec9962c@quicinc.com \
--to=quic_kriskura@quicinc.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andersson@kernel.org \
--cc=balbi@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_bjorande@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®