From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6196D228CB8 for ; Tue, 30 Dec 2025 13:53:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767102812; cv=none; b=Y4y+FZTIUeV1DId8SX3ePEqb4FqIzAq+iijP+IdZuVSkvomWg1U1CV8i/OiGrVjJYW2YMjAR6X0wHCcqUE7kCdw8bgE+Ole5WDPkQdR3knVlNDNlcprYRx7jdA2ZUgC/xr40psR2YLgBUAbUvybAz/vsWFD3rJEM4er981+VYbw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767102812; c=relaxed/simple; bh=xPfS9uEzLSD/mtv5oATPYDlSphRp/Rq9VCGtX5HIytA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=clnqwf3cJN+CuOfk8LpHpaeGjcB7Ztrip9prPO/qRh1xnDGwwsLe3pLYsyBZcYDdEYmq4S4FGOY8Wj5H9cVWNpZiAwOISgI9gycDeih9nQPdm458nOtiz1HDdFQWDVh5VAvcElRhBj/4vxADXfr1KHUJZuo2ctaOjOg8G3KwKas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Eh05CogE; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Eh05CogE" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-42fbc3056afso5387973f8f.2 for ; Tue, 30 Dec 2025 05:53:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767102809; x=1767707609; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Fo8YsSR2acA7AZXD620JQ39rcIw2BpkEhIXbexp4DAo=; b=Eh05CogEa0qByXsI5/AeNIUzBk0WGkd0UYQj0teI30lDkEDo+JI4ZJ7vjehgF+1Jcr N983usxicppPH6fC0QZ2tM3ilLqsh+WF3LoZHtPyMn8T5roQqSjkf00LAq222Ga4iunE 1umSFE1nocs7wLQVv3TMFh4Iyn7rdPFtgkCNrDBzHu1JBtRQ7XNR0DFA70wzBtpo6aHi pMY6T3AoWTvH18GIOskL4M9lv8Xu7yT/IjyO6+N/ZPAxjvtf2MEGo+7rpAEBxw/+x5Rz uimstFrZzWKK1AjhHoqr+ag+A+mqS6JaVMIYheX4CwDJw9IxBbxGIdI0gD4k6mRQjyhF xiuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767102809; x=1767707609; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Fo8YsSR2acA7AZXD620JQ39rcIw2BpkEhIXbexp4DAo=; b=ntDRCV5FPdzDC+nUV1hlaI/0pDGCsIK/DdYo8BQEkskl9T+WYQqN0bXT+ztpJhfkVn 3Tg7XR/o5lpBnDXpPa25hpxDbIRK7/75X/tXJ0LIaWXMXkygAmGytTIck+MOzn4rGCCK +nPx06E5naCyT9hTYAHhjg9rHb1Hp4+7gRWSTpNPo5ojGEOk1+4OlBR6Nb8ETMsVUE31 nYjT7fYIuN9JLscFp7BbH5fxOmkIUOXdZVcUnY40yIJqpxH5Es3sQvK5WPZYGeKxH+ZB HsjGMvLoUHYFOCFP5Ve1fCgLqTVD9rfj+w04Bz8rMoAzNXyF2MM2bsni9JzWFZ5nJ12V fNsw== X-Forwarded-Encrypted: i=1; AJvYcCVlRnkydrlkE71PjrhaDcq3PJSPG0AFPIfegvM45SN8ScjzD+XX/k31ddllawFXhaQ/Nl8orkRbpXP5gwA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxc4I5lBPwJtqJlMqU7o0Pdokn594HBAlZQRH3vQ/5sk6QNnRHd Tr6OIRdhIi0p0T83+9OLUAMyFW2ey0/iw0rwJTYziHzBTLbIbcEuW85k X-Gm-Gg: AY/fxX6aEWNcJCD+CDi5bGIgf/SwKi7w16NUKn0uNLlrBv9Q//VwqEMSyUiN31szfXU lIFSAD1dpxLx1Z5c/qQh+DlcZqQEA/jFjHnqjDcAzbiuSG29h9yyBcaUYQ3z+xZM7e5XklQRmlG mD0+nLuc7fujoowKMOwChfoWjhGvYX4h8A1v/EDTl4OqsFH4joFEPONguxbtmGPsymZY/zdunNR 5B8ObLD/04QvUIQ7NgwVo9aBP4wh1KPN512aCthZDFgFO4nFGOAIffUoMGj6x5YUR0QTxx7YUqk YDLC77BOpk5hfZXqlKhxi6pzcxb4ktB6nPZd+uSjrDeoaGQIXcDvKkZHNFBGzG3gxDO4OF6ALOU IyFfN2QySM2+O5ebFJtF2oxW4K+s9dXi47pTTsutpzfTAr0Lkc1bJnbvtTG1JDzg+kuV5J864j3 JS1Knd817HRmhOsY8Ff70p7xSS8uJwJij14w== X-Google-Smtp-Source: AGHT+IGYnNj/cKfvnasLAKMOMw+DEPW5XlDq88uCuUDLyNooiQAmHbfudOuBJIYoJ2ohxqq8V3LcAw== X-Received: by 2002:a5d:4705:0:b0:432:5c34:fb32 with SMTP id ffacd0b85a97d-4325c34ff28mr32698515f8f.23.1767102808510; Tue, 30 Dec 2025 05:53:28 -0800 (PST) Received: from [192.168.1.121] ([176.206.93.222]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa4749sm69344229f8f.37.2025.12.30.05.53.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Dec 2025 05:53:28 -0800 (PST) Message-ID: Date: Tue, 30 Dec 2025 14:53:26 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] platform/x86: asus-wmi: explicitly mark more code with CONFIG_ASUS_WMI_DEPRECATED_ATTRS To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Cc: Denis Benato , LKML , platform-driver-x86@vger.kernel.org, Hans de Goede , "Luke D . Jones" , Mateusz Schyboll References: <20251225143007.2684239-1-denis.benato@linux.dev> <20251225143007.2684239-2-denis.benato@linux.dev> <54cc6828-9191-403c-18d5-76f768d70381@linux.intel.com> <1579d5ed-8233-44a5-8e0d-5462fd8b41d4@gmail.com> <9f5085e9-454f-f003-27cd-0eb86dfd9e11@linux.intel.com> Content-Language: en-US, it-IT, en-US-large From: Denis Benato In-Reply-To: <9f5085e9-454f-f003-27cd-0eb86dfd9e11@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/30/25 14:41, Ilpo Järvinen wrote: > On Tue, 30 Dec 2025, Denis Benato wrote: >> On 12/29/25 11:06, Ilpo Järvinen wrote: >>> On Thu, 25 Dec 2025, Denis Benato wrote: >>> >>>> Be more explicit in code that will be excluded when compiling >>>> with CONFIG_ASUS_WMI_DEPRECATED_ATTRS disabled. >>> Does this result in build fails or warnings? If that's the case, it should >>> be mentioned in the changelog + Fixes tag added. >> Hi, >> >> Sadly no, despite a property in a struct instantiated only once >> being forcefully set to false no warning is emitted by neither >> clang nor gcc :( > Ah, I was mainly expecting unused function warning but apparently since it > was still being "used" it obviously won't trigger that warning. > Plus if gcc/clang could have catched it build bots would have done so when posting the asus-armoury series as they catched other things.