From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: linmiaohe@huawei.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: X86: correct meaningless kvm_apicv_activated() check
Date: Mon, 16 Mar 2020 17:39:36 +0100 [thread overview]
Message-ID: <eb1037c8-fdb5-4f4c-4641-915c0e3d01bc@redhat.com> (raw)
In-Reply-To: <20200316155911.GE24267@linux.intel.com>
On 16/03/20 16:59, Sean Christopherson wrote:
>>>
>> if (!!old == !!new)
>> return;
>>
>> to make it clear we're converting them to 1/0 :-)
>
> All I can think of now is the Onion article regarding razor blades...
>
> if (!!!!old == !!!!new)
> return;
>
That would be !!!!!, but seriously I'll go with two.
(Thanks for giving me a chuckle, it's sorely needed these days).
Paolo
next prev parent reply other threads:[~2020-03-16 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 11:31 Paolo Bonzini
2020-03-16 8:33 ` Vitaly Kuznetsov
2020-03-16 15:26 ` Sean Christopherson
2020-03-16 15:44 ` Vitaly Kuznetsov
2020-03-16 15:59 ` Sean Christopherson
2020-03-16 16:39 ` Paolo Bonzini [this message]
2020-03-17 11:24 ` Xiaoyao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb1037c8-fdb5-4f4c-4641-915c0e3d01bc@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®