From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 821C6C04AB1 for ; Sat, 11 May 2019 15:35:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B7562183F for ; Sat, 11 May 2019 15:35:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728669AbfEKPf5 (ORCPT ); Sat, 11 May 2019 11:35:57 -0400 Received: from smtprelay0199.hostedemail.com ([216.40.44.199]:47964 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728604AbfEKPf4 (ORCPT ); Sat, 11 May 2019 11:35:56 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 694EE837F27D; Sat, 11 May 2019 15:35:55 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: ant46_8ada80935915e X-Filterd-Recvd-Size: 2045 Received: from XPS-9350 (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf04.hostedemail.com (Postfix) with ESMTPA; Sat, 11 May 2019 15:35:54 +0000 (UTC) Message-ID: Subject: Re: [PATCH] afs: remove redundant assignment to variable ret From: Joe Perches To: Colin King , David Howells , linux-afs@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 11 May 2019 08:35:52 -0700 In-Reply-To: <20190511123603.3265-1-colin.king@canonical.com> References: <20190511123603.3265-1-colin.king@canonical.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2019-05-11 at 13:36 +0100, Colin King wrote: > The variable ret is being assigned a value however this is never > read and later it is being reassigned to a new value. The assignment > is redundant and hence can be removed. [] > diff --git a/fs/afs/xattr.c b/fs/afs/xattr.c [] > @@ -71,7 +71,6 @@ static int afs_xattr_get_acl(const struct xattr_handler *handler, > if (ret == 0) { > ret = acl->size; > if (size > 0) { > - ret = -ERANGE; > if (acl->size > size) > return -ERANGE; > memcpy(buffer, acl->data, acl->size); It looks like the ret = acl->size immediately after the memcpy should be removed as well. --- fs/afs/xattr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/afs/xattr.c b/fs/afs/xattr.c index c81f85003fc7..e21de2f166a4 100644 --- a/fs/afs/xattr.c +++ b/fs/afs/xattr.c @@ -71,11 +71,9 @@ static int afs_xattr_get_acl(const struct xattr_handler *handler, if (ret == 0) { ret = acl->size; if (size > 0) { - ret = -ERANGE; if (acl->size > size) return -ERANGE; memcpy(buffer, acl->data, acl->size); - ret = acl->size; } kfree(acl); }