From: Li Ming <ming.li@zohomail.com>
To: Richard Cheng <icheng@nvidia.com>
Cc: dave@stgolabs.net, jic23@kernel.org, dave.jiang@intel.com,
alison.schofield@intel.com, vishal.l.verma@intel.com,
djbw@kernel.org, iweiny@kernel.org, linux-cxl@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] cxl/mbox: Return success for CXL_MBOX_CMD_RC_BACKGROUND
Date: Tue, 20 Oct 2026 20:50:50 +0800 [thread overview]
Message-ID: <eb20c279-d582-48cd-b461-59979b529c42@zohomail.com> (raw)
In-Reply-To: <atc3PJRk3M_RBmMG@MWDK4CY14F>
On 10/20/2026 5:42 PM, Richard Cheng wrote:
> On Tue, Oct 20, 2026 at 05:03:52PM +0800, Li Ming wrote:
>> In CXL subsystem, each mbox command hw return code is mapped to a
>> corresponding errno value. Currently, CXL_MBOX_CMD_RC_BACKGROUND is
>> mapped to -ENXIO.
>>
>> However, a BACKGROUND hw return code indicates that the command has been
>> accepted by the device and continues execution asynchronously. It does
>> not indicate a command failure.
>>
> Hi Li,
Hi Richard,
>
> Can we have the spec section written here ?
Sure.
> Btw I wonder how you trigger the error ?
We cannot trigger this error, currently, driver does not check/use BACKGROUND's error. it is found by review, please see [1].
[1]: https://lore.kernel.org/linux-cxl/cover.1791949910.git.alison.schofield@intel.com/T/#mc7764b9f3f470adf62292000299e8288d2241c3d
Ming
>
> Best regards,
> Richard Cheng.
>
>> Return 0 instead of -ENXIO for CXL_MBOX_CMD_RC_BACKGROUND so that
>> callers do not treat a successfully started background operation as an
>> error.
>>
>> Fixes: 92fcc1abab09 ("cxl/mbox: Improve handling of mbox_cmd hw return codes")
>> Signed-off-by: Li Ming <ming.li@zohomail.com>
>> ---
>> drivers/cxl/cxlmem.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h
>> index c401e3a1af06..cc71d7a84cdc 100644
>> --- a/drivers/cxl/cxlmem.h
>> +++ b/drivers/cxl/cxlmem.h
>> @@ -160,7 +160,7 @@ static inline struct cxl_ep *cxl_ep_load(struct cxl_port *port,
>> */
>> #define CMD_CMD_RC_TABLE \
>> C(SUCCESS, 0, NULL), \
>> - C(BACKGROUND, -ENXIO, "background cmd started successfully"), \
>> + C(BACKGROUND, 0, "background cmd started successfully"), \
>> C(INPUT, -ENXIO, "cmd input was invalid"), \
>> C(UNSUPPORTED, -ENXIO, "cmd is not supported"), \
>> C(INTERNAL, -ENXIO, "internal device error"), \
>> --
>> 2.43.0
>>
prev parent reply other threads:[~2026-10-20 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 9:03 Li Ming
2026-10-20 9:42 ` Richard Cheng
2026-10-20 12:50 ` Li Ming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb20c279-d582-48cd-b461-59979b529c42@zohomail.com \
--to=ming.li@zohomail.com \
--cc=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=djbw@kernel.org \
--cc=icheng@nvidia.com \
--cc=iweiny@kernel.org \
--cc=jic23@kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®