From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FFB833E35B for ; Thu, 4 Dec 2025 12:52:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764852731; cv=none; b=I/FvTApNms6W3ubTCcuT7eLZtidypfxhqs86pBCV+iKAgNtrT4hk8eF/TKh/jhiObZE5kU7InxJu7mjZNeCMgCVaRpuAaOFB4i7CoAs0642sju3VqM1BGrq1b1eZWbG5VeAw1Ad+qgamhV7yscFVnwXgj8hpReG/zXs1Su5+lbE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764852731; c=relaxed/simple; bh=OGnRAPHhgasM0mRjlVYUPiBaKyj9vXfcbziV9w7M1Rw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rYe0GYMfatg1zENB5hsEBHEOJo+rPIiW3ZdBYB82/YYgSoxx9UJCCwAewr3hpqjt33f6pBgoscI709J+0z6gvcwk1ROmj0X5D5c6Ljbp3HD9ZVVJY8VdYmLzpip1k5CwuDQ65gehP7IBKMMN5bh5uniQV9qN7BVwk/yB9sEpx4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JspYQzIp; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=WZeyQC51; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JspYQzIp"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="WZeyQC51" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764852729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DWKFtRptmn2CPvnrXCNnyvZybDhYlyGG2xEo5BhJnDk=; b=JspYQzIpdNRxO1cQb7XS2VYBL4jNm5t+gKZRKUBkwq1iyrE9bDPc2N0ITuPwtUd+dM1/Z9 Fu47y5F4EvIozZy4e7V4Tee+2o8lwVnXrfgqlPULoAzNg59c+HWAGyllcXv4Aus6UXcJPs 0THfGvAS3/YwOV+p3atppiwIQCbtX1c= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-279-Ta8mnYgEPxqDbARZIlMGWA-1; Thu, 04 Dec 2025 07:52:05 -0500 X-MC-Unique: Ta8mnYgEPxqDbARZIlMGWA-1 X-Mimecast-MFC-AGG-ID: Ta8mnYgEPxqDbARZIlMGWA_1764852725 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-42b2fb13b79so493586f8f.3 for ; Thu, 04 Dec 2025 04:52:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764852725; x=1765457525; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DWKFtRptmn2CPvnrXCNnyvZybDhYlyGG2xEo5BhJnDk=; b=WZeyQC51xFlJupxMlXxTWvOG0uul79eVAvSLXzUyuf42oRBCohPf/lEyyIdD46kE/v iorX8DROi6NgLnoa3R3aDDh5P1p38Y50eUvuHSZn3/9BNmd80bMhT12XBMh/7vl2CYBH g/B7aJZmoletqGifNi80GF2n2XEexkX2POf7cp4g7iUg0evmshrTJvtu8WP5oJlqy2fv I7a8YQtfCMB3b+Jejs4z6v+Onpx/LJQB5DurZtGlUtkZalQ8cxI2g9OLBaENGXz9dWPF IiK1REM4UT/u1bd6PkxpVb3hz+MJZTrKCkwWLwdwbt9ed6NiDHMXCkhRZbBzKrchwk1Q 0nfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764852725; x=1765457525; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DWKFtRptmn2CPvnrXCNnyvZybDhYlyGG2xEo5BhJnDk=; b=P8GaKpEzD28B3xbnpqNAKC8LhMMjeJ5dEASx9Lrckhcp8zBqtSELHRg6zfDQ8VU9+r NTyMXbxwnb3O+vJdUYqLXDmou1aUQV6aVoKRYSHrI8lQm8pNoEFqPeb9nEYQnHMv9mSk KJAd0bik6t/719rua5X/lUC+8EPH2LIkzF3VsNg+edVQ8mmdyyzhRzisIiiW9SYmb3o2 /gcAILmQKExWjwGbY/uD4h1JwIVqgRHmCMX2/O+wdAsOYO8p8tDSBnP1L6sVVM9vSxHD wnrX/c+SNfCiAUlt2Qh39hb0yeAsitT8CfvHtK/zopdkU8RZmvB/d0pS6bkolMZhanVj 1wLw== X-Forwarded-Encrypted: i=1; AJvYcCVvN/XCI9anhgLh6/kB6t03pJcfE5jvvBsriLZA60/jgl+yV9kv8d//acPy5WLfJmEqSsj8t40rmXqiFkw=@vger.kernel.org X-Gm-Message-State: AOJu0YyKcvQxtxpThqyZp8GBP/svPBDGCY6ZMkBpt2qq1vFdf05oNObn fyWgLF8tWwhLvezyJlsfeUfvBWJXz3gp4iYWfX3bhYdRUB8Zy/9ZvDAocde4xU4iR3GEoHaxSwt fpOIp2sGXx3jUv1mfWUWloCAUSkpb1hCIPmf8ajOiABpa9lIYeMR0oemZiAtgqEIFYw== X-Gm-Gg: ASbGncvvnhGzGFlYexDz/Vz2PoloaTmAeQFhPMLD72AChsnhzrZCJMpJRb6pYWuHrwc ot2v5OCP17UGLfyLRZUe3aLlRjC4ywIR7+N25A+PRlsDTR3CAkocmoxwMUvoTMWGecd/Avfar95 jRIEP7geEolITI3Q9ELmM1FeDWcwoDF2TFmip4aUM1knOoTtozEI+xYL+AWgGDG+fi/wKRsmzjI R5xJzLIrszuPs3pxx7Vv41W3fbHtxJD/XyFGdUzklYbKd/Jdj6n1RmnJPKpJzWNVVdGO63OVqJK 7CtpCu+X3uJRb0LS0fN21fRfcK/iMjghjgIMvX47wA9C35YlWXhgBSeRTPTMFq+VLUSIJwIePNy NE6vVVXU6iySi X-Received: by 2002:a05:6000:2387:b0:42b:3023:66be with SMTP id ffacd0b85a97d-42f731e9ba5mr6129786f8f.32.1764852724731; Thu, 04 Dec 2025 04:52:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IEkMufu4r67XizVQgnp7KjtpXy4lQIc+l2HNrQKXtYq9cAARc+rF033dRP6a6N5PuJ2vMHucw== X-Received: by 2002:a05:6000:2387:b0:42b:3023:66be with SMTP id ffacd0b85a97d-42f731e9ba5mr6129753f8f.32.1764852724308; Thu, 04 Dec 2025 04:52:04 -0800 (PST) Received: from [192.168.88.32] ([212.105.153.24]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7d2231dfsm3075796f8f.26.2025.12.04.04.52.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 04:52:03 -0800 (PST) Message-ID: Date: Thu, 4 Dec 2025 13:52:02 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] ipvlan: Ignore PACKET_LOOPBACK in handle_mode_l2() To: Dmitry Skorodumov , netdev@vger.kernel.org, Jakub Kicinski , Julian Vetter , Guillaume Nault , Eric Dumazet , Mahesh Bandewar , "David S. Miller" , linux-kernel@vger.kernel.org Cc: Andrew Lunn References: <20251202103906.4087675-1-skorodumov.dmitry@huawei.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251202103906.4087675-1-skorodumov.dmitry@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/2/25 11:39 AM, Dmitry Skorodumov wrote: > Packets with pkt_type == PACKET_LOOPBACK are captured by > handle_frame() function, but they don't have L2 header. > We should not process them in handle_mode_l2(). > > This doesn't affect old L2 functionality, since handling > was anyway incorrect. > > Handle them the same way as in br_handle_frame(): > just pass the skb. > > To observe invalid behaviour, just start "ping -b" on bcast address > of port-interface. > > Fixes: 2ad7bf363841 ("ipvlan: Initial check-in of the IPVLAN driver.") > Signed-off-by: Dmitry Skorodumov Since you appear the have momentum on ipvlan devel, please consider adding self-tests for the issue you are addressing. You can later leverage the same infra for functional coverage and that will help your intended development. Thanks, Paolo