mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexey Charkov <alchark@flipper.net>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Sebastian Reichel <sre@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, Shawn Lin <shawn.lin@rock-chips.com>
Subject: Re: [PATCH v2 2/5] dt-bindings: power: reset: syscon-reboot-mode: allow supplies
Date: Wed, 30 Sep 2026 13:50:50 +0200	[thread overview]
Message-ID: <eb2d513b-3c7b-4298-932f-8e7cc8d9c08b@kernel.org> (raw)
In-Reply-To: <20260930-fascinating-cheetah-of-speed-7cccd0@quoll>

On 30/09/2026 13:47, Krzysztof Kozlowski wrote:
> On Tue, Sep 29, 2026 at 02:28:19PM +0400, Alexey Charkov wrote:
>> Whatever program that acts on a reboot mode runs before a full OS, so it
>> may lack the capability to enable the regulators it depends on, and a
>> reset that preserves the mode register generally leaves the regulators as
>> the previously running system left them.
>>
>> Allow a reboot mode node to name such supplies, so that they can be
>> turned on while the mode is being requested.
>>
>> Tested-by: Shawn Lin <shawn.lin@rock-chips.com>
> 
> Again fake tag.
> 
>> Signed-off-by: Alexey Charkov <alchark@flipper.net>
>> ---
>>  .../devicetree/bindings/power/reset/syscon-reboot-mode.yaml       | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml
>> index 79ffc78b23ea..5ed70c87269e 100644
>> --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml
>> +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml
>> @@ -36,6 +36,14 @@ patternProperties:
>>    "^mode-.*$":
>>      maxItems: 1
>>  
>> +  "^[a-z0-9]+(-[a-z0-9]+)*-supply$":
>> +    description:
>> +      Supply that has to be powered for whatever program acts on the mode.
>> +      That could be a boot ROM with no access to regulators, and a warm reset
>> +      leaves them as the previously running system left them and not necessarily
>> +      what their expected out-of-reboot state is. Any supply described here is
>> +      enabled when a mode is requested, and stays enabled.
> 
> This looks like workaround for missing supply handling in actual
> consumers. Fix your devices instead.

Heh, I misread - you need to power this on? Then how does your board
powers itself in the first place? And how do you even solve the
incorrect - e.g. too low - voltage on these regulators?

Best regards,
Krzysztof

  reply	other threads:[~2026-09-30 11:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 10:28 [PATCH v2 0/5] power: reset: syscon-reboot-mode: Add support for Rockchip RK3576 reboot modes Alexey Charkov
2026-09-29 10:28 ` [PATCH v2 1/5] dt-bindings: soc: rockchip: add boot ROM download boot mode Alexey Charkov
2026-09-30 11:45   ` Krzysztof Kozlowski
2026-09-30 13:56     ` Alexey Charkov
2026-09-29 10:28 ` [PATCH v2 2/5] dt-bindings: power: reset: syscon-reboot-mode: allow supplies Alexey Charkov
2026-09-30 11:47   ` Krzysztof Kozlowski
2026-09-30 11:50     ` Krzysztof Kozlowski [this message]
2026-09-30 11:58       ` Alexey Charkov
2026-09-29 10:28 ` [PATCH v2 3/5] power: reset: syscon-reboot-mode: enable supplies for the next stage Alexey Charkov
2026-09-29 10:28 ` [PATCH v2 4/5] arm64: dts: rockchip: add reboot-mode node to RK3576 Alexey Charkov
2026-09-29 10:28 ` [PATCH v2 5/5] arm64: dts: rockchip: name the reboot mode supplies on RK3576 EVB1 Alexey Charkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb2d513b-3c7b-4298-932f-8e7cc8d9c08b@kernel.org \
    --to=krzk@kernel.org \
    --cc=alchark@flipper.net \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®