From: Joe Perches <joe@perches.com>
To: Fabio Aiuto <fabioaiuto83@gmail.com>, gregkh@linuxfoundation.org
Cc: dan.carpenter@oracle.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 23/30] staging: rtl8723bs: fix comparison in if condition in core/rtw_recv.c
Date: Sat, 03 Apr 2021 08:24:12 -0700 [thread overview]
Message-ID: <eb2db42b7e721e6fbeaf8324d33801b5a9bfc03a.camel@perches.com> (raw)
In-Reply-To: <5acf0d9573f2d9cd5d249f928fbfeee010f5f3fc.1617440834.git.fabioaiuto83@gmail.com>
On Sat, 2021-04-03 at 11:13 +0200, Fabio Aiuto wrote:
> fix post-commit checkpatch issue:
>
> CHECK: Using comparison to false is error prone
> 27: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:381:
> + if (psecuritypriv->
> bcheck_grpkey == false &&
>
> Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index cd4324a93275..21949925ec77 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -378,7 +378,7 @@ static signed int recvframe_chkmic(struct adapter *adapter, union recv_frame *p
>
>
> } else {
> /* mic checked ok */
> - if (psecuritypriv->bcheck_grpkey == false &&
> + if (!psecuritypriv->bcheck_grpkey &&
> (IS_MCAST(prxattrib->ra) == true))
> psecuritypriv->bcheck_grpkey = true;
> }
next prev parent reply other threads:[~2021-04-03 15:24 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 9:13 [PATCH v3 00/30] staging: rtl8723bs: remove RT_TRACE logs in core/* Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 01/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 02/30] staging: rtl8723bs: fix condition in if statement " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 03/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_security.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 04/30] staging: rtl8723bs: fix line exceed warning " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 05/30] staging: rtl8723bs: fix spaces around operator issues " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 06/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_eeprom.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 07/30] staging: rtl8723bs: fix error prone if conditions " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 08/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_pwrctrl.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 09/30] staging: rtl8723bs: fix logical continuation issue " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 10/30] staging: rtl8723bs: remove unnecessary parentheses in if-condition " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 11/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_cmd.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 12/30] staging: rtl8723bs: fix null check conditions " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 13/30] staging: rtl8723bs: remove unnecessary parentheses in if condition " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 14/30] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_mlme.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 15/30] staging: rtl8723bs: remove RT_TRACE logs " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 16/30] staging: rtl8723bs: tidy up some error handling " Fabio Aiuto
2021-04-03 9:42 ` Fabio Aiuto
2021-04-03 9:50 ` Fabio Aiuto
2021-04-03 10:04 ` Dan Carpenter
2021-04-03 9:13 ` [PATCH v3 17/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme_ext.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 18/30] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_recv.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 19/30] staging: rtl8723bs: remove RT_TRACE logs " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 20/30] staging: rtl8723bs: added spaces around operator " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 21/30] staging: rtl8723bs: split long line " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 22/30] staging: rtl8723bs: remove unnecessary parentheses " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 23/30] staging: rtl8723bs: fix comparison in if condition " Fabio Aiuto
2021-04-03 15:24 ` Joe Perches [this message]
2021-04-03 9:13 ` [PATCH v3 24/30] staging: rtl8723bs: remove commented RT_TRACE call in core/rtw_ioctl_set.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 25/30] staging: rtl8723bs: remove RT_TRACE logs " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 26/30] staging: rtl8723bs: place constant on the right side of the test " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 27/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 28/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_sta_mgt.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 29/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ieee80211.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 30/30] staging: rtl8723bs: add spaces around operators " Fabio Aiuto
2021-04-03 15:02 ` [PATCH v3 00/30] staging: rtl8723bs: remove RT_TRACE logs in core/* Joe Perches
2021-04-03 15:21 ` Fabio Aiuto
2021-04-03 16:17 ` Joe Perches
2021-04-03 17:28 ` Fabio Aiuto
2021-04-03 20:02 ` Joe Perches
2021-04-04 6:48 ` Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb2db42b7e721e6fbeaf8324d33801b5a9bfc03a.camel@perches.com \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®