From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Breno Leitao" <leitao@debian.org>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, "Dave Young" <dyoung@redhat.com>,
"Gregory Price" <gourry@gourry.net>,
"Usama Arif" <usamaarif642@gmail.com>,
"Jiri Slaby" <jirislaby@kernel.org>
Subject: Re: [PATCH v2 1/5] efi/memattr: Fix thinko in table size sanity check
Date: Wed, 01 Apr 2026 16:31:27 +0200 [thread overview]
Message-ID: <eb368b0d-4acc-4dc6-a86b-7a1a81762960@app.fastmail.com> (raw)
In-Reply-To: <ac0SynMEZTkodole@gmail.com>
On Wed, 1 Apr 2026, at 14:45, Breno Leitao wrote:
> On Wed, Apr 01, 2026 at 02:23:53PM +0200, Ard Biesheuvel wrote:
>> + if (tbl->desc_size < sizeof(efi_memory_desc_t) ||
>> + tbl->desc_size > efi.memmap.desc_size) {
>> + pr_warn("Unexpected EFI Memory Attributes descriptor size %d (expected: %ld)\n",
>> + tbl->desc_size, efi.memmap.desc_size);
>
> Should tbl->desc_size be printed as %u and %lu? tbl->desc_size is u32
> and. The pr_warn a few lines below already uses %u for the same field:
>
Yes, good point - will fix.
next prev parent reply other threads:[~2026-04-01 14:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 12:23 [PATCH v2 0/5] x86/efi: Re-enable memory attributes table for kexec Ard Biesheuvel
2026-04-01 12:23 ` [PATCH v2 1/5] efi/memattr: Fix thinko in table size sanity check Ard Biesheuvel
2026-04-01 12:45 ` Breno Leitao
2026-04-01 14:31 ` Ard Biesheuvel [this message]
2026-04-01 14:35 ` Breno Leitao
2026-04-01 12:23 ` [PATCH v2 2/5] x86/efi: Gather initial memory reservation and table handling logic Ard Biesheuvel
2026-04-01 14:49 ` Breno Leitao
2026-04-01 14:59 ` Ard Biesheuvel
2026-04-01 12:23 ` [PATCH v2 3/5] x86/efi: Defer the call to efi_memattr_init() Ard Biesheuvel
2026-04-01 14:57 ` Breno Leitao
2026-04-01 12:23 ` [PATCH v2 4/5] efi: Use efi_mem_reserve() to reserve the memory attribute table Ard Biesheuvel
2026-04-01 17:39 ` Breno Leitao
2026-04-01 17:47 ` Ard Biesheuvel
2026-04-01 12:23 ` [PATCH v2 5/5] x86/efi: Drop kexec quirk for the EFI memory attributes table Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb368b0d-4acc-4dc6-a86b-7a1a81762960@app.fastmail.com \
--to=ardb@kernel.org \
--cc=dyoung@redhat.com \
--cc=gourry@gourry.net \
--cc=jirislaby@kernel.org \
--cc=leitao@debian.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=usamaarif642@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®