mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: sashiko-reviews@lists.linux.dev
Cc: linux-rt-devel@lists.linux.dev, tj@kernel.org,
	hannes@cmpxchg.org, mkoutny@suse.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 16/16] selftests/sched: Add a test of SCHED_DEADLINE bandwidth accounting
Date: Wed, 18 Nov 2026 16:12:24 -0500	[thread overview]
Message-ID: <eb414b6f-ea8f-4dd5-94ca-0915490ff37b@efficios.com> (raw)
In-Reply-To: <sashiko-outbox-221967@kernel.org>

> Does deboost_new_params_reboost() exercise reboosting after a deboost as
> its comment describes?

It reaches the check it was written for. It failed on v7, before the
split, with the bug that "sched/deadline: Check the runtime of a task
whose parameters change" fixes. I have not checked your
point on the deadline of 0 in the waiter node.

> fair_tid is set in pi_init_lock2() but never read, which triggers a
> -Wunused-but-set-variable warning under -Wall.

These come from splitting the test. They serve the cases that the second
series adds back. The test builds with no warning, as fair_tid is a
global.

> Does pi_chain_donor_leaves() fail because Z is never propagated past M to
> O as O's donor?

No. It passes in every run, in 25 guests with this series. The missed
propagation is what pi_chain_top_moves tests. That case comes with the
two rtmutex fixes, in the second series.

> What happens in move_cancelled() when deadline_bw_test is started from a
> non-root cgroup (such as a systemd session or service cgroup)?

Right. The case assumes the root cgroup, and it turns the cpu controller
off even if it was on before. I will fix both.

> In the same loop, late.done is a plain uint64_t written by late_setter()
> while move_cancelled() polls it in wait_for(5000, late.done), which is a
> data race.

Right. I will make it atomic, and join the thread after the reap.

> Does shm_lock_init() re-initialize shm_lock without destroying it across
> death_pi_waiter, death_pi_owner, and death_pi_deadline_owner?

Yes. I will destroy the mutex and its attributes.

> Can hotplug_server() pass when probe(NULL) fails and returns -1?

Yes. I will check the probes in the three cases.

> Should rebuild_record_taken() return KSFT_SKIP instead of KSFT_FAIL when
> total_bw_of(a) returns -1 because /sys/kernel/debug/sched/debug is not
> available?

Yes.

> Does rebuild_record_taken() fail when CPU 0 is isolated with
> isolcpus=domain,0,1?

Yes. With 7 CPUs and isolcpus=domain,0,1, it fails in 3 runs of 3:
the task wakes on CPU 0. With the second series, it passes in 3 of 3.
The case tests "sched/deadline: Make a rebuild count a task in the root
domain it runs in", of the second series. It belongs there. It passed
in our runs only because the guests with isolated CPUs had too few
CPUs to run it. I will move it to the second series.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com

      reply	other threads:[~2026-11-18 21:12 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 20:06 [PATCH 00/16] sched/deadline: first bandwidth accounting fixes and selftests Mathieu Desnoyers
2026-11-18 20:06 ` [PATCH 01/16] sched: Refuse SCHED_FLAG_KEEP_PARAMS that would change the policy or the class Mathieu Desnoyers
2026-11-18 20:06 ` [PATCH 02/16] sched/deadline: Do not admit bandwidth for parameters that are kept Mathieu Desnoyers
2026-11-18 20:06 ` [PATCH 03/16] sched: Let a task boosted by a deadline waiter change its policy Mathieu Desnoyers
2026-11-18 20:06 ` [PATCH 04/16] sched/deadline: Do not divide by zero active CPUs of a root domain Mathieu Desnoyers
2026-11-18 20:23   ` sashiko-bot
2026-11-18 21:08     ` Mathieu Desnoyers
2026-11-18 20:06 ` [PATCH 05/16] sched/deadline: Refuse dl_server debugfs writes while the rq is offline Mathieu Desnoyers
2026-11-18 20:06 ` [PATCH 06/16] sched: Take cpuset_mutex for a deadline policy change only with pi Mathieu Desnoyers
2026-11-18 20:17   ` sashiko-bot
2026-11-18 21:09     ` Mathieu Desnoyers
2026-11-18 20:06 ` [PATCH 07/16] sched/deadline: Do not lose a throttled task switched out and back Mathieu Desnoyers
2026-11-18 20:31   ` sashiko-bot
2026-11-18 21:09     ` Mathieu Desnoyers
2026-11-18 20:06 ` [PATCH 08/16] sched/deadline: Do not replenish a boost from cleared parameters Mathieu Desnoyers
2026-11-18 20:35   ` sashiko-bot
2026-11-18 21:10     ` Mathieu Desnoyers
2026-11-18 20:06 ` [PATCH 09/16] sched/deadline: Reset the deadline and the runtime with the parameters Mathieu Desnoyers
2026-11-18 20:38   ` sashiko-bot
2026-11-18 21:10     ` Mathieu Desnoyers
2026-11-18 20:06 ` [PATCH 10/16] sched/deadline: Release the bandwidth of a task that leaves the class asleep Mathieu Desnoyers
2026-11-18 20:06 ` [PATCH 11/16] sched/deadline: Reject SCHED_DEADLINE on exited tasks Mathieu Desnoyers
2026-11-18 20:06 ` [PATCH 12/16] sched/deadline: Fix this_bw when a task is changed during a remote wakeup Mathieu Desnoyers
2026-11-18 20:46   ` sashiko-bot
2026-11-18 21:11     ` Mathieu Desnoyers
2026-11-18 20:06 ` [PATCH 13/16] sched/deadline: Check SCHED_DEADLINE affinity under the rq lock Mathieu Desnoyers
2026-11-18 20:06 ` [PATCH 14/16] sched/debug: Show the deadline bandwidth of each runqueue Mathieu Desnoyers
2026-11-18 20:06 ` [PATCH 15/16] selftests/sched: Add a test of SCHED_DEADLINE policy round trips Mathieu Desnoyers
2026-11-18 20:06 ` [PATCH 16/16] selftests/sched: Add a test of SCHED_DEADLINE bandwidth accounting Mathieu Desnoyers
2026-11-18 21:04   ` sashiko-bot
2026-11-18 21:12     ` Mathieu Desnoyers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb414b6f-ea8f-4dd5-94ca-0915490ff37b@efficios.com \
    --to=mathieu.desnoyers@efficios.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=mkoutny@suse.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®