From: Dave Hansen <dave.hansen@intel.com>
To: jannh@google.com, bp@suse.de, riel@surriel.com,
bigeasy@linutronix.de, linux-kernel@vger.kernel.org,
hpa@zytor.com, pbonzini@redhat.com, tglx@linutronix.de,
kvm@vger.kernel.org, luto@amacapital.net,
kurt.kanzenbach@linutronix.de, x86@kernel.org, mingo@kernel.org,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/fpu] x86/fpu: Fault-in user stack if copy_fpstate_to_sigframe() fails
Date: Tue, 30 Apr 2019 07:20:21 -0700 [thread overview]
Message-ID: <eb41f0b7-ed04-a405-0afb-cf72359c4da6@intel.com> (raw)
In-Reply-To: <tip-eeec00d73be2e92ebce16c89154726250f2c80ef@git.kernel.org>
On 4/29/19 11:52 AM, tip-bot for Sebastian Andrzej Siewior wrote:
> Instead of utilizing copy_xstate_to_user(), fault-in the user memory
> and retry the fast path. Ideally, the fast path succeeds on the second
> attempt but may be retried again if the memory is swapped out due
> to memory pressure. If the user memory can not be faulted-in then
> get_user_pages() returns an error so we don't loop forever.
>
> Fault in memory via get_user_pages() so copy_fpregs_to_sigframe()
> succeeds without a fault.
Thanks for reworking this. It looks great.
Acked-by: Dave Hansen <dave.hansen@intel.com>
prev parent reply other threads:[~2019-04-30 14:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 17:35 [RFC PATCH] x86/fpu: Don't unconditionally add XFEATURE_MASK_FPSSE on sigentry Sebastian Andrzej Siewior
2019-04-25 21:13 ` Dave Hansen
2019-04-26 7:26 ` Sebastian Andrzej Siewior
2019-04-26 16:33 ` Dave Hansen
2019-04-26 16:50 ` Sebastian Andrzej Siewior
2019-04-26 19:04 ` Dave Hansen
2019-04-26 20:05 ` Sebastian Andrzej Siewior
2019-04-26 20:44 ` Dave Hansen
2019-04-29 16:39 ` [PATCH] x86/fpu: Fault-in user stack if copy_fpstate_to_sigframe() fails Sebastian Andrzej Siewior
2019-04-29 18:52 ` [tip:x86/fpu] " tip-bot for Sebastian Andrzej Siewior
2019-04-30 14:20 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb41f0b7-ed04-a405-0afb-cf72359c4da6@intel.com \
--to=dave.hansen@intel.com \
--cc=bigeasy@linutronix.de \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=kurt.kanzenbach@linutronix.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=pbonzini@redhat.com \
--cc=riel@surriel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®