From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754324AbcIDXg7 (ORCPT ); Sun, 4 Sep 2016 19:36:59 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:51424 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752367AbcIDXg6 (ORCPT ); Sun, 4 Sep 2016 19:36:58 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Sun, 04 Sep 2016 16:31:40 -0700 From: Stefan Agner To: Russell King - ARM Linux Cc: ard.biesheuvel@linaro.org, matt@codeblueprint.co.uk, kirill.shutemov@linux.intel.com, l.stach@pengutronix.de, arnd@arndb.de, nicolas.pitre@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: LPAE: initialize cachepolicy correctly In-Reply-To: <20160904220903.GN1041@n2100.armlinux.org.uk> References: <20160904053331.7264-1-stefan@agner.ch> <20160904220903.GN1041@n2100.armlinux.org.uk> Message-ID: User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-09-04 15:09, Russell King - ARM Linux wrote: > On Sat, Sep 03, 2016 at 10:33:31PM -0700, Stefan Agner wrote: >> The cachepolicy variable gets initialized using a masked pmd >> So far, the pmd has been masked with flags valid for the 2-page >> table format. In the LPAE case, this lead to a wrong assumption >> of what the initial cachepolicy has been used. Later a check >> forces the cache policy to writealloc and prints the following >> warning: >> Forcing write-allocate cache policy for SMP >> >> This patch uses PMD_SECT_WBWA to mask all cache setting flags. >> The define represents the complete mask of the cache relevant >> flags for both page table formats. > > PMD_SECT_WBWA is just one possible combination, it's not a bit-mask. > We need a new definition. Agreed, it just happens to be the same as the bit-mask in both page-table layouts. Does PMD_SECT_CACHE_MASK sounds like a reasonable identifier for it? -- Stefan