From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B12D394471 for ; Wed, 8 Apr 2026 21:22:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775683365; cv=none; b=L7kGPurSCREPxkok2g3hjiUXpiqOoSgSlp+81dBo5zhFVKqkZUj5QuF1FQAHjEC2TZILO5WB7uBpqRCIwFZRH+2AbwXRlZ5K0BjfxME2nql+RaMEgg5GyBX9doZnpoZbJEjcII65s/WEiRjvH2dfRxAMziAsGb62eCtCGRyXY/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775683365; c=relaxed/simple; bh=6BeHkxLyWctFUSR46MfqmCh8uAhV3DyrDuxgljfGSGw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AyemEX4z/SqMpHw+60H3lWLB62wHNWns6f3tYF+ad9c/ebk53e/qH7z/bc4At1653GKR9XP0rhkawwTirttOJdPtS4u5UmxtcSx89cpu5XqnD+usxMnWOqGRtvMRc8t+4cPiZMZGbBYo4nu1hGgs39gG8ldkFdBNJVZS3RoITq4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fc9oSzG8; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fc9oSzG8" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-7d7eb85fb81so181758a34.0 for ; Wed, 08 Apr 2026 14:22:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1775683359; x=1776288159; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SP33wRSGcLjNkqt9PmKyMhjJTYVxYcQC6XjnQNqNNFs=; b=fc9oSzG87Zf6UlihO7nchOxdHK9zLnEToTfCJ9ovupyoVT1dNBAK4iKkymuusKSUt4 pxA3WSznsQkRy0bcFgJbVKoPzaacVBV6DB0nEN2fATHuc36sbRUlH/um6zN63jccKKAL X/PnC3XO5tdXQjsDpBsfb1n4RI2DFhILYVNKM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775683359; x=1776288159; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SP33wRSGcLjNkqt9PmKyMhjJTYVxYcQC6XjnQNqNNFs=; b=L+cR6MzXGf9yQU3U1GUBz3YpWionuRz2I+0rb/FyaGidwA1EoK5i9zYs2NrguuvOgO QzHh6vvqZXp/kma5NZayMDiWtfmqa4RrODQNOHU2VGsS/N3utZweceu2snJ4YEDpV5Ri l7qDR3XiZaalaZQujIF7qEP7hqZghISABp5jCZUfvjzqkAEUsn+PpaK9bcGbo6N58LMX MfjcP53pFWY+jjlW9t7emvk7Az1fZm7sf8b5wsYfmRmrRhlTQv6IBMiIOozXmoYr/J+K NqyQba1YkKt1ZEtuyXqjbJ6PGjBDfh1eMvwA6Q26dLVvRpgMyvwhhxyUhDYPYtPC3y8v KafQ== X-Forwarded-Encrypted: i=1; AJvYcCVkSOJk8QVJufHbWAUtr92qOBzU8HvajJlwnOPdhj5jAaVMPuXgjeVvlf6VUEMVVzmAAy9TqMJzXCMKvJg=@vger.kernel.org X-Gm-Message-State: AOJu0YxKxfS9mSLsJPCHcZTOlnZGYL9qiOSJ9+T1q9cQMmj+lDHMRk/F YUKupFIksj/egKp0zkerENd1l76zpRrlSHNS/da2Rg7ff48dv793xrOuq6wQ0bE/DWQ= X-Gm-Gg: AeBDiesmcYqk2IUEZDD92fmBDGZhcQ/EoJZVuUMMmv9PiG3BprrAkmjaN8I1+Gdh2uw 2xMqnHzVOydfPsplkITICwL6xWQYnn3aG9ArfqGKNtnO0QCLVLCsTbFEKzt7BLWrBmOyMdfjoPA paG9M0VODLcOo0sQUuunc9vC78KjsL4mYmlHEobbFdySiBK8TtEjg6naan0U9aVdgD7y4haWoTi neo8ZWK3uvRqN0MD+pE4o6BInwGAfQ7j3uI2s0R7rx1eiEvoP4KL44h/91tDubandCVhO1FDXdy bSKJnZvSGE7if6CiiPsuyeLIAiYXzGKEaPH4JGi2JQrByQfMxDyNJGXNi2NLvS44P7Mc0rJsnFp yiBMstCsgCdXAyv077Df0wWMLR87Ld/997NedHzSP62yUV/oZSL0gmurBfvtFPB/CdINclK0bFV Or1m1HoYdJhRTW7JFfS/ZBWsxfT4K++MzO1hw= X-Received: by 2002:a05:6830:91f:b0:7d7:ccc7:c546 with SMTP id 46e09a7af769-7dbb755b224mr15665376a34.23.1775683358738; Wed, 08 Apr 2026 14:22:38 -0700 (PDT) Received: from [192.168.1.14] ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7dbfc1cb79esm3531705a34.15.2026.04.08.14.22.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2026 14:22:38 -0700 (PDT) Message-ID: Date: Wed, 8 Apr 2026 15:22:37 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/ftrace: Quote check_requires comparisons To: Steven Rostedt , Cao Ruichuang Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com, shuah@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20260408043212.8063-1-create0818@163.com> <20260408171831.69520c50@gandalf.local.home> Content-Language: en-US From: Shuah Khan In-Reply-To: <20260408171831.69520c50@gandalf.local.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/8/26 15:18, Steven Rostedt wrote: > On Wed, 8 Apr 2026 12:32:12 +0800 > Cao Ruichuang wrote: > >> check_requires() compares requirement strings that can contain shell >> pattern characters such as '[' and ']'. Under /bin/sh, the unquoted >> test expressions can emit 'unexpected operator' warnings while parsing >> README-backed requirements. >> >> Quote the relevant comparisons and path checks so the helper handles >> those patterns without spurious shell warnings. >> >> Validated by rerunning fprobe_syntax_errors.tc and confirming the >> previous '/bin/sh: unexpected operator' lines disappear from the >> detailed ftracetest log. >> >> Signed-off-by: Cao Ruichuang > > Reviewed-by: Steven Rostedt (Google) > > Shuah, > > Care to take this through your tree? > > -- Steve Yes - I can take this for the merge window. thanks, -- Shuah