From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FA5C3A8732 for ; Tue, 16 Jun 2026 21:15:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781644514; cv=none; b=WGJUN+3dTY/RNdX6D/QM5ilPR9eebqAk+8vWK60yyKNsT7gES2NRTiJxuCHRY8DVpzNLzZeLEs5BhUUZIvaMEgQ1nLO1bUU+FZIidAV1Js3bd3LwnIoW++p1dxxq0VqXQevq1C2Z6hfsznmiWNo9LkLi8HDQfwaoaCxod0aUktQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781644514; c=relaxed/simple; bh=9cJfNH0ziEviy5OuCjK7Bi9q3ur/HL+ImJl5v/T282c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uFQ4f7KNtqCXFiO/5eqojiGXj6PelPu8EOips9kbN1JoAOQwA7vN0pEic/KQguB2CNF73graXO01ead1eaa2bjWHejDB/eI69EocLQwAzaHMR6L8ntOO5csqKVDThngBwRxn4DoanhWIhCqLqw79A3KwgzcT2dgNU2qofVTwRcs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Q2oPYf+j; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hbXPXAjZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Q2oPYf+j"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hbXPXAjZ" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GKaBbi618546 for ; Tue, 16 Jun 2026 21:15:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sgOZGAVRtcof+wGB0xB9WSeFloGw8arPsNKl8QzdnwA=; b=Q2oPYf+jo1OvqJTw 32YbeVDpke0fD6J3kNMfzmSzeD788D6pocq05EmXvXt0Rd/og22w3ueg/tKQpMza IzGGHORUG35ejfjyPofnYwOQVNW4XY4vLATf+Ce05VjNd6J6/Hy/K89MSUsgsUum xlHDXDlX4aZ+t74kQ6McsFoQpP9FfcOJXv58eGmkFPEd/CRfDeUsPU6fJFyXQnWn QZ7zfvvUDKXW6QCc7qD9bFcLrNs63W4bm6Q6rC2lX8BHbGbwjjBRh7zWnnDZXG72 rAbzAXhzKbx7O8L375+oRJ1XOHnQXl9cTFmpCxeY+XAoVkJQSbR8v/YUByIwA2li +zGIOA== Received: from mail-dl1-f72.google.com (mail-dl1-f72.google.com [74.125.82.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eudnx09uf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 21:15:12 +0000 (GMT) Received: by mail-dl1-f72.google.com with SMTP id a92af1059eb24-1383723dfddso6536797c88.0 for ; Tue, 16 Jun 2026 14:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781644511; x=1782249311; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sgOZGAVRtcof+wGB0xB9WSeFloGw8arPsNKl8QzdnwA=; b=hbXPXAjZqAQzemdQEN/KroCrXEJpPebp4Zd2V7FRlwgJ0gP9BChlkGHRgZhERY0KSQ yvDe2Ie3uTiclf0tLFp6lXv1fpg8U/19Ds6s43FgD3Tsy7PHjKFccfgomaKl8l+kdetn S/OC6Zjgyg7CvhsauAMVGYYF3ninUuwcTb6GykSb5053F4B0Oqb10zdd/mCa6bqYom9N sXJ0hAcQmRnLPMILiCpOn3UOhkmnTwo4MNnOcYsKX0rmAIriUWeCL6q37oKM73TukXPR 07GGgMOaHQPoqrUVIfqZhNj9fZBg+gMt9GFl7E9nIsb+BTfVufE3rcvdD8zHL8t2bYRz LgoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781644511; x=1782249311; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sgOZGAVRtcof+wGB0xB9WSeFloGw8arPsNKl8QzdnwA=; b=jAKL7H2x6Ydsn5K3DMDynxcdxMzKWVQy6xWMr4i8SQhZ4kFC44SH9YMruepi86kvKP LmJUd3QDdupsPLzRjQ4QuYPInwWLe6daXyFRsFNkiMT8l0WF2O1MbKXBhkHnPj7O1OQZ rWnhf8u/ghU2U0tqhuns1ByGdU8qGo53J0Il7jpsFi4bvKn42oHv8Al75VTpVWGGYCzc CerSqv9N1MU4tP7645X9E7mRf3jt+/FVUGDzhtAJT7w6q1tKEDfv2EfHJOKPtY/dNb2o qzmwckr9vBuVp94d66NBv69J2GmypXJgsdoSdLDdxULZP8NwQoQ3DTfqk2uQlz4QKys7 npgQ== X-Forwarded-Encrypted: i=1; AFNElJ8hABiYIv4Un0cmZm1xoNUAhK6XAYJPSvXoOyreAR5VKg4z50ZG5pAGpF8dVNDOQUdcpk/rlljdYiHcL/8=@vger.kernel.org X-Gm-Message-State: AOJu0YxAyyJq1ZsWrR7T09Nkky0UfcRnW6B0QfVyyFTH0qkQq77Bk/4H pT45uvmBTN/8bolxqQc2LEpvrazCvtFLrzxliP9/vDhzIQ9RGwwl3jwfbwxbdoJwDf90M6xd89F qzEFY7IbBhxp7heiKkvmFIRnB2b337LLLfPd4eXO7FTMfanZ8G+NmwES7+XB9ylkAC30= X-Gm-Gg: Acq92OGNhQ3mW4YcH65oBBFzKKjvyCuI7I3JOZ4Npebo5cFZnvfX59hYtKYIbGhL4YM DVIBCZ4ooXg5Q9jKN05AysUFGnULmIVn7UsP59mrYMfeGn+kdvyYpNaP+2YhUYZCdDxSOd87fPy LY8ju0F+LF2P9Y0CmUi3Xlb7eD01rSUGNWR7i0s38ADGf6TXsB8unXemjsqdeESvZaHOSeRZIKH aSIjeSYZnu/gXuRdJxw6MTuXP3vr8orjZRwdLB467mVYo9zEOjjpBaRXzGSO9ilKHG4HXeAfWJP omfpkB/d3XmDD3501HJyfA0OWFjxBnNIzvokYsBXiDIblcAHttw172vbH698vOpL72rzGtStF9e CsPUYsP2Vwj+GhvOYEK14Sau+v5scr2Pw1iydHnknqg7/P4KvdAeet0LXnQymE5j1QAkXpdy9Zr astk2RmqyZyJ4IkA== X-Received: by 2002:a05:7022:6b98:b0:12d:d972:b969 with SMTP id a92af1059eb24-1398f696275mr381895c88.24.1781644511471; Tue, 16 Jun 2026 14:15:11 -0700 (PDT) X-Received: by 2002:a05:7022:6b98:b0:12d:d972:b969 with SMTP id a92af1059eb24-1398f696275mr381871c88.24.1781644510903; Tue, 16 Jun 2026 14:15:10 -0700 (PDT) Received: from [10.71.190.32] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1384b97570asm14029259c88.12.2026.06.16.14.15.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 14:15:10 -0700 (PDT) Message-ID: Date: Tue, 16 Jun 2026 14:14:59 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] firmware: arm_ffa: Fix NULL dereference in ffa_partition_info_get() To: Sudeep Holla Cc: Jens Wiklander , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@oss.qualcomm.com, Trilok Soni , Satya Durga Srinivasu Prabhala References: <20260611-ffa_partition_nullptr_fix-v1-1-ec2b7ef7e130@oss.qualcomm.com> <20260612-fat-energetic-hummingbird-8ddc62@sudeepholla> Content-Language: en-US From: Unnathi Chalicheemala In-Reply-To: <20260612-fat-energetic-hummingbird-8ddc62@sudeepholla> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: LCvvmvXi3oxB4xNabuJSrWsI_tOzRCiR X-Authority-Analysis: v=2.4 cv=KMdqylFo c=1 sm=1 tr=0 ts=6a31bce0 cx=c_pps a=bS7HVuBVfinNPG3f6cIo3Q==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=l2X_Lv62_SrtoPT5pgEA:9 a=QEXdDO2ut3YA:10 a=vBUdepa8ALXHeOFLBtFW:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDIxNSBTYWx0ZWRfX+QPtIdAHF7SP MTZKdcNonw0dlZllyMzTDGTgnE1MNCAvzUi+JaXhQxLVN+Ezv6kdK4PvKJ+cnPG2jf+i82/7Ut5 afH9NO5hwCOvAHzh///Dnj+TjcFuV+E= X-Proofpoint-GUID: LCvvmvXi3oxB4xNabuJSrWsI_tOzRCiR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDIxNSBTYWx0ZWRfXwcjC9Vh3EBVj NxF7LeOViksPj7IendcfFVle8Jfqee+8o13zVGFqTfWR8Plz/FBt1oTLwQQKldurLRghempfBKk pU/wA8IDSpZn4QgXeo4PSbbPp+0yQhNVfm439k13AtlNQd5sfPIB+u+xtNB9lxgv8cGiNd2Fiv1 pFyJc5tHKtB/2qfJgijXHNv5qtED7hgZWRZH5XYGLXtP7jlTVZtRqLJStBlvoIlYcdonM4YxQZZ gRqBh7Nat9652CU7xMemFvFpvnUC4rZcBVpznEKm1TT3yoDWH/V9ZoxB2+a/zLtOlrFF4VZy2x2 EempxzpsC/DekRNiOTPVkJuOjNFyHS7Czf8N/aAMY+UNyy1QtsaaoNm8CLJM4trwkzg8sN90c0+ ktJpQ6BQerAWnMsSfeyni7Zbu8xtTddqUH4GymZgxpvE0/TtOzpSUqf32h70AiqORyfU6dPjEWD gWGUHgo0FvLYSOj0Y8w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_05,2026-06-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 spamscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 adultscore=0 impostorscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160215 On 6/12/2026 3:55 AM, Sudeep Holla wrote: > >> Per the FF-A spec, the all-zeros UUID is the defined wildcard that >> instructs the SPMC to return information for all partitions. Map NULL >> and empty string to uuid_null rather than crashing in uuid_parse(), >> preserving the intended "return all partitions" semantics for callers >> that pass NULL. >> > > Agreed on the spec part but not w.r.t the interface. Where is the driver > using this call and why is it sending null or wants to extract all the > partition information ? > A developer wanting all partitions might reasonably pass the all-zeros string "00000000-0000-0000-0000-000000000000"? >> Fixes: d0c0bce83122 ("firmware: arm_ffa: Setup in-kernel users of FFA partitions") >> Signed-off-by: Unnathi Chalicheemala >> --- >> drivers/firmware/arm_ffa/driver.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c >> index b9f17fda7243..dd500fb81b79 100644 >> --- a/drivers/firmware/arm_ffa/driver.c >> +++ b/drivers/firmware/arm_ffa/driver.c >> @@ -1129,7 +1129,9 @@ static int ffa_partition_info_get(const char *uuid_str, >> uuid_t uuid; >> struct ffa_partition_info *pbuf; >> >> - if (uuid_parse(uuid_str, &uuid)) { >> + if (!uuid_str || uuid_str[0] == '\0') { >> + uuid = uuid_null; > > I object to make it uuid_null. Below check is enough to check NULL > dereference. > > - if (uuid_parse(uuid_str, &uuid)) { > + if (!uuid_str || uuid_parse(uuid_str, &uuid)) { > > > I don't think we need to service NULL as valid argument via this interface > as the callee driver needs to pass its partition UUID here. > I agree with you, NULL doesn't seem like a valid use case. Will send another version with your suggestion, thank you for the review. Regards, Unnathi