mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Sricharan R <sricharan@codeaurora.org>,
	robh+dt@kernel.org, robh@kernel.org, mark.rutland@arm.com,
	linux@armlinux.org.uk, andy.gross@linaro.org,
	david.brown@linaro.org, catalin.marinas@arm.com,
	will.deacon@arm.com, sboyd@codeaurora.org,
	bjorn.andersson@linaro.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	absahu@codeaurora.org
Subject: Re: [PATCH v2 02/13] ARM: dts: ipq4019: Add a few peripheral nodes
Date: Fri, 16 Mar 2018 12:17:55 +0000	[thread overview]
Message-ID: <eb50deb1-0530-866f-502e-e675cdd1e732@arm.com> (raw)
In-Reply-To: <1521193101-4586-3-git-send-email-sricharan@codeaurora.org>

On 16/03/18 09:38, Sricharan R wrote:
> Now with the driver updates for some peripherals being there,
> add i2c, spi, pcie, bam, qpic-nand, scm nodes to enhance the available
> peripheral support.
> 
> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
> ---
>  arch/arm/boot/dts/qcom-ipq4019.dtsi | 134 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 134 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> index 10d112a..e38fffa 100644
> --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> @@ -25,7 +25,9 @@

[...]

> +		pcie0: pci@40000000 {
> +			compatible = "qcom,pcie-ipq4019", "snps,dw-pcie";
> +			reg =  <0x40000000 0xf1d
> +				0x40000f20 0xa8
> +				0x80000 0x2000
> +				0x40100000 0x1000>;
> +			reg-names = "dbi", "elbi", "parf", "config";
> +			device_type = "pci";
> +			linux,pci-domain = <0>;
> +			bus-range = <0x00 0xff>;
> +			num-lanes = <1>;
> +			#address-cells = <3>;
> +			#size-cells = <2>;
> +
> +			ranges = <0x81000000 0 0x40200000 0x40200000 0 0x00100000
> +				  0x82000000 0 0x48000000 0x48000000 0 0x10000000>;
> +
> +			interrupts = <GIC_SPI 141 IRQ_TYPE_NONE>;

There is no such thing as IRQ_TYPE_NONE. Please replace this with the
actual trigger information.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

  parent reply	other threads:[~2018-03-16 12:18 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-16  9:38 [PATCH v2 00/13] ARM: dts: ipq: updates to enable a few peripherals Sricharan R
2018-03-16  9:38 ` [PATCH v2 01/13] firmware: qcom: scm: Add ipq4019 soc compatible Sricharan R
2018-03-16  9:38 ` [PATCH v2 02/13] ARM: dts: ipq4019: Add a few peripheral nodes Sricharan R
2018-03-16 10:17   ` Abhishek Sahu
2018-03-16 11:29   ` Abhishek Sahu
2018-03-16 12:17   ` Marc Zyngier [this message]
2018-03-16 12:40     ` Sricharan R
2018-03-16  9:38 ` [PATCH v2 03/13] ARM: dts: ipq4019: Change the max opp frequency Sricharan R
2018-03-16 10:19   ` Abhishek Sahu
2018-03-16  9:38 ` [PATCH v2 04/13] ARM: dts: ipq4019: Update ipq4019-dk01.1 board data Sricharan R
2018-03-16 10:20   ` Abhishek Sahu
2018-03-16  9:38 ` [PATCH v2 05/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi Sricharan R
2018-03-16 10:21   ` Abhishek Sahu
2018-03-16  9:38 ` [PATCH v2 06/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.1-c1 board file Sricharan R
2018-03-16 10:21   ` Abhishek Sahu
2018-03-16  9:38 ` [PATCH v2 07/13] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk04.1-c3 " Sricharan R
2018-03-16 10:22   ` Abhishek Sahu
2018-03-16  9:38 ` [PATCH v2 08/13] ARM: dts: ipq4019: Add ipq4019-ap.dk07.1 common data Sricharan R
2018-03-16 10:22   ` Abhishek Sahu
2018-03-16  9:38 ` [PATCH v2 09/13] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk07.1-c1 board file Sricharan R
2018-03-16 10:25   ` Abhishek Sahu
2018-03-16 12:45     ` Sricharan R
2018-03-16  9:38 ` [PATCH v2 10/13] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk07.1-c2 " Sricharan R
2018-03-16 10:27   ` Abhishek Sahu
2018-03-16  9:38 ` [PATCH v2 11/13] ARM: dts: ipq8074: Add peripheral nodes Sricharan R
2018-03-16 10:47   ` Abhishek Sahu
2018-03-16 12:43     ` Sricharan R
2018-03-16  9:38 ` [PATCH v2 12/13] ARM: dts: ipq8074: Add pcie nodes Sricharan R
2018-03-16 11:20   ` Abhishek Sahu
2018-03-16 12:42     ` Sricharan R
2018-03-16  9:38 ` [PATCH v2 13/13] ARM: dts: ipq8074: Enable few peripherals for hk01 board Sricharan R
2018-03-16 10:57   ` Abhishek Sahu
2018-03-16 12:43     ` Sricharan R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb50deb1-0530-866f-502e-e675cdd1e732@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=absahu@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=sricharan@codeaurora.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome