From: Johannes Berg <johannes@sipsolutions.net>
To: Lee Jones <lee.jones@linaro.org>,
kernel test robot <oliver.sang@intel.com>
Cc: 0day robot <lkp@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
lkp@lists.01.org, stable@vger.kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [nl80211] 584f2e43bb: hwsim.ap_country.fail
Date: Mon, 11 Apr 2022 11:27:20 +0200 [thread overview]
Message-ID: <eb5873b4afeee8a7e183a9b1f2e6af461bf7f69f.camel@sipsolutions.net> (raw)
In-Reply-To: <YlP0A+PurZl39sUG@google.com>
On Mon, 2022-04-11 at 10:25 +0100, Lee Jones wrote:
> So what exactly happened here? What does this failure tell us?
Probably nothing.
> Is the LKP test broken or did I overlook something in the kernel
> patch?
I think the test is just randomly fluking out.
> How does LKP make use of NL80211_ATTR_REG_ALPHA2?
>
> I'm struggling to find any mention of 'hostapd.py' or 'ap_country' in
> LKP [0]. Are these benchmarks bespoke add-ons?
>
it's running the tests from hostap:
https://w1.fi/cgit/hostap/tree/tests/hwsim
Anyway, I think we'd better fix the issue like this:
- [NL80211_ATTR_REG_ALPHA2] = { .type = NLA_STRING, .len = 2 },
+ /* allow 3 for NUL-termination, we used to declare this NLA_STRING */
+ [NL80211_ATTR_REG_ALPHA2] = NLA_POLICY_RANGE(NLA_BINARY, 2, 3),
What do you think?
johannes
next prev parent reply other threads:[~2022-04-11 9:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 10:50 [PATCH 1/1] nl80211: Prevent out-of-bounds read when processing NL80211_ATTR_REG_ALPHA2 Lee Jones
2022-04-01 18:35 ` Jeff Johnson
2022-04-05 9:14 ` [nl80211] 584f2e43bb: hwsim.ap_country.fail kernel test robot
2022-04-11 9:25 ` Lee Jones
2022-04-11 9:27 ` Johannes Berg [this message]
2022-04-12 10:23 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb5873b4afeee8a7e183a9b1f2e6af461bf7f69f.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=netdev@vger.kernel.org \
--cc=oliver.sang@intel.com \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®