From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753572AbdEHNU2 (ORCPT ); Mon, 8 May 2017 09:20:28 -0400 Received: from mail-sn1nam02on0047.outbound.protection.outlook.com ([104.47.36.47]:24925 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750925AbdEHNUY (ORCPT ); Mon, 8 May 2017 09:20:24 -0400 Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH v5 15/32] efi: Update efi_mem_type() to return an error rather than 0 To: Borislav Petkov References: <20170418211612.10190.82788.stgit@tlendack-t1.amdoffice.net> <20170418211900.10190.98158.stgit@tlendack-t1.amdoffice.net> <20170507171822.x7grrqg2tcvbv6j5@pd.tnic> CC: , , , , , , , , , , Rik van Riel , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Toshimitsu Kani , Arnd Bergmann , Jonathan Corbet , Matt Fleming , "Michael S. Tsirkin" , Joerg Roedel , Konrad Rzeszutek Wilk , Paolo Bonzini , Larry Woodman , Brijesh Singh , Ingo Molnar , Andy Lutomirski , "H. Peter Anvin" , Andrey Ryabinin , Alexander Potapenko , Dave Young , Thomas Gleixner , Dmitry Vyukov From: Tom Lendacky Message-ID: Date: Mon, 8 May 2017 08:20:14 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170507171822.x7grrqg2tcvbv6j5@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: MWHPR17CA0069.namprd17.prod.outlook.com (10.173.106.159) To CY4PR12MB1142.namprd12.prod.outlook.com (10.168.163.150) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eb0ab9bf-2724-4b81-a115-08d49614fab3 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:CY4PR12MB1142; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1142;3:1YevcTagT+P/m6QZ4KF1zISLz2GDk1NI+VfRIUFckDSXlOyAk9cvzDCo3bIXBuiA2D/y/Bd5nzVPYdhb3KZeVwHwLtcvANv6HgUvE4SnXC4HfEW/b84EqjVe/fevcgo11SF4bUEfwlSw0zqddHu0aONUI9hmk/1TRwij3dVkkqxhupI4dZavFqUkLNJhmqHLRHJ2bkBNbZl1tYPJDmz6p+AyyiGPCGDIGCNrFwr0FeVwqV3P06Jcda9FFSKF4b5SZdfrLantsHEMOxFXnY0YDU6VltnL2KUBhLORKeeoayMn1j0/a/33g/TJ6Eu+hFZ9/FKWBJUOthm8qEBtoNxGOvZOsvyQ0odYJP2lTp+Hobs=;25:VXNFvKoCO6uWUFfTduL3QlsEOtBI+TBfiXyedwib1A3tNTcBemdpPbL25B0pHpliX66Wtnr+UzLZWiYi9jbEHP/mYEGdlA/dhWnfTe5iIONpKSzbyhNP2dFJ/8VQsyY/tB4K1bqnV8qFvaZeQtMIXMbSRFrPK8J4TU87qgasDZcroTOAfeF0ZHr0DNC/0oSMVccevB8mfPTcCiK3eNsOsHHITRcpoNQN/Qbb2btW3J0F0s9BV1NE9KLvvxSW76ynBB3otn3s5iirt8QkWbVkRqVkbF9AYcJJ0siVx1NrtgYmuhK+xcq8Th+RXXt8bD8A1N1n25ezxPpi+1wzqwLk3VEl6Ve9hC5q0WrDFsV/Ui1GkpHxpBipG8O5hCA86qO4OLAQOfSPnZ2UgqIKekKzdWCyaQ2olb5YXlnugkjvrok6U4N9icc36kuLFKT3zZMQar2Dv6EM9bCM8olTBezLaxdITkLYwDCZD52GizlF3cw= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1142;31:WmbuhUg4kLd4tRo2khzYudvKb8lXSmv5uES2ErjF5cte5XtpczOndPwt+hKPaTqpO6xeQjbEJxvOWdFeeqbaGwpYGReYPoBEVtNs0/q6Lk9WOHw857ktOE2pQ+8SXvEwhGq415DD3fWGUKjoYF3RJ29vxT3j0vYNVgZ5s/a1cf3RI1FAvAxefGyR/COhedfX1UpVeFHacN7vpz68wF5GF/GuM7oSfXJk6YfqZvmu8Vsc10ANW0sg2xS9zV/1jxgK;20:zyybEVY7NDlFbC8P/6FHacdEnPkCMoBNOuWuBBWE1+hSMhYXVcLWVQxJ6FHRgM0tFkkS98sXiB1vjJrSGF58X2bg54ZACRxnIZMHnzOugryAzCuFNAK/Dfju7q729zA1Kp7XwgBsl0a5FS7etDpUmxU+qb8XI3TdoSS+PucNPvBaLo44Yr3hyHMcrp6paB0MZNWddSA9y4l6o1bWs5e+etM/OHV6F6CILNYD6K6vF3UglgY4DpdBx88owatD5Kj5y5fpqJuoT0F6G1tInJcluAdx+az5LhiFqCBagSnbXRuMBqAk1frliTHn80qpif4pC6NpVtRi2rKh8G4TpzcJs/R3JyA6eoIiD72yuWb5Ayevx85N6jGk0eajBZPqTGwJe8HYQwSIG51SWjh+xiSyvWI6R54MQVpONepkKFJ1S48hYIm7O5FniRyFUZx5lo9Dv+P+TdWQ2SnHJUuQoLkcGY9wV7yIWrc17KPcQUl0LtIbb3aHgrjlWjHCvcan+0Kn X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123562025)(20161123558100)(6072148);SRVR:CY4PR12MB1142;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1142; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1142;4:8ihABimBcADVePRM9dOfFZn3D5dYenhEWangG2t6Y9+YuvHSVfUX1WviZiRPB7lpFR5MA9ztLRsetkYxNuwq899GeyS5HjnqtT1h5VAIwIPhqu73aX1RxiokcPr1wZTjglA3+X1Sp3uJ3Pv0LdL5yoz3RKPeP/wh4r67QVzRBSxGC/wffGXeG40oPu+V5B9NbO+3OIgVRSY3eO352cf8X7AIFzwhWP90bOmvLqm77Zz+8BW4/HlFHhdfu+DRh0qiEUW7xv7x/8RNJQAWI5iaFGTn84hEGV0UymHC2yHTBxTzbcs21JKEYuca/yLiaYV+7E/PjhEIRnUZDkyoPVUqQ8tbB7eTYoOngP9F0NSC+NWMJ2xwU+OcaQnC1YEWp34WnFWvsJRHIjpEnWXhBGrYCUFWjGrrdvGS7a6JP437x0RSJke7K7yJM5p0Ud+c+nm5AGUJkzIVrv9C0zyypickhixBvhnNZME3a5CzIhEQqO9mxIZNmsrmVBSeHPLNM/OUEvm4XZV7mfK1wUE9dyUixOH6CSKtJfqIOJJ/AunJ2X7mxEKXq8kL2dyvOmAO3Uc9QfyTgJ4y3LOrKG+UAKnbBNzxjxrIyGPl88dQPUsnoqrE2kskS84duXL+2/5gv8JdQDU9LeGFs4JMMBW8VN+ilg2j5xszxJIs75dlySaVUEI64UplzuKcZTe2sBYS7XQvJ9M6JO0zUEvGOYOdUugW/8/o3pt19zI6xs8Mr+nRvSjmis148ed6Y73Kq1dLoLUPXiq7a0RlBwI1wS3SzEL87jiyKMjIcoC/supOkdiqOmtyfMtonaD8pISqxj38Jg2crH8FseX6GiZr5YpShbrlgQ== X-Forefront-PRVS: 0301360BF5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(39410400002)(39850400002)(39400400002)(39860400002)(39840400002)(39450400003)(377454003)(24454002)(81166006)(478600001)(50466002)(305945005)(76176999)(6916009)(47776003)(3846002)(4001350100001)(189998001)(42186005)(2950100002)(230700001)(77096006)(64126003)(6116002)(65956001)(66066001)(65806001)(6486002)(83506001)(8676002)(25786009)(4326008)(90366009)(54356999)(50986999)(6666003)(2906002)(229853002)(110136004)(38730400002)(86362001)(36756003)(5660300001)(23676002)(31696002)(7736002)(7416002)(33646002)(53546009)(53936002)(65826007)(6246003);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1142;H:[10.236.64.250];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjEyTUIxMTQyOzIzOjlRWHVDTVdJb2VHT2p6NGhmZFMvNkNYdGxu?= =?utf-8?B?cjlOeHc5T0Z0em5yQS9vaG5peWY2N21zRG5Od1QrNU53Qy8xeVJaendXVmd3?= =?utf-8?B?UjdGWkxqeDArQmlXK1BpYXU5LzNiWTZuSlQrMnFvQ0NmMjFwZUV0dEgwODhp?= =?utf-8?B?N3dNZHFGSnhPT2toQjdWa0xTekc3TGM5YTdZdVZITGtDK3Axd29DdytCNWNG?= =?utf-8?B?M3JXNjJscVl4OWF2a3Q0NE5kYWVxSkxvL2dnenhhQXhhMDJ2VU1BYWU4dzNp?= =?utf-8?B?WDNsOFJWK1VHZTVxcWZ3RS9NcThScnBUOVoyZkV0RW54UklDWlFJVU1jaUlv?= =?utf-8?B?bXdHUE5qZzhGeWpOYm83ci9oUy9nZWs2QXdKUU1Mc2FWYVBoQzBtazdWN05K?= =?utf-8?B?WnV5Vm1ZM3BmcGtwNTR0N01NbWQreGkyY2ZWODVIcHB0dXVNb2dxOEJ5YlJG?= =?utf-8?B?MEIyTCtoYXRyNEFYa1V5SE5WeVRpQk1zdU1ySWZCdVFsazFmaUJDK095b1ZG?= =?utf-8?B?SzJqK21UVXowM1FON0N2anRCdVlOVVlXdm41eXFEUVBpUVJkRGYrVFhnSTBy?= =?utf-8?B?NVQxdlQ4aWpnMitBd1kxN256UlV6Q28rQlNNak1lN0VOK2duVjlvblQvaDF6?= =?utf-8?B?NlNEWmxmY05qUGZXRUdDbHNqazJRc2ZGTFVEa0JWR1NkeEV3T3JMcDc4YUNC?= =?utf-8?B?UFJGU3lmMzNFc1lyVlRoWVU0RTlsekhEVUU4RHczUVhRTmJoR3JjOGtqbFhE?= =?utf-8?B?RkozL2VMeXU0QnZVQ1RBYmU0QmNTdG93aVhRSFFsOHZyT29ZVE1pMytqVm01?= =?utf-8?B?MkdTQUcvc0J3b2xLbEJwK2FkeDFJZ1lZMldoZ29PUnRoeXg5OUFYNVhSRlVM?= =?utf-8?B?dDRUN0lSbG4xWXAweitHMk1paVZ0aTRZK2xSSytDRjdNUzVXY2h6bDlVUGp6?= =?utf-8?B?a3MrbUY5dU5qQ1hRYTRXMGQrdHpvUDNIQXJLZFBSckEwTDMveFJzTmxyd1A1?= =?utf-8?B?QXBWakVnbjk4SGFSaklsUU83NkluMUhLa0swY2tuME9kVkZINDNvaWptWHpK?= =?utf-8?B?VWpyTUJ4U3R5b1hLWGNuWHhwMUlGSXNHL0kyWTh4cHJDUFdYZE56NTV5cHRm?= =?utf-8?B?d3A3bWFFOWVrRFJyaUJITlo4UmMxaDRNd2ZyQkN3VFR6SENHZGhwVlE4NXhW?= =?utf-8?B?S3hUM2d4RkNsWnRDdHJ1cjZ5Umc1T2pjbGZCTU8rM3pEc3diRmlFOHhnQXN0?= =?utf-8?B?aWhXbm5TQ2hJMU1nTkwrQW0zWUNXaitwMWhmM2QwWjBvZnRrVXlqRFFqbDla?= =?utf-8?B?clNoTHQ0KzBhZThIdTdEVUwrZlZRQStVNi81OHBMZkt3M3pjZ0JTaEE4djJI?= =?utf-8?B?MXJ6U0IxL0JNdDRuQXBYaFcrSkdOQ0w0QVNFVzZjOWxsRFBaWi9vOW9CdkhG?= =?utf-8?B?RjNwaVdHdTErY3pnSVBianc0SEFaa1RZek9iN2Eva0xPMUJrblM0ZENvYmlu?= =?utf-8?B?SjRzaS90MDJUb2o4OW9pK1BTNHd1TTZlMFp3TTBRQThMQ0JFbnduZzhhZ1Yz?= =?utf-8?B?WnVETFExT3E5T0FyYjNzSnl2UzNiNElEaDg0Tk1XVVJ1dURlRGZQM2FBaFlF?= =?utf-8?B?aHQ0aGJOYllidnRKdU5pUy9SZXFLVkE5czc1Z3BYRng5UUgvSCt4b2t1TVpz?= =?utf-8?B?ZVFuZEpocXZnYlJSQ0l3OUJKV01PemQ2Q3RaNVRtNFhXMWNkNFo5M2NYQmND?= =?utf-8?B?OVpzYUMyUkN3eGo0d1Q2c0JxbEtraWJzVjg3ZDRvdWVjaWl2OU1jYXljOGVD?= =?utf-8?B?TDBYTXZkNmxVZWJ5T1VPY3BjZnozVXFxd2FpanQrQjRGNVE9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1142;6:7iPEoE+zj9k1j9BeWPWIuB+/mraEbUAaXB/4b4UVUH3+yl0o8Ouc1d4mommEiDRMtF0qx96x4fwsu+9dBNBOcjbJXEqplxX0Jo03fDnfNn0FvpLZEvBuenqxS7NzapL6izfl3KaJpsRJYP1FmdJcx840Z0SSPDcnyUg913oeVWaY/ECtAc8x/dmxQt/HCg4jGaSrdJlOHNqtX22hgjHxwSApeR0Q86AioTMf09EyrbMSTHmkp2gB0TbjIUlBByJPgmkXoLvdSRptNdjYUU+uyOrvETRuCHGz79BRxSHLUW3U8gul521K4iuivPnSP23oEu57K10Q5MJiHTl/ofla/sX8MtSJXEAmusXffHo4VPOgYof6yqvyuVyj8Jlm043Hdb6Zf3p9LmL8KqGk8eikatA5vT9v7GpFeMUNUsLRki8fuUWXLJ8JcXELscMVJkDOq6II/vEJHkmIjtZBCMBF3hCn77mWq+gDhThBJjolzPz7CDGNY+OKxdoKgQiPE2VweMuO0lEQgrBjasAl4G+wLBZAyBRkjqU72Yurlv9q0AE=;5:WZrSNY1G6BUk4zA+kx7gg+/qnE5vZvTNa2t3oJEMgeb26ZwlzAFBpwGojK1uHH9oc2TSln/9us0K2H6aNjQodtbi3UUPDZDG593jC5xzwzEhqw6PLt7d0bzzqDhnEasfkqrjVcvG0SYXh29FiH22ug==;24:8/2s7GafflhDVNPY04e5CMx3LHm0z3cCP9CPnLhbNbl74XirJBDeO63B4+WMAsVD7nLeMJb8nVA9r6GIFI4aI7r3/uCNZQxKp4wOMXXDoCw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1142;7:Vaw73RUyzVqnEck05kquHhwSCOoeIUJOFRoC2Bo8n8dZ65Y/XEACMS6qClCVsGyvw0W1pgEIW8Qh7l3lhdcvGL06ZG/7t1KlIuL1DpAOx1ujAJOefsEtPS+F2UvSPTvCvHZECfJmsXiOdlEBAwnnMlUOGhqUt9BtdT02arIbaEVhvrwY0cNnTuUX0DTORukrMOxNCyzDm2gK5CiJWB/2+DbZ9uwheFgrEVI5LHuSJA2gD1Vx3RotsJ/Mm5ni/C5cd45fjvH4e2bne278IMKTXzRa1HBE4Q/V1J2RHAuzvwPRVx5dKhkS+TRKy4ZG8EjkODIW2bwvpL+PalTUq/YPsA==;20:HVbxilDnzUOVynm6JKBTWAexE7RLW/a1YWA9HIJB2JeiXcGotb1PWPSm0fqcgN3PrxFPclPbeBm60/GwaUdqfc617OdBT0s7MnDqXgP5ylep+uaLeBCozK+S6LJx7athbfNmsf+f9zCr+oOA29IrpngyvT1Px/Mb10AG5EPlZWWvg6vequSNYgCo4ZovzjLvrZ/P7l3Z+mwM8gpFl8Hs+87Bd1GrXUIyOntEPKIoG75rwLn0peKB1ae16E8lQZdw X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2017 13:20:18.4464 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1142 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/7/2017 12:18 PM, Borislav Petkov wrote: > On Tue, Apr 18, 2017 at 04:19:00PM -0500, Tom Lendacky wrote: >> The efi_mem_type() function currently returns a 0, which maps to >> EFI_RESERVED_TYPE, if the function is unable to find a memmap entry for >> the supplied physical address. Returning EFI_RESERVED_TYPE implies that >> a memmap entry exists, when it doesn't. Instead of returning 0, change >> the function to return a negative error value when no memmap entry is >> found. >> >> Signed-off-by: Tom Lendacky >> --- > > ... > >> diff --git a/include/linux/efi.h b/include/linux/efi.h >> index cd768a1..a27bb3f 100644 >> --- a/include/linux/efi.h >> +++ b/include/linux/efi.h >> @@ -973,7 +973,7 @@ static inline void efi_esrt_init(void) { } >> extern int efi_config_parse_tables(void *config_tables, int count, int sz, >> efi_config_table_type_t *arch_tables); >> extern u64 efi_get_iobase (void); >> -extern u32 efi_mem_type (unsigned long phys_addr); >> +extern int efi_mem_type (unsigned long phys_addr); > > WARNING: space prohibited between function name and open parenthesis '(' > #101: FILE: include/linux/efi.h:976: > +extern int efi_mem_type (unsigned long phys_addr); > > Please integrate scripts/checkpatch.pl in your patch creation workflow. > Some of the warnings/errors *actually* make sense. I do/did run scripts/checkpatch.pl against all my patches. In this case I chose to keep the space in order to stay consistent with some of the surrounding functions. No problem though, I can remove the space. Thanks, Tom > > I know, the other function prototypes have a space too but that's not > our coding style. Looks like this trickled in from ia64, from looking at > arch/ia64/kernel/efi.c. >