From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBB7021772B for ; Tue, 20 May 2025 21:16:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747775765; cv=none; b=lxVS6uhEaPfKJlq06OqcIRmUDfcrWPrAzSeKANpUGkHI4fFegEZ79H96OA5zV6oy7lonbZ3Mv5RESaTbDdc5LbyDvKr5FNutHkzvO1DeRsfCUMr6F99IHiTpZABvtU42pPY0ZqSyIl4OayNEExzWF1OlVqId+leOif3NeLU0fHw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747775765; c=relaxed/simple; bh=PokIbil+4vzb3IM+d56Xpj4Mvgib+ySxP9q4ulJxR48=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=daluGO/AgUCO3WSr2HzkeZLzmmQrra6QaDsE9KCJS9HkWN41wLt5LqwHaSUpOFXVDbutsA8jAlpIgJvYF4Xu6bXSP4D29UUydm2OoiIGGvx0QGuA5yQ0nBuKE1r8EY0CIbj3n2moyRdXXtd3VBIDm3nMpE77orxhjA8iUGjYVw0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=SATGsQUV; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="SATGsQUV" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-6f8c0c8da93so63438556d6.0 for ; Tue, 20 May 2025 14:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1747775760; x=1748380560; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=0Vcim2IrvThidRodNsg/OfOdq2fd5gLucgy52LkkAJU=; b=SATGsQUVNCcWA5EQ2sN31YQi0KcO0OMgg67xcYs16ITaMOe6Op0u1D+gq7ILTSB/DL FQdpiltkvmAEgWIanzWiNeydwbuD0aYpWwjtKgHSWO2+a1IMCM/L2d/EDsMDVqiR/t2A Dr4vo7CV/Fw3dsrFiU//gjBLuMSUaBhq8lVdNQAtdZY1PTDlbLXocFdQ0S6bxFniWug3 JssnaOmXDTxnsZ7//pEfNyN7VOKN1Tmeke8pl+mCHHEZ5Qa9IcHIRRtY9bPIi/qbv8Zm XyXzgURy4XykbyrKYNDGCVpAz3iq+XNE3u0910/h/s0G2OWeoqOMatHPvm/cFMZvW8ps LJIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747775760; x=1748380560; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=0Vcim2IrvThidRodNsg/OfOdq2fd5gLucgy52LkkAJU=; b=rxX9/UnqhCGvRjuEXI820FiczbvUVxMogjDcLYYJ6taV8/w8E/LmrwNki4cLPK6Wo9 /4x7pcgNTQ0h9K9VWq989Eel4fCm1CCrDCJo/cv9YymlJWeiMV6w0dnO7Z0urZrqrTKs P0/lO8ySGGlTewZDyQv47zBEX/0v6iPH3F/6VipJ7B/1jc5xoEOStdxoXwOTa0ja5Mkg AT0yJ6c6HlUn5hVGfSTm1fVd5iZ2pdQylEYbXW7KR6MPFVDPgJknahcy3Pvz5K6iixgc ccN0Ej+9c8cqjF4mr7XdNYjyzlgHrjsr4b9I2iOXk3ImqlGm6kZrqtr9hqsGpEWMkpMs y4sQ== X-Forwarded-Encrypted: i=1; AJvYcCULbVC+XFhDC7DkOqxk4ftwoJkSgCzjyJL2GIg4wlBgdJjfc08sgptBpYo+c6ShjWzIb7jCkyp+7hLbuak=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6bu70eJvHDWS0smyPok0+9T1U2QBPNw8KICDVJRdbO1TMGLvg C9HvBakyJI/n1zpTNWU85geG9xwbDs53aACm+0aqDU6j74ic/VBezYT0aDOJNPZ75w== X-Gm-Gg: ASbGncu8ix5NNMuO//fnLbY4Frt8TGVIbwWVCuQSxYvp/6Q/oq867gAMzZ6kk/BQHGU MDkq9d/qasygKvs9/VowKMsT2LwMHM9bojwN4ttDUE/vrp/Afk0tg8jLEDDSBOdCTLgWVFPnnUn YAba2ZhtnCXtHqzxJeIn2JftvTFcE8jOmXmA7UA6tSxLwAV734K+0zGddxEik+P0O1320rtWWrF Kbbh3T2cds3Vc4XggbNFaAHeZG2PKEGiZ3nE7sRykFuHl7fxA3tkJ8xyFffa6wBFkEvQ6Yzi9aQ AQwad0ZuOvmbHAV/psQIfrQMt53YZ6HF+tmBknzBdbWuWhZp52+bsBSkmn7Gy0k44YL8oH/IEBx UqiPPzFGxlEs6pTW7IMWUjdeMtwoaxjY= X-Google-Smtp-Source: AGHT+IGXRcWfO4AHv0ErYu9MQe8pxWB5OkTwD4jggVmmRyicMFT0cpUlaxE7iaZV/7atuSeHLh1gYg== X-Received: by 2002:ad4:5e8f:0:b0:6d8:a8e1:b57b with SMTP id 6a1803df08f44-6f8b0873ba6mr330435226d6.36.1747775760552; Tue, 20 May 2025 14:16:00 -0700 (PDT) Received: from localhost (pool-71-126-255-178.bstnma.fios.verizon.net. [71.126.255.178]) by smtp.gmail.com with UTF8SMTPSA id 6a1803df08f44-6f8b0883b93sm76456226d6.14.2025.05.20.14.15.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 May 2025 14:15:59 -0700 (PDT) Date: Tue, 20 May 2025 17:15:59 -0400 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20250520_1533/pstg-lib:20250520_1521/pstg-pwork:20250520_1533 From: Paul Moore To: Li Li , dualli@google.com, corbet@lwn.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, donald.hunter@gmail.com, gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com, maco@android.com, joel@joelfernandes.org, brauner@kernel.org, cmllamas@google.com, surenb@google.com, omosnace@redhat.com, shuah@kernel.org, arnd@arndb.de, masahiroy@kernel.org, bagasdotme@gmail.com, horms@kernel.org, tweek@google.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, netdev@vger.kernel.org, selinux@vger.kernel.org, linux-security-module@vger.kernel.org, hridya@google.com Cc: smoreland@google.com, ynaffit@google.com, kernel-team@android.com Subject: Re: [PATCH v17 1/3] lsm, selinux: Add setup_report permission to binder References: <20250417002005.2306284-2-dualli@chromium.org> In-Reply-To: <20250417002005.2306284-2-dualli@chromium.org> On Apr 16, 2025 Li Li wrote: > > Introduce a new permission "setup_report" to the "binder" class. > This persmission controls the ability to set up the binder generic > netlink driver to report certain binder transactions. > > Signed-off-by: Thiébaud Weksteen > Signed-off-by: Li Li > --- > include/linux/lsm_hook_defs.h | 1 + > include/linux/security.h | 6 ++++++ > security/security.c | 13 +++++++++++++ > security/selinux/hooks.c | 7 +++++++ > security/selinux/include/classmap.h | 3 ++- > 5 files changed, 29 insertions(+), 1 deletion(-) When possible, it is helpful to include at least one caller in the patch which adds a new LSM hook as it helps put the hook in context. With that in mind, I think it would be best to reorder this patchset so that patch 2/3 comes first and this patch comes second, with this patch including the change to binder_nl_report_setup_doit() which adds the call to the new LSM hook. -- paul-moore.com