mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Walter-ZH Wu (吳祖寰)" <Walter-ZH.Wu@mediatek.com>
To: David Gow <davidgow@google.com>,
	"trishalfonso@google.com" <trishalfonso@google.com>,
	"brendanhiggins@google.com" <brendanhiggins@google.com>,
	"aryabinin@virtuozzo.com" <aryabinin@virtuozzo.com>,
	"dvyukov@google.com" <dvyukov@google.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"juri.lelli@redhat.com" <juri.lelli@redhat.com>,
	"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kunit-dev@googlegroups.com" <kunit-dev@googlegroups.com>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	"Andrey Konovalov" <andreyknvl@google.com>
Subject: RE: [PATCH v6 2/5] KUnit: KASAN Integration
Date: Mon, 20 Apr 2020 05:43:40 +0000	[thread overview]
Message-ID: <eb68aacaf65b4e37962f1b746d3e7c5c@mtkmbs06n2.mediatek.inc> (raw)
In-Reply-To: <20200418031833.234942-3-davidgow@google.com>

Hi David,

	start_report(&flags);
 	pr_err("BUG: KASAN: double-free or invalid-free in %pS\n", (void *)ip);
 	print_tags(tag, object);
@@ -486,6 +513,14 @@ void __kasan_report(unsigned long addr, size_t size, bool is_write, unsigned lon
 	void *untagged_addr;
 	unsigned long flags;
 
+	if (likely(!report_enabled()))
+		return;

kasan_report() already has the test expression, it should not need duplicating if statement.


Walter

+
+#if IS_ENABLED(CONFIG_KUNIT)
+	if (current->kunit_test)
+		kasan_update_kunit_status(current->kunit_test);
+#endif /* IS_ENABLED(CONFIG_KUNIT) */
+
 	disable_trace_on_warning();
 
 	tagged_addr = (void *)addr;
--
2.26.1.301.g55bc3eb7cb9-goog

--
You received this message because you are subscribed to the Google Groups "kasan-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20200418031833.234942-3-davidgow%40google.com.

  reply	other threads:[~2020-04-20  5:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-18  3:18 [PATCH v6 0/5] KUnit-KASAN Integration David Gow
2020-04-18  3:18 ` [PATCH v6 1/5] Add KUnit Struct to Current Task David Gow
2020-04-18  3:18 ` [PATCH v6 2/5] KUnit: KASAN Integration David Gow
2020-04-20  5:43   ` Walter-ZH Wu (吳祖寰) [this message]
2020-04-18  3:18 ` [PATCH v6 3/5] KASAN: Port KASAN Tests to KUnit David Gow
2020-04-21 15:38   ` Andrey Konovalov
2020-04-18  3:18 ` [PATCH v6 4/5] KASAN: Testing Documentation David Gow
2020-04-21 15:37   ` Andrey Konovalov
2020-04-18  3:18 ` [PATCH v6 5/5] mm: kasan: Do not panic if both panic_on_warn and kasan_multishot set David Gow
2020-04-21 15:39   ` Andrey Konovalov
2020-04-18 15:28 ` [PATCH v6 0/5] KUnit-KASAN Integration Alan Maguire
2020-04-24  6:36   ` David Gow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb68aacaf65b4e37962f1b746d3e7c5c@mtkmbs06n2.mediatek.inc \
    --to=walter-zh.wu@mediatek.com \
    --cc=andreyknvl@google.com \
    --cc=aryabinin@virtuozzo.com \
    --cc=brendanhiggins@google.com \
    --cc=davidgow@google.com \
    --cc=dvyukov@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=trishalfonso@google.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®