From: Adrian Hunter <adrian.hunter@intel.com>
To: Artem Shimko <a.shimko.dev@gmail.com>
Cc: <andriy.shevchenko@intel.com>, <ulfh@kernel.org>,
<p.zabel@pengutronix.de>, <linux-mmc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] mmc: sdhci-of-dwcmshc: improve delay and sleep handling with fsleep()
Date: Fri, 22 May 2026 10:11:22 +0300 [thread overview]
Message-ID: <eb7237d7-b148-4ceb-8c6f-b4af9786064c@intel.com> (raw)
In-Reply-To: <CAOPX744+iK+Okhd5rS1uXaFgCcA7CndYeJ38gB2Mv1T=TQG7CQ@mail.gmail.com>
On 22/05/2026 09:58, Artem Shimko wrote:
> Hi Adrian,
>
> On Fri, May 22, 2026 at 9:01 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
>>
>> On 21/05/2026 11:35, Artem Shimko wrote:
>>> Replace usleep_range() and udelay(1) (for consistency) with fsleep()
>>> in several places to follow kernel documentation recommendation [1]
>>> of using fsleep() for delays in non-atomic contexts.
>>
>> The usleep_range()'s have presumably been chosen and validated.
>> They cannot be arbitrarily changed. And then there is no point
>> changing udelay() to fsleep(). Please let's just leave this.
>
> Sure.
>
> Should I send v3 without the commit?
Sure
next prev parent reply other threads:[~2026-05-22 7:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 8:35 [PATCH v2 0/3] mmc: sdhci-of-dwcmshc: minor cleanups Artem Shimko
2026-05-21 8:35 ` [PATCH v2 1/3] mmc: sdhci-of-dwcmshc: improve delay and sleep handling with fsleep() Artem Shimko
2026-05-22 6:01 ` Adrian Hunter
2026-05-22 6:58 ` Artem Shimko
2026-05-22 7:11 ` Adrian Hunter [this message]
2026-05-21 8:35 ` [PATCH v2 2/3] mmc: sdhci-of-dwcmshc: remove redundant IS_ERR() check Artem Shimko
2026-05-21 8:35 ` [PATCH v2 3/3] mmc: sdhci-of-dwcmshc: use dev_err_probe() to simplify error paths Artem Shimko
2026-05-22 6:17 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb7237d7-b148-4ceb-8c6f-b4af9786064c@intel.com \
--to=adrian.hunter@intel.com \
--cc=a.shimko.dev@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®