From: Yu Kuai <yukuai1@huaweicloud.com>
To: Yu Kuai <yukuai1@huaweicloud.com>,
axboe@kernel.dk, tj@kernel.org, mkoutny@suse.com,
ming.lei@redhat.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, yi.zhang@huawei.com,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH v9 0/4] blk-throttle bugfix
Date: Wed, 31 Aug 2022 19:31:58 +0800 [thread overview]
Message-ID: <eb7246b4-2cfe-a110-1e45-39f970e5441e@huaweicloud.com> (raw)
In-Reply-To: <20220829022240.3348319-1-yukuai1@huaweicloud.com>
Hi, Jens!
在 2022/08/29 10:22, Yu Kuai 写道:
> From: Yu Kuai <yukuai3@huawei.com>
>
> Changes in v9:
> - renaming the flag BIO_THROTTLED to BIO_BPS_THROTTLED, and always
> apply iops limit in path 1;
> - add tag for patch 4
> Changes in v8:
> - use a new solution in patch 1
> - move cleanups to a separate patchset
> - rename bytes/io_skipped to carryover_bytes/ios in patch 4
> Changes in v7:
> - add patch 5 to improve handling of re-entered bio for bps limit
> - as suggested by Tejun, add some comments
> - sdd some Acked tag by Tejun
> Changes in v6:
> - rename parameter in patch 3
> - add comments and reviewed tag for patch 4
> Changes in v5:
> - add comments in patch 4
> - clear bytes/io_skipped in throtl_start_new_slice_with_credit() in
> patch 4
> - and cleanup patches 5-8
> Changes in v4:
> - add reviewed-by tag for patch 1
> - add patch 2,3
> - use a different way to fix io hung in patch 4
> Changes in v3:
> - fix a check in patch 1
> - fix link err in patch 2 on 32-bit platform
> - handle overflow in patch 2
> Changes in v2:
> - use a new solution suggested by Ming
> - change the title of patch 1
> - add patch 2
>
> Patch 1 fix that blk-throttle can't work if multiple bios are throttle.
> Patch 2 fix overflow while calculating wait time.
> Patch 3,4 fix io hung due to configuration updates.
>
> Previous version:
> v1: https://lore.kernel.org/all/20220517134909.2910251-1-yukuai3@huawei.com/
> v2: https://lore.kernel.org/all/20220518072751.1188163-1-yukuai3@huawei.com/
> v3: https://lore.kernel.org/all/20220519085811.879097-1-yukuai3@huawei.com/
> v4: https://lore.kernel.org/all/20220523082633.2324980-1-yukuai3@huawei.com/
> v5: https://lore.kernel.org/all/20220528064330.3471000-1-yukuai3@huawei.com/
> v6: https://lore.kernel.org/all/20220701093441.885741-1-yukuai1@huaweicloud.com/
> v7: https://lore.kernel.org/all/20220802140415.2960284-1-yukuai1@huaweicloud.com/
> v8: https://lore.kernel.org/all/20220823033130.874230-1-yukuai1@huaweicloud.com/
>
> Yu Kuai (4):
> blk-throttle: fix that io throttle can only work for single bio
> blk-throttle: prevent overflow while calculating wait time
> blk-throttle: factor out code to calculate ios/bytes_allowed
> blk-throttle: fix io hung due to configuration updates
Can you apply this patchset now?
Thanks,
Kuai
>
> block/bio.c | 2 -
> block/blk-throttle.c | 137 +++++++++++++++++++++++++-------------
> block/blk-throttle.h | 11 ++-
> include/linux/bio.h | 2 +-
> include/linux/blk_types.h | 2 +-
> 5 files changed, 104 insertions(+), 50 deletions(-)
>
next prev parent reply other threads:[~2022-08-31 11:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 2:22 Yu Kuai
2022-08-29 2:22 ` [PATCH v9 1/4] blk-throttle: fix that io throttle can only work for single bio Yu Kuai
2022-08-29 4:03 ` Tejun Heo
2022-08-29 2:22 ` [PATCH v9 2/4] blk-throttle: prevent overflow while calculating wait time Yu Kuai
2022-08-29 2:22 ` [PATCH v9 3/4] blk-throttle: factor out code to calculate ios/bytes_allowed Yu Kuai
2022-08-29 2:22 ` [PATCH v9 4/4] blk-throttle: fix io hung due to configuration updates Yu Kuai
2022-08-31 11:31 ` Yu Kuai [this message]
2022-09-12 6:13 ` [PATCH v9 0/4] blk-throttle bugfix Yu Kuai
2022-09-12 6:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb7246b4-2cfe-a110-1e45-39f970e5441e@huaweicloud.com \
--to=yukuai1@huaweicloud.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®