mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Heidelberg <david@ixit.cz>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	"Rob Herring (Arm)" <robh@kernel.org>
Cc: phone-devel@vger.kernel.org,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	dri-devel@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Casey Connolly <casey.connolly@linaro.org>,
	linux-arm-msm@vger.kernel.org, phodina@protonmail.com,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	David Airlie <airlied@gmail.com>,
	linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
	Simona Vetter <simona@ffwll.ch>
Subject: Re: [PATCH v3 2/8] dt-bindings: panel: sw43408: adjust to reflect the DDIC and panel used
Date: Tue, 18 Nov 2025 13:34:15 +0100	[thread overview]
Message-ID: <eb75f5c7-18ef-4eda-a28f-6efde9df03e4@ixit.cz> (raw)
In-Reply-To: <715ea6b0-a8d7-4ecf-b0c7-f4469c94b969@oss.qualcomm.com>

yup, saw, consider it solved in next version! :)

Also hopefully I'll fire ut the dt_bindings_check and dtbs_check in our CI.

David

On 18/11/2025 13:33, Konrad Dybcio wrote:
> On 11/18/25 1:29 PM, Rob Herring (Arm) wrote:
>>
>> On Tue, 18 Nov 2025 12:30:37 +0100, David Heidelberg wrote:
>>> Add compatible for used LG panel.
>>> SW43408 is not panel, but DDIC. The panel itself is the
>>> LG LH546WF1-ED01, so introduce combined compatible for it.
>>>
>>> Signed-off-by: David Heidelberg <david@ixit.cz>
>>> ---
>>>   .../devicetree/bindings/display/panel/lg,sw43408.yaml         | 11 ++++++++---
>>>   1 file changed, 8 insertions(+), 3 deletions(-)
>>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/lg,sw43408.example.dtb: panel@0 (lg,sw43408): compatible:0: 'lg,sw43408' is not one of ['lg,sw43408-lh546wf1-ed01']
>> 	from schema $id: http://devicetree.org/schemas/display/panel/lg,sw43408.yaml
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/lg,sw43408.example.dtb: panel@0 (lg,sw43408): compatible: ['lg,sw43408'] is too short
> 
> You got this error because you didn't fix the example DT (which would be
> validated with `make dt_binding_check`
> 
> Konrad

-- 
David Heidelberg


  reply	other threads:[~2025-11-18 12:34 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18 11:30 [PATCH v3 0/8] Add support for Pixel 3 and Pixel 3 XL David Heidelberg via B4 Relay
2025-11-18 11:30 ` [PATCH v3 1/8] dt-bindings: arm: qcom: Add Pixel 3 and " David Heidelberg via B4 Relay
2025-11-19  7:16   ` Krzysztof Kozlowski
2025-11-18 11:30 ` [PATCH v3 2/8] dt-bindings: panel: sw43408: adjust to reflect the DDIC and panel used David Heidelberg via B4 Relay
2025-11-18 12:29   ` Rob Herring (Arm)
2025-11-18 12:33     ` Konrad Dybcio
2025-11-18 12:34       ` David Heidelberg [this message]
2025-11-18 11:30 ` [PATCH v3 3/8] drm/panel: sw43408: Introduce LH546WF1-ED01 panel compatible David Heidelberg via B4 Relay
2025-11-19  7:36   ` Dmitry Baryshkov
2025-11-19 10:20     ` David Heidelberg
2025-11-18 11:30 ` [PATCH v3 4/8] drm/panel: sw43408: Introduce disable/enable functions David Heidelberg via B4 Relay
2025-11-19  7:28   ` Dmitry Baryshkov
2025-11-18 11:30 ` [PATCH v3 5/8] drm/panel: sw43408: Remove manual invocation of unprepare at remove David Heidelberg via B4 Relay
2025-11-19  7:29   ` Dmitry Baryshkov
2025-11-18 11:30 ` [PATCH v3 6/8] drm/panel: sw43408: Switch to devm_regulator_bulk_get_const David Heidelberg via B4 Relay
2025-11-19  7:29   ` Dmitry Baryshkov
2025-11-18 11:30 ` [PATCH v3 7/8] drm/panel: sw43408: Improve wording when reset-gpios aren't available David Heidelberg via B4 Relay
2025-11-19  7:30   ` Dmitry Baryshkov
2025-11-18 11:30 ` [PATCH v3 8/8] arm64: dts: qcom: Add support for Pixel 3 and Pixel 3 XL David Heidelberg via B4 Relay
2025-11-18 12:32   ` Konrad Dybcio
2025-11-18 13:31     ` David Heidelberg
2025-11-18 13:41       ` Konrad Dybcio
2025-11-20  1:04         ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb75f5c7-18ef-4eda-a28f-6efde9df03e4@ixit.cz \
    --to=david@ixit.cz \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=casey.connolly@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=phodina@protonmail.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=sumit.semwal@linaro.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®