From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB85CC433EF for ; Thu, 16 Sep 2021 09:43:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CC1B61185 for ; Thu, 16 Sep 2021 09:43:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236093AbhIPJpM (ORCPT ); Thu, 16 Sep 2021 05:45:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235633AbhIPJpI (ORCPT ); Thu, 16 Sep 2021 05:45:08 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A422FC061768 for ; Thu, 16 Sep 2021 02:43:48 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id u18so6703393wrg.5 for ; Thu, 16 Sep 2021 02:43:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent-com.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vMyxzYnGLIXigftdBAqV9yMGr7SyFbi9TFF15l4WZ8o=; b=bGEKNYVntYkua+rlEKSZTUjCc9reSlmQjIYaXOwPpunsNqyatW0HePiZQgk83Qm5eC 7bhZMvpL9IWRHFrSHiYaJ3wcT5tUjvLzfNOU8nHOcwW+XdNCMGNiwSk/iEZ0Pyt87h5v HumjrYrr+NeX1HYiP7SQysd/c3Zk85fsxEh9j14c2U0rFy4sLMRmaImCI717udy0++VV EFT1uwTcuueI6vJFp2JYkcqVshbWkZe2/l889e/a2FPgE6l10mCfhKzSqg0OQOntrRbW e9tYErYSA831aPfexhrVU+9jEf/m+C6eD85mEKFq8zepcPJwROvWM1KwvC4pfiUy+FnR rO3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vMyxzYnGLIXigftdBAqV9yMGr7SyFbi9TFF15l4WZ8o=; b=GuPGKbnqBscmGom76vTIwp+3+DYWGzQLu3y/pBvxbZRV/LUaoHhaH6CXjpAWTy8Q8F 2j3MwCS2MxaAb4J5VP3FcPenzAs6I3tBl7O0MvgN/odb9/YqISCBJiwWXxPAikCET+qj KDArSbh3E9DXd+NQRFMT2IiwfJirhsc+2mrdCWJCXBlvmcyusxTw2r4BSOLan8CUtGwN j3gABT3GKCDqybpP/bT0KviOMejvshPw+eBKPNkwagJt/7yuHpUfjCVlbhJmuMR/Ex9e mqP8ZpjdJFooYe6zAOkfY7GMej069spZPrLqd7eE96RzS8vjcN+pkdIJedg2uVIHTymm xPjw== X-Gm-Message-State: AOAM533Iar4v1ggBLkRutMsgdfOhJuCSYnXcpmboO3ZtC5+VA4D2v55y wCQSGO6OVrYheBoOP0kq5Yoxcg== X-Google-Smtp-Source: ABdhPJyyG1PVDSRfmks+2rkllu2IivPebbvtIJiooKKqGJWD7xMwdgVKf6MqnqIWLX7kfhF6PQm+6Q== X-Received: by 2002:a5d:6da9:: with SMTP id u9mr4937429wrs.58.1631785426735; Thu, 16 Sep 2021 02:43:46 -0700 (PDT) Received: from [192.168.1.8] ([149.86.87.95]) by smtp.gmail.com with ESMTPSA id l19sm2573480wrc.16.2021.09.16.02.43.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Sep 2021 02:43:46 -0700 (PDT) Subject: Re: [PATCH 08/24] tools: bpftool: update bpftool-prog.rst reference To: Mauro Carvalho Chehab , Linux Doc Mailing List , Jonathan Corbet Cc: "David S. Miller" , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , David Beckett , Jakub Kicinski , John Fastabend , KP Singh , Martin KaFai Lau , Shuah Khan , Song Liu , Yonghong Song , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org References: From: Quentin Monnet Message-ID: Date: Thu, 16 Sep 2021 10:43:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2021-09-16 11:14 UTC+0200 ~ Mauro Carvalho Chehab > The file name: Documentation/bpftool-prog.rst > should be, instead: tools/bpf/bpftool/Documentation/bpftool-prog.rst. > > Update its cross-reference accordingly. > > Fixes: a2b5944fb4e0 ("selftests/bpf: Check consistency between bpftool source, doc, completion") > Fixes: ff69c21a85a4 ("tools: bpftool: add documentation") Hi, How is this a fix for the commit that added the documentation in bpftool? > Signed-off-by: Mauro Carvalho Chehab > --- > tools/testing/selftests/bpf/test_bpftool_synctypes.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/test_bpftool_synctypes.py b/tools/testing/selftests/bpf/test_bpftool_synctypes.py > index be54b7335a76..27a2c369a798 100755 > --- a/tools/testing/selftests/bpf/test_bpftool_synctypes.py > +++ b/tools/testing/selftests/bpf/test_bpftool_synctypes.py > @@ -374,7 +374,7 @@ class ManProgExtractor(ManPageExtractor): > """ > An extractor for bpftool-prog.rst. > """ > - filename = os.path.join(BPFTOOL_DIR, 'Documentation/bpftool-prog.rst') > + filename = os.path.join(BPFTOOL_DIR, 'tools/bpf/bpftool/Documentation/bpftool-prog.rst') > > def get_attach_types(self): > return self.get_rst_list('ATTACH_TYPE') > No I don't believe it should. BPFTOOL_DIR already contains 'tools/bpf/bpftool' and the os.path.join() concatenates the two path fragments. Where is this suggestion coming from? Did you face an issue with the script? Same comment applies for the next two patches. Quentin