From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCC5B3D524C for ; Fri, 3 Jul 2026 15:07:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783091259; cv=none; b=W/u91lG0q0jf0zpZQohOP2xzdQLSEYDcqX1ym92XP/QoJixo11mK1wHv9K5KBSpDcpe/UsPqqtN1+67+9r4Jci3h3FkkEooQG0yTWwT/97HLNEn8sjbfLbWPxvtj+jAbvcADtNSMhf8Q2EsWvKOm4u+RYiYkokYK1qp3AEljlUw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783091259; c=relaxed/simple; bh=mgjyxZoiOvFijt/d+PC0DtD/Alk5U8ztsi8AqhLZuZo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lT7QHwgOkmyk0M/R07dGaq08OOsCeYtoo+ydAHGNVCab+9684evufMAY/SUnbfh9AqA0f2Ovld6Q+TsLPmqiGvNHqfEAzjk1Rwp1yvXOxEHhnolj5TsaElHS8AoMcllMObFaecEg4nTVS4bqPvPRPQJBZHiVG2VaOGDktel8cWQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=P5vwjgPB; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=B/hPGg30; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P5vwjgPB"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="B/hPGg30" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783091256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ufmoYIO+8FVkXj7I+/+r0HlaIjqkZ37cLPCzcjFGBsk=; b=P5vwjgPBojeX5Bsh5R7Pd6z8sQGAlxycRLohUM3RP0DkDauKWpiMZIcLKcDyS9fuUfhJhB LadJktNxFiE0U0uk9jpVqLAxveJcLGgI7qhZTAauNiNHTzupECaYTxk+d1o1uOuAcxwx/V CgrhFjKRJsQV2wBo3FTomXeLVxjkj0Y= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-117-zBqvskSKNuqJFMyXyUwBzA-1; Fri, 03 Jul 2026 11:07:35 -0400 X-MC-Unique: zBqvskSKNuqJFMyXyUwBzA-1 X-Mimecast-MFC-AGG-ID: zBqvskSKNuqJFMyXyUwBzA_1783091254 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-493c588b6f2so5037135e9.0 for ; Fri, 03 Jul 2026 08:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783091254; x=1783696054; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ufmoYIO+8FVkXj7I+/+r0HlaIjqkZ37cLPCzcjFGBsk=; b=B/hPGg30VI1IBI3VDfScRK027txAkZD2w3apaKDixLY3A3RoVpQttupKu9mzFiJh9n onxMm20p5xYD7pEQwnXwLXTF0Thrmq2q7t4GKy7bK+VhBrgCKA5n5mUdBuwYuai/477Y WJFj/pKuxSJDdMninWWJT9YwoLXUlCaXsT09I2pGAzxncesaLNBED0xUQXPw6dASOCl2 HZ3br5aqpnJV4LcYPBaHguWrHPsedTzWL+cStLUefc46k6V0iYNJgO1u77241GnsrwUn aXlxp0DwpsSHoeTmsfRkEsMgz/dyNiIWFUE9WYl2XeABYwNSVHMvPvZDsvMQoQqbQhUk jbgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783091254; x=1783696054; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ufmoYIO+8FVkXj7I+/+r0HlaIjqkZ37cLPCzcjFGBsk=; b=dpwX1gIOd9ASAlabdOAnra6fF0+svqFeNboSOpqiRH5DQh1C7AAmRfp0kUFTQnVI/j LnnQDbJsHm3OhbAA/QSpnOjmWLaY3NqNc64XNpYpX6q2hDk9QFwzZ/GOqFZkmBUJQPfx GZEwme6sNw7YlK1iH2N8uq/J8uj4OSWdo8EqFRrLv9Q65wrhI48Qx90v13u4Pvcd9JDg A6hcWo1nG6T6P2bMbv8t3NnOQhXYIlC9TCP/X2Z/BpxYNq5zGgNMCt8RmbGcJNsXIelv mAiIb5xUBIaIJRsN4MlVfDoFz4o1mf2TMgqZA7TSM1CUS33ypYTjiWoqZnY9Rxv+wroZ r+Eg== X-Forwarded-Encrypted: i=1; AFNElJ9pQzKnWYyYZAgBZQWMC+14sNam3kiQbwlCT+sSqql+4ULRQl2Q6iH+2BnDgx2g3Y62wV70Op6p0nn+y6g=@vger.kernel.org X-Gm-Message-State: AOJu0YzhFgXhfrEXQoDpKHdWeWeN5n6DJhzfYrM3B4vTDcct90FkIBgT RH1qk5SGpb79qvX6fvjy0y6lC14N5EDM7P/Bq0+8WRleYKYLHIHXqCervUckQUZ7mARNgsJ43tn CGlQetZ3zKrgJkOLv6vLo5PwycQzQ52qtTwYQVIUEOk/lEZU5UpAeczXZkHylje+mlg== X-Gm-Gg: AfdE7cklOMygv75bwzMVLrrvQgKPRIVviK6ChDYMZ9c0jPo+IOXafCo1FsS7QOX8ZJx /9jT/Zs8Pi60lrODOdFdQGvcQBJ+RGm2QiSkV5hpdutDcQKYB6KAWsS8WV6tf84L6thN2XirXl+ VypYSnUqIRvJ3a6uesrcL9dAaCE97MAjfZ+8RdSh+6PM8EXY1h2sqMaKWlOpm9UnO8DBM5QSgkY 4XJ+xYcKVb6KETRnkq9Cy2tkqO0614IXkeE6jqeugIRmkcQ/FL+/oNDdmXyfSPpHt8oCELZE7FD a/+TLEulgZeEJALEnrkyvToFgdUomJG5OJxT+zBaGpuDvlmHfUyIR1HMNzvDGFR0D/bFb8QVtNE IUfa66fPOoBT1uUb77zbmOIzYAXbsQe99qV52ABpT9stg/MRiiWu3IpHLw98ZhaPrxs8NQOwYn0 1V9Vg= X-Received: by 2002:a05:600c:22da:b0:493:b55f:bca2 with SMTP id 5b1f17b1804b1-493d0f418famr2033645e9.34.1783091253956; Fri, 03 Jul 2026 08:07:33 -0700 (PDT) X-Received: by 2002:a05:600c:22da:b0:493:b55f:bca2 with SMTP id 5b1f17b1804b1-493d0f418famr2033285e9.34.1783091253473; Fri, 03 Jul 2026 08:07:33 -0700 (PDT) Received: from ?IPV6:2a01:e34:ecaf:77c0:40ac:89a3:9858:a68e? ([2a01:e34:ecaf:77c0:40ac:89a3:9858:a68e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493cfb6f199sm30527515e9.3.2026.07.03.08.07.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 08:07:32 -0700 (PDT) Message-ID: Date: Fri, 3 Jul 2026 17:07:31 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] 9p: fix privport option setting wrong RDMA field To: Stefano Garzarella , v9fs@lists.linux.dev Cc: Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , linux-kernel@vger.kernel.org, Eric Van Hensbergen , stable@vger.kernel.org References: <20260703102254.114446-1-sgarzare@redhat.com> Content-Language: en-US From: Eric Sandeen In-Reply-To: <20260703102254.114446-1-sgarzare@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/3/26 12:22 PM, Stefano Garzarella wrote: > From: Stefano Garzarella > > While reviewing a patch adding vsock transport to 9p, I noticed that > since commit 1f3e4142c0eb ("9p: convert to the new mount API"), the > Opt_privport case incorrectly sets rdma_opts->port instead of > rdma_opts->privport, so mounting with the privport option overwrites > the RDMA port number instead of enabling privileged port usage. > > Fixes: 1f3e4142c0eb ("9p: convert to the new mount API") > Cc: stable@vger.kernel.org > Cc: sandeen@redhat.com > Signed-off-by: Stefano Garzarella Ugh, sorry about that. Acked-by: Eric Sandeen > --- > fs/9p/v9fs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c > index 274c5157135d..f426cee37414 100644 > --- a/fs/9p/v9fs.c > +++ b/fs/9p/v9fs.c > @@ -406,7 +406,7 @@ int v9fs_parse_param(struct fs_context *fc, struct fs_parameter *param) > break; > case Opt_privport: > fd_opts->privport = true; > - rdma_opts->port = true; > + rdma_opts->privport = true; > break; > } >