From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1423445AbdEYIGz (ORCPT <rfc822;w@1wt.eu>);
        Thu, 25 May 2017 04:06:55 -0400
Received: from mail-lf0-f42.google.com ([209.85.215.42]:35274 "EHLO
        mail-lf0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S968844AbdEYIGv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 25 May 2017 04:06:51 -0400
Subject: Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device
To: Shawn Guo <shawnguo@kernel.org>
References: <20170522131010.3537-1-nikita.yoush@cogentembedded.com>
 <20170525070007.GU26102@dragon>
Cc: Sascha Hauer <kernel@pengutronix.de>, Stefan Agner <stefan@agner.ch>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
        Chris Healy <Chris.Healy@zii.aero>, Jeff White <Jeff.White@zii.aero>
From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Message-ID: <eb86f383-3c27-2276-6213-99c5143420f5@cogentembedded.com>
Date: Thu, 25 May 2017 11:06:47 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170525070007.GU26102@dragon>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> +&edma1 {
>> +	status = "okay";
>> +};
>> +
>> +&dspi2 {
> 
> Please keep these labelled nodes sort alphabetically.

Ok

>> +	bus-num = <1>;
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_dspi2>;
>> +	status = "okay";
> 
> We usually have 'status' line at the bottom of property list.

Ok

>> +	spi-num-chipselects = <2>;
>> +
>> +	hi8435@1 {
> 
> Node name should be something generic, while label can be specific
> model name.  The following form might be better.
> 
> 	hi8435: sensor@1

Ok

Although the same file, in lines nearby, has m25p128@0 and at93c46d@1.

Anyway let's delay this a bit, up to the reset polarity description
thing in hi8435 is resolved.

Nikita