From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751169AbdHZSdR (ORCPT ); Sat, 26 Aug 2017 14:33:17 -0400 Received: from mout.web.de ([212.227.17.11]:55889 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbdHZSdO (ORCPT ); Sat, 26 Aug 2017 14:33:14 -0400 To: linux-gpio@vger.kernel.org, Linus Walleij Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] pinctrl: Delete an error message for a failed memory allocation in two functions Message-ID: Date: Sat, 26 Aug 2017 20:33:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:g+z5s2WbvD7tqcMArByjQzcOnEoa/sjzr8U/xPTCjgMLbYduWqY lG3c6+xiUMRtnengWODHietAkgu+GgP86+E1gN9OntZcInB7pUXTCG0pBllE/da7PDk++Ky 1i8QCM56ZZiuN7sbof3Lff6fNNR6Ph7bdWtjD1cw9KENXG1C61Wn6Ya6ogKAxJrp5FTBXzr uTiyLQSZxzwn7+nlu13OA== X-UI-Out-Filterresults: notjunk:1;V01:K0:dl351TElTu0=:L6rFxYEsVWjx6Kdb4M5/5l qE1iRmjGAsxnTaAVFCIlgfWWAWPrVdIQnq8o/gX3lXAT6rhLruknKLPF2AsINlpo/18teWJGM TKOkD4vVmvcQ5is+ytH/jJuA2mpteshDysLN17yBwQPY8V+P3C3DsiEdN+01ECTAlBXjCep2G pWMxA2Mku60iS73Dp7mwl7VVFro2jhOIl3E0NfuCk27VzEp5cz1HFBssMUJ9AOlDA64GL74t4 ZmxIwfDuvkNtNYrEtMKk1iTfSm5Ba0ELBKhQCzV1eJsYIkPlHhx4bale91+DgRY8iteI2n/rU zgMTQXKklnepIi5kTgaaQ2OS7o07/9NYv359YGTrtYtd+ZapUfaYVWb5X4sQRInpNxuFsRf4Q CkwRgdLaWkmMBgr7So4SXh/iBPyW9fwy1/qokBqqn4JP02CVLXzs3icgIaS+3BOir9B7ZkpI6 Py+nviuwIVQNFFJ2lSODKtkVUvfcWh5zVay+adwV/f1Duzm91jT5iV6bc5n9C35T6QojHIyIG w/FrQkilVhzTe5MFtq4Ng8qlh7lwShgik8mt2yg4ErMnB+x25Txhn/aHDzvB/VVTRO5PAM3ks idLttOQj9AlFwy+V5uoFwlDLfMMC2ao84smE6mzmV48zDMh0/PTBErLTLE4nZbMq47u4ITDrS fgwkO356uyzfRFIX60NZv748xd6BiP8yAGSEkFtJj2qO3OgM10jZhfqrJcWaoQDey4Rh3uB25 OkwrnSRQdCajbwgTYCwdwL+2YOyf+NMq1KnGbf6BLBGn/mR01Wl/EWn126N1INSxOOijpiVkC /ITTnfyBM4kE/s5QEWswF7UGCUxBCcyXN2ACJMxARpzXOOJ+GM= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 26 Aug 2017 20:30:04 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pinctrl/devicetree.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/pinctrl/devicetree.c b/drivers/pinctrl/devicetree.c index 0e5c9f14a706..8ca8925b685d 100644 --- a/drivers/pinctrl/devicetree.c +++ b/drivers/pinctrl/devicetree.c @@ -83,7 +83,6 @@ static int dt_remember_or_free_map(struct pinctrl *p, const char *statename, /* Remember the converted mapping table entries */ dt_map = kzalloc(sizeof(*dt_map), GFP_KERNEL); if (!dt_map) { - dev_err(p->dev, "failed to alloc struct pinctrl_dt_map\n"); dt_free_map(pctldev, map, num_maps); return -ENOMEM; } @@ -158,10 +157,8 @@ static int dt_remember_dummy_state(struct pinctrl *p, const char *statename) struct pinctrl_map *map; map = kzalloc(sizeof(*map), GFP_KERNEL); - if (!map) { - dev_err(p->dev, "failed to alloc struct pinctrl_map\n"); + if (!map) return -ENOMEM; - } /* There is no pctldev for PIN_MAP_TYPE_DUMMY_STATE */ map->type = PIN_MAP_TYPE_DUMMY_STATE; -- 2.14.0