From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161199AbcIZHca (ORCPT ); Mon, 26 Sep 2016 03:32:30 -0400 Received: from mga04.intel.com ([192.55.52.120]:60483 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034803AbcIZHc2 (ORCPT ); Mon, 26 Sep 2016 03:32:28 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,398,1470726000"; d="scan'208";a="1036490700" Subject: Re: [PATCH 08/16] perf tools: Increase debug level of SDT debug messages To: Masami Hiramatsu References: <1474641528-18776-1-git-send-email-adrian.hunter@intel.com> <1474641528-18776-9-git-send-email-adrian.hunter@intel.com> <20160924091535.0be0f371b3242b5552ee2d49@kernel.org> Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Mathieu Poirier , linux-kernel@vger.kernel.org From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Mon, 26 Sep 2016 10:27:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160924091535.0be0f371b3242b5552ee2d49@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/09/16 03:15, Masami Hiramatsu wrote: > On Fri, 23 Sep 2016 17:38:40 +0300 > Adrian Hunter wrote: > >> Two SDT debug messages can occur for every DSO which is too noisy. >> Consequently, increase debug level of SDT messages. > > OK, but why "4" would you choose? 2 is used for displaying the event attributes, so it needs to be 3 or 4. I chose 4 because of the large number of messages and that the same messages appear every time. > > Thanks, > >> >> Signed-off-by: Adrian Hunter >> --- >> tools/perf/util/build-id.c | 4 ++-- >> tools/perf/util/probe-file.c | 2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c >> index 5651f3c12f93..e528c40739cc 100644 >> --- a/tools/perf/util/build-id.c >> +++ b/tools/perf/util/build-id.c >> @@ -620,7 +620,7 @@ static int build_id_cache__add_sdt_cache(const char *sbuild_id, >> >> ret = probe_cache__scan_sdt(cache, realname); >> if (ret >= 0) { >> - pr_debug("Found %d SDTs in %s\n", ret, realname); >> + pr_debug4("Found %d SDTs in %s\n", ret, realname); >> if (probe_cache__commit(cache) < 0) >> ret = -1; >> } >> @@ -691,7 +691,7 @@ int build_id_cache__add_s(const char *sbuild_id, const char *name, >> >> /* Update SDT cache : error is just warned */ >> if (build_id_cache__add_sdt_cache(sbuild_id, realname) < 0) >> - pr_debug("Failed to update/scan SDT cache for %s\n", realname); >> + pr_debug4("Failed to update/scan SDT cache for %s\n", realname); >> >> out_free: >> if (!is_kallsyms) >> diff --git a/tools/perf/util/probe-file.c b/tools/perf/util/probe-file.c >> index 6f931e442f14..436b64731f65 100644 >> --- a/tools/perf/util/probe-file.c >> +++ b/tools/perf/util/probe-file.c >> @@ -699,7 +699,7 @@ int probe_cache__scan_sdt(struct probe_cache *pcache, const char *pathname) >> INIT_LIST_HEAD(&sdtlist); >> ret = get_sdt_note_list(&sdtlist, pathname); >> if (ret < 0) { >> - pr_debug("Failed to get sdt note: %d\n", ret); >> + pr_debug4("Failed to get sdt note: %d\n", ret); >> return ret; >> } >> list_for_each_entry(note, &sdtlist, note_list) { >> -- >> 1.9.1 >> > >