From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0313F3E024F for ; Thu, 23 Jul 2026 09:20:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784798458; cv=none; b=UE9qOMq/8q+StjkDDWbv2WmP3GrxD3C2EWiaY60I6W/+HhPSzIwx89cCIK6XPSOQQJGRy6kk39eTk2a8xFr1fN+j59gzCsWhsagny1uc6kaDr5bJR0PpVDPSZRm4iB1JDGc4UDxmymL0aGdQzaicxZJV40rcnsOdp7yzq6KG6sA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784798458; c=relaxed/simple; bh=Ua5UAJT40e/0GEzjCwqx4EwOBnaqa4Dvcx7XveV6T1A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LAacJ/DzKLsgeOxrIropURqGTVA1p7CFpXHj/kExqT5fav0GD22V5Y/DV6bHD1uW9TsAemHxRman/jlAA2M2rZZpDDVm7V9Oy++wVGD8WrkbNkju7wSY7Cjer3ppkpaFRwXwRu3Gu9CR7XrDHcaeli8tMuw2hPnkoI7zkgGNTiM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RDocfRy2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KBNnoh1O; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RDocfRy2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KBNnoh1O" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66N8qXCm3648575 for ; Thu, 23 Jul 2026 09:20:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lz7QXf+iBwT8QlIH9Oun8AGxaHA1wq8IUAehzHZTWo0=; b=RDocfRy2yCHEjccW RZsU+gVIqtmV1JA9knlL2qUoDyjx1MFmf4ZpdDgtcCPjCkD41+MaINpGGNqlssH2 +RmCqQkCtNsfKC32m93P87q3wDV+LDgGF+Z0o4QaWHMltGFdL21fLRpZDlzauFXC ITws8oIBPGRDOjpHlJXTDMGYhCkRRLnR7REkcGMvmQ5r3mayMxGo9gP2+fL8cgmV Z1dSeukTeYYt02iGWv623uus3oOA3IZwhBqSbmORWl0Fu2ucPZ/owlrRo6jRBkjz Kv/Qggw2S/sze037UCDDCVLHPys0Bk3UshoaJP5hWMv2/77YZzunLT9ZY95mpTCD vFMC6g== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fk6c7j8ta-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Jul 2026 09:20:53 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ce7dff6253so2907805ad.1 for ; Thu, 23 Jul 2026 02:20:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784798453; x=1785403253; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lz7QXf+iBwT8QlIH9Oun8AGxaHA1wq8IUAehzHZTWo0=; b=KBNnoh1OepJ51gFeGzV51v3Pm/20EQBNNXnaRe2943hktt0R3cCRamdx+NyAWOtQTl tWAYg8esJmpjT3A6DPmaIANM6lUKfp8ebgF4clA/PqI7L/H9f+duBDYyuDtn+N4L20MN BPseUD1D+KLZ8BiOecbyBq5lu/nvfo5VNjKbKeuQPFV0n5/HpSw0jGjB6uB0K5Dh1oGd tyd1mM+1Rj3WkzKDmihsSt8qW0HKhSOf1xfTsouX7Px7gny4dXVx3/bRq0WpjxNJpY8+ 0TVZ908NhxMqfve/xqY+yAcdmx21jOuZet+B7YmLg4t9p9Mt5LQbP/ANtjf20aKiZJuo 3Ofw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784798453; x=1785403253; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lz7QXf+iBwT8QlIH9Oun8AGxaHA1wq8IUAehzHZTWo0=; b=LWhgQPuVDNr3HiQKpyseoBrximPtyCINy4wON9WPmd5uXsbnYa27sGLCCUjr+Eqt4O fj7cN12669b/DcfJ3CMn92HLWesqEXml54gnMJVF2XYg4oQec2z9CzKuufDkUoUsiSGz lukSMEx8XEZGCgBx+oiRELy8QKEqNnm9VMqCCq6Bxtp5i19rNXV8N0QDqFkYKBYHB66i ai0r+XJyeKxlF0fJ4aWLqmi+FoXSEepfx6uR6fsXaKx3er7fubwbf9UPgEbByKbeVZkG iYOD5KULmPhJlaq1k9nEkuXPQrDtuR5HCKM/Qs5bdcseIM3DvIZG5+iDYbImdC5yujA8 uS3Q== X-Forwarded-Encrypted: i=1; AHgh+Rpw2uAZRPHxq2L2iX0Uo47Clmt+1hjgDfNMAfMfaiODMLTnqaLi6tWlbpTIznrbZr4TF9BHGUj+letNphE=@vger.kernel.org X-Gm-Message-State: AOJu0YyRFw35kkbqOLjpVK6vs7OSVUk7ZDomxhSTtny2m7kTkED8AeaK Putlmlkibcf2z6cqBzeVf0tZFi/hLcsps/hRFT/+6GQJbXCB1z9+uX+Cpv+SXftyofT8kZ476DV wXrRdq600IpCuFT9Tk1aeU6gqHeaxgxPJB2+rY1EDYPjVRD0++shcnkbs1fcRdCv3O64= X-Gm-Gg: AR+sD11SosQktQBjasZ1DTqc7p9nX0Ij9l9+3zGRo+wyHAmveekttQ/7uieTQTitXmy Z0StlHRH9+l+s+X6RelCwcOcpAkBlhGbFO0nzY8VeLEe6UHwCiYuAdXbPYVZDcp/5ehit4YHPut 2e/jtTPTPQ0o7EsMRVS6rX0axLgLLc1pDV0VgPQeLrtBRFNlJWmcG6rJ2n58nlF7jisugJSwGTS b3ubcJ0egFNkF+ARaUEz28QdmXb8Ax6OR+hIPN8UmLRH8tM29whV7I6x9SN/pCg8rHiFFVJfLei 2kyvTjLGfw6WrAG0hJkn++A7UQ6BIDeCYk2vYMcOe9/VOZFF993wAFWTQEEHVCg2KmdABrfjOXp yQVYEYmrYa31WCjOSIwhPi2OZ4LjhXS1mewI= X-Received: by 2002:a17:903:1c1:b0:2cf:18e5:1d18 with SMTP id d9443c01a7336-2cfa958568amr21289945ad.29.1784798453107; Thu, 23 Jul 2026 02:20:53 -0700 (PDT) X-Received: by 2002:a17:903:1c1:b0:2cf:18e5:1d18 with SMTP id d9443c01a7336-2cfa958568amr21289495ad.29.1784798452670; Thu, 23 Jul 2026 02:20:52 -0700 (PDT) Received: from [10.217.219.142] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8f011570sm29930365ad.35.2026.07.23.02.20.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2026 02:20:52 -0700 (PDT) Message-ID: Date: Thu, 23 Jul 2026 14:50:43 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v23 12/14] crypto: qce - Map crypto memory for DMA To: Bartosz Golaszewski Cc: dmaengine@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski , Bartosz Golaszewski , Vinod Koul , Jonathan Corbet , Thara Gopinath , Herbert Xu , "David S. Miller" , Udit Tiwari , Md Sadre Alam , Dmitry Baryshkov , Manivannan Sadhasivam , Stephan Gerhold , Bjorn Andersson , Peter Ujfalusi , Michal Simek , Frank Li , Andy Gross , Neil Armstrong , Vignesh Raghavendra References: <20260721-qcom-qce-cmd-descr-v23-0-1be02deffda9@oss.qualcomm.com> <20260721-qcom-qce-cmd-descr-v23-12-1be02deffda9@oss.qualcomm.com> <773715fd-823f-4564-ba42-c60bc8284b45@oss.qualcomm.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: FaqaRscmAtEqrabBdgzJAoJVENPrWwCE X-Proofpoint-ORIG-GUID: FaqaRscmAtEqrabBdgzJAoJVENPrWwCE X-Authority-Analysis: v=2.4 cv=baZbluPB c=1 sm=1 tr=0 ts=6a61dcf5 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=JVr4EG2OP6aRYF85f9oA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIzMDA5MiBTYWx0ZWRfX4KQR+wpUUE26 CZhJZx9bZkQ3nBoysf69QcR6XC8P7cMRH/4c6TKjUJMhGkUb3Po/soWYhxHw+XtP7W1SSAX7ayG CNmIO704k2rZUQHbTe4Cm5Qs7PbD1Wk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIzMDA5MiBTYWx0ZWRfX/ZeYSqvz4Nnx 99NhWQpw8aiukGtfMclHqw/8jZjlrKTCrGsx8k9J0CFB5GiYO7exgUSMnBlAITzmvtqs0BLo0TZ eSqpLkzbsp0IRgNbOHkAYmF1RgkCjTvDqwtE+3Wlo487saf1cui2JaMa5shucYmohc7tHdi3K8y KtCxWMSpZzjaO/TrviljlSXV9CK1WhHYLY4+7lq6yMdyj1F4Cm7vy6ZFLLF0rbaHYsn58kzxNIH KX92h0reDQROBau+uT0EuuEchc8EfSt0xLLQ2ZMoSCIF6cnI9T6ouSX3xEV7JDjZS5wb6tlFc+M UOFO2HOITDvdzzBMNsHeRSOmcY3gOa8gRlE+FFsJLLICBR3Sivw0ST71pmNYBwurIXYxAKK6RWa EWtGXYvmjTC6xIWnC0stGQiu9o9e9EI0J4FkV8q62JOrKak5QvsXiQI5IMyG+m6B6Lnhi1nJtAa EC9koY9plEqvZVVpRWg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-23_03,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 adultscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607230092 On 7/22/2026 2:47 PM, Bartosz Golaszewski wrote: > On Tue, 21 Jul 2026 20:20:05 +0200, Mukesh Savaliya > said: >> >> >> On 7/21/2026 7:03 PM, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski >> >> [...] >> >>> static int qce_crypto_probe(struct platform_device *pdev) >>> { >>> struct device *dev = &pdev->dev; >>> struct qce_device *qce; >>> + struct resource *res; >>> int ret; >>> >>> qce = devm_kzalloc(dev, sizeof(*qce), GFP_KERNEL); >>> @@ -204,7 +213,7 @@ static int qce_crypto_probe(struct platform_device *pdev) >>> qce->dev = dev; >>> platform_set_drvdata(pdev, qce); >>> >>> - qce->base = devm_platform_ioremap_resource(pdev, 0); >>> + qce->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res); >>> if (IS_ERR(qce->base)) >> Would you like to add any debug/error log ? >>> return PTR_ERR(qce->base); >>> >>> @@ -254,6 +263,18 @@ static int qce_crypto_probe(struct platform_device *pdev) >>> qce->async_req_enqueue = qce_async_request_enqueue; >>> qce->async_req_done = qce_async_request_done; >>> >>> + qce->dma_size = resource_size(res); >>> + qce->base_dma = dma_map_resource(dev, res->start, qce->dma_size, >>> + DMA_BIDIRECTIONAL, 0); >>> + qce->base_phys = res->start; >>> + ret = dma_mapping_error(dev, qce->base_dma); >>> + if (ret) >> Would you like to add any debug/error log ? > > No, I don't think this is needed and at v23 this really is useless bikeshedding > and doesn't add anything to the discussion and only delays getting > this upstream. > Okay, got it. Thanks ! > Bartosz > >>> + return ret; >>> + >>> + ret = devm_add_action_or_reset(qce->dev, qce_crypto_unmap_dma, qce); >>> + if (ret) >> same here >>> + return ret; >>> + >>> return devm_qce_register_algs(qce); >>> } >>> >> >> [...] >> >>