From: Gary Guo <gary@garyguo.net>
To: Alice Ryhl <aliceryhl@google.com>
Cc: "Alexandre Courbot" <acourbot@nvidia.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Boqun Feng" <boqun@kernel.org>,
"Yury Norov" <yury.norov@gmail.com>,
"John Hubbard" <jhubbard@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>, "Edwin Peer" <epeer@nvidia.com>,
"Eliot Courtney" <ecourtney@nvidia.com>,
"Dirk Behme" <dirk.behme@de.bosch.com>,
"Steven Price" <steven.price@arm.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 4/9] rust: num: make Bounded::get const
Date: Mon, 16 Feb 2026 09:16:56 +0000 [thread overview]
Message-ID: <eb9d44c5478df3772e86e904a2b469c6@garyguo.net> (raw)
In-Reply-To: <aZLb0VcA3oZLfYvr@google.com>
On 2026-02-16 08:56, Alice Ryhl wrote:
> On Mon, Feb 16, 2026 at 05:04:40PM +0900, Alexandre Courbot wrote:
>> There is a need to access the inner value of a `Bounded` in const
>> context, notably for bitfields and registers. Remove the invariant
>> check
>> of `Bounded::get`, which allows us to make it const.
>>
>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>> ---
>> rust/kernel/num/bounded.rs | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/rust/kernel/num/bounded.rs b/rust/kernel/num/bounded.rs
>> index 8e4c08924d96..b09b93cd0c5c 100644
>> --- a/rust/kernel/num/bounded.rs
>> +++ b/rust/kernel/num/bounded.rs
>> @@ -379,6 +379,9 @@ pub fn from_expr(expr: T) -> Self {
>>
>> /// Returns the wrapped value as the backing type.
>> ///
>> + /// This is similar to the [`Deref`] implementation, but doesn't
>> enforce the size invariant of
>> + /// the [`Bounded`], which might produce slightly less optimal
>> code.
>
> The unreachable_unchecked() hint is const, so I see no reason you
> couldn't add the same call in `fn get`.
The issue is that trait impls are not const, so the if condition cannot
be represented in const yet.
Best,
Gary
next prev parent reply other threads:[~2026-02-16 9:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 8:04 [PATCH v6 0/9] rust: add `register!` macro Alexandre Courbot
2026-02-16 8:04 ` [PATCH v6 1/9] rust: enable the `generic_arg_infer` feature Alexandre Courbot
2026-02-16 8:04 ` [PATCH v6 2/9] rust: num: add `shr` and `shl` methods to `Bounded` Alexandre Courbot
2026-02-16 8:55 ` Alice Ryhl
2026-02-16 8:04 ` [PATCH v6 3/9] rust: num: add `into_bool` method " Alexandre Courbot
2026-02-16 8:04 ` [PATCH v6 4/9] rust: num: make Bounded::get const Alexandre Courbot
2026-02-16 8:56 ` Alice Ryhl
2026-02-16 9:16 ` Gary Guo [this message]
2026-02-16 8:04 ` [PATCH v6 5/9] rust: io: add IoRef and IoWrite types Alexandre Courbot
2026-02-16 9:01 ` Alice Ryhl
2026-02-16 9:36 ` Alexandre Courbot
2026-02-16 10:35 ` Alice Ryhl
2026-02-16 10:52 ` Alexandre Courbot
2026-02-20 6:38 ` Alexandre Courbot
2026-02-20 8:18 ` Alice Ryhl
2026-02-20 14:45 ` Alexandre Courbot
2026-02-21 8:43 ` Alice Ryhl
2026-02-16 8:04 ` [PATCH v6 6/9] rust: io: use generic read/write accessors for primitive accesses Alexandre Courbot
2026-02-16 8:04 ` [PATCH v6 7/9] rust: io: add `register!` macro Alexandre Courbot
2026-02-16 8:04 ` [PATCH v6 8/9] sample: rust: pci: use " Alexandre Courbot
2026-02-16 8:04 ` [PATCH FOR REFERENCE v6 9/9] gpu: nova-core: use the kernel " Alexandre Courbot
2026-02-20 13:20 ` [PATCH v6 0/9] rust: add " Dirk Behme
2026-02-22 13:25 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb9d44c5478df3772e86e904a2b469c6@garyguo.net \
--to=gary@garyguo.net \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dirk.behme@de.bosch.com \
--cc=ecourtney@nvidia.com \
--cc=epeer@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=steven.price@arm.com \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome