From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.mleia.com (mleia.com [178.79.152.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31FE62D47F3 for ; Fri, 2 Jan 2026 12:36:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.79.152.223 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767357373; cv=none; b=elrC1B5i3t3JAuaM917kUKZhiXMey8hnY+8G/SdhQaEK3bYkSUq5nVTO8ZY2uDOKbabZ2BmMJrR2d0Nsk4oOBBsuBcTXuXmDpCZPgHSqJkQGzUuySSAoebuk41hAmJkNirzFS51Tx7r/d1JNiUI4ggu1xqYpHt2MASdq3ZNjxUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767357373; c=relaxed/simple; bh=ZPiLUwdVlye8afoiIfEYHMA1gyQswktqXOTPVA6D4xw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tenhnAJTexjOUXPM1ZCtjBepSxuoomgukWLP8Cf+fDOdqvs/UHoNbxQgL+v/CMauiUdAU2QkRcMMYs+wVyHwYScnXLAoQs7MPOs6uFfly9dj4Lkxg8AE2vFaRp5l9/s7fqAFbAJdpCNiteXmF/A1ik5s2tF6RPK3sgODemdCavg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mleia.com; spf=none smtp.mailfrom=mleia.com; dkim=pass (2048-bit key) header.d=mleia.com header.i=@mleia.com header.b=qylc2llx; dkim=pass (2048-bit key) header.d=mleia.com header.i=@mleia.com header.b=qylc2llx; arc=none smtp.client-ip=178.79.152.223 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mleia.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=mleia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mleia.com header.i=@mleia.com header.b="qylc2llx"; dkim=pass (2048-bit key) header.d=mleia.com header.i=@mleia.com header.b="qylc2llx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mleia.com; s=mail; t=1767357368; bh=ZPiLUwdVlye8afoiIfEYHMA1gyQswktqXOTPVA6D4xw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qylc2llx7MD25mAPOtjGIs1Mn+IotLvRAitTTL9omKxD87i3CSkJosTvSCD1s17wr b9UY0B/1zVjvTg0e+a8CQmC6CAaTsZem06c9Qjnde/ElzQ2jjjFkeWnJWWD8ziXqEi oQW0JXUJNnnGbV9IUXEbh3P2Swu4BiVtE/bwBh4b3zzltCQ5ofFMMFZ7sdl1o9A8JO MYk/e2qcPIcbPtcE0NO8SlLCsefXmkxhjsscgcG2Cg58AHGoHRM4hRxlUjqqFymYgp MG3CNcXr6sqN4LPFHKHE3KaIWzdcBoUM6SI4uBEqxMQiVSkabCUedbEbSBMI9Q4vUQ MVTVy3nNuSFoQ== Received: from mail.mleia.com (localhost [127.0.0.1]) by mail.mleia.com (Postfix) with ESMTP id 7A1F93E9C54; Fri, 2 Jan 2026 12:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mleia.com; s=mail; t=1767357368; bh=ZPiLUwdVlye8afoiIfEYHMA1gyQswktqXOTPVA6D4xw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qylc2llx7MD25mAPOtjGIs1Mn+IotLvRAitTTL9omKxD87i3CSkJosTvSCD1s17wr b9UY0B/1zVjvTg0e+a8CQmC6CAaTsZem06c9Qjnde/ElzQ2jjjFkeWnJWWD8ziXqEi oQW0JXUJNnnGbV9IUXEbh3P2Swu4BiVtE/bwBh4b3zzltCQ5ofFMMFZ7sdl1o9A8JO MYk/e2qcPIcbPtcE0NO8SlLCsefXmkxhjsscgcG2Cg58AHGoHRM4hRxlUjqqFymYgp MG3CNcXr6sqN4LPFHKHE3KaIWzdcBoUM6SI4uBEqxMQiVSkabCUedbEbSBMI9Q4vUQ MVTVy3nNuSFoQ== Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi [91.159.24.186]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mleia.com (Postfix) with ESMTPSA id 1F14F3E98AF; Fri, 2 Jan 2026 12:36:08 +0000 (UTC) Message-ID: Date: Fri, 2 Jan 2026 14:36:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] soc: nxp: Add a simple NXP LPC32xx socinfo driver To: Krzysztof Kozlowski , Arnd Bergmann Cc: Piotr Wojtaszczyk , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260101235647.2411062-1-vz@mleia.com> <20260101235647.2411062-3-vz@mleia.com> From: Vladimir Zapolskiy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20260102_123608_519216_2FBB7741 X-CRM114-Status: GOOD ( 13.02 ) On 1/2/26 11:58, Krzysztof Kozlowski wrote: > On 02/01/2026 00:56, Vladimir Zapolskiy wrote: >> Add NXP LPC32xx specific driver to get unique SoC ID from System Control >> Block registers and export it to userspace. >> >> Signed-off-by: Vladimir Zapolskiy >> --- >> drivers/soc/Kconfig | 1 + >> drivers/soc/Makefile | 1 + >> drivers/soc/nxp/Kconfig | 16 +++++ >> drivers/soc/nxp/Makefile | 2 + >> drivers/soc/nxp/lpc32xx-soc.c | 114 ++++++++++++++++++++++++++++++++++ >> 5 files changed, 134 insertions(+) >> create mode 100644 drivers/soc/nxp/Kconfig >> create mode 100644 drivers/soc/nxp/Makefile >> create mode 100644 drivers/soc/nxp/lpc32xx-soc.c >> >> diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig >> index a2d65adffb80..c21b0d2f58fc 100644 >> --- a/drivers/soc/Kconfig >> +++ b/drivers/soc/Kconfig >> @@ -18,6 +18,7 @@ source "drivers/soc/loongson/Kconfig" >> source "drivers/soc/mediatek/Kconfig" >> source "drivers/soc/microchip/Kconfig" >> source "drivers/soc/nuvoton/Kconfig" >> +source "drivers/soc/nxp/Kconfig" >> source "drivers/soc/pxa/Kconfig" >> source "drivers/soc/qcom/Kconfig" >> source "drivers/soc/renesas/Kconfig" >> diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile >> index 47a3925ff84c..a04c21a8a5a4 100644 >> --- a/drivers/soc/Makefile >> +++ b/drivers/soc/Makefile >> @@ -24,6 +24,7 @@ obj-y += loongson/ >> obj-y += mediatek/ >> obj-y += microchip/ >> obj-y += nuvoton/ >> +obj-y += nxp/ >> obj-y += pxa/ >> obj-y += qcom/ >> obj-y += renesas/ > > Missing maintainers entry. > > >> + >> +static int lpc32xx_soc_probe(struct platform_device *pdev) >> +{ >> + struct soc_device_attribute *soc_dev_attr; >> + struct device *dev = &pdev->dev; >> + struct soc_device *soc_dev; >> + struct regmap *scb; >> + u32 serial_id[4]; >> + int ret; >> + >> + soc_dev_attr = devm_kzalloc(dev, sizeof(*soc_dev_attr), GFP_KERNEL); >> + if (!soc_dev_attr) >> + return -ENOMEM; >> + >> + soc_dev_attr->family = "NXP LPC32xx"; >> + >> + ret = of_property_read_string(of_root, "model", &soc_dev_attr->machine); >> + if (ret) >> + return ret; >> + >> + scb = syscon_regmap_lookup_by_compatible("nxp,lpc3220-scb"); > > This is undocumented ABI. What is the expected level of documentation for syscon? The mfd/syscon.yaml states: System controller node represents a register region containing a set of miscellaneous registers. The registers are not cohesive enough to represent as any specific type of device. This particular SCB has been documented, the review is pending. > Anyway, you should look up devices via phandles. > I may miss the context, was syscon_regmap_lookup_by_compatible() deprecated? Most of drivers/soc uses syscon_regmap_lookup_by_compatible() variant over syscon_regmap_lookup_by_phandle(), and overall % git grep syscon_regmap_lookup_by_compatible v6.19-rc1 | wc -l 105 -- Best wishes, Vladimir