From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F07FC282C2 for ; Wed, 13 Feb 2019 13:48:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CFCDE218D3 for ; Wed, 13 Feb 2019 13:48:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="tZX5/Zkp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387913AbfBMNsH (ORCPT ); Wed, 13 Feb 2019 08:48:07 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:42480 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729957AbfBMNsG (ORCPT ); Wed, 13 Feb 2019 08:48:06 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x1DDlsbd079526; Wed, 13 Feb 2019 07:47:54 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1550065674; bh=aWdopirzZVESKE/3wZS+ty22uj0ge74IDmupL+yPkhQ=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=tZX5/ZkpSxMqyjwb+vwtjfRNiDOHgZpYsJtZkYqfxdj6RwcGTFHHcz3X/rqzt60RG SZz4RIASS5YNZbLCU7PWVYIHB2uhGPO2fXADw/yeHYR8xuywLYIM0UpODGQ5tqtyc4 hjRFqmgBZXK4F6MyMCeWlVcPJ2fWYCk4M9ZNPP1Y= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x1DDlsfa040330 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 13 Feb 2019 07:47:54 -0600 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Wed, 13 Feb 2019 07:47:54 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Wed, 13 Feb 2019 07:47:53 -0600 Received: from [172.24.190.233] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id x1DDlnLS027769; Wed, 13 Feb 2019 07:47:50 -0600 Subject: Re: [PATCH v2 08/15] PCI: endpoint: Fix pci_epf_alloc_space to set correct MEM TYPE flags To: Lorenzo Pieralisi CC: Gustavo Pimentel , Alan Douglas , Shawn Lin , Heiko Stuebner , Bjorn Helgaas , Jingoo Han , , , , , References: <20190114111513.21618-1-kishon@ti.com> <20190114111513.21618-9-kishon@ti.com> <20190211173723.GA31035@e107981-ln.cambridge.arm.com> From: Kishon Vijay Abraham I Message-ID: Date: Wed, 13 Feb 2019 19:17:14 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190211173723.GA31035@e107981-ln.cambridge.arm.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lorenzo, On 11/02/19 11:07 PM, Lorenzo Pieralisi wrote: > On Mon, Jan 14, 2019 at 04:45:06PM +0530, Kishon Vijay Abraham I wrote: >> pci_epf_alloc_space() sets the MEM TYPE flags to indicate a 32-bit >> Base Address Register irrespective of the size. Fix it here to indicate >> 64-bit BAR if the size is > 2GB. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> drivers/pci/endpoint/pci-epf-core.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) > > This looks like a fix and should me marked as such. Does it work > as as standalone patch if it gets backported ? Yeah, it should work. But the current users doesn't allocate > 2GB and some EPC drivers configure their registers based on size. So nothing is broken without this patch as such. Thanks Kishon