From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Przemyslaw <przemekchwiala@gmail.com>,
hdegoede@redhat.com, m.szyprowski@samsung.com,
sebastian.krzyszkowiak@puri.sm, kernel@puri.sm, sre@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: lukas.bulwahn@gmail.com
Subject: Re: [PATCH] power: supply: max17042_battery: Do not use CONFIG_ prefix in regular C code
Date: Thu, 20 Jul 2023 14:35:50 +0200 [thread overview]
Message-ID: <ebb3267e-7257-654e-4a57-a55c626087f9@linaro.org> (raw)
In-Reply-To: <20230720123102.154699-1-przemekchwiala@gmail.com>
On 20/07/2023 14:31, Przemyslaw wrote:
> From: Przemyslaw Chwiala <przemekchwiala@gmail.com>
>
> Using CONFIG_ prefix for macros is not a good practice.
> Use CONFIG_ prefix in Kconfig only.
>
> Signed-off-by: Przemyslaw Chwiala <przemekchwiala@gmail.com>
> ---
For future:
Please provide changelog after --- and version your patches (git
format-patch -v2, or use b4).
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
This is an automated instruction, just in case, because many review tags
are being ignored. If you do not know the process, here is a short
explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for acks received on the
version they apply.
https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-20 12:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 12:31 Przemyslaw
2023-07-20 12:35 ` Krzysztof Kozlowski [this message]
2023-07-20 12:48 ` Lukas Bulwahn
2023-09-12 19:08 ` Sebastian Reichel
-- strict thread matches above, loose matches on Subject: below --
2023-07-20 12:25 Przemyslaw
2023-07-20 12:28 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebb3267e-7257-654e-4a57-a55c626087f9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=hdegoede@redhat.com \
--cc=kernel@puri.sm \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=m.szyprowski@samsung.com \
--cc=przemekchwiala@gmail.com \
--cc=sebastian.krzyszkowiak@puri.sm \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®