From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 410B9C0032E for ; Sat, 28 Oct 2023 11:11:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229919AbjJ1LLO (ORCPT ); Sat, 28 Oct 2023 07:11:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbjJ1LLL (ORCPT ); Sat, 28 Oct 2023 07:11:11 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01FB2F2 for ; Sat, 28 Oct 2023 04:11:08 -0700 (PDT) Received: from dggpemm500011.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4SHcDV4cW4zMmJW; Sat, 28 Oct 2023 19:06:50 +0800 (CST) Received: from [10.174.179.155] (10.174.179.155) by dggpemm500011.china.huawei.com (7.185.36.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Sat, 28 Oct 2023 19:11:06 +0800 Message-ID: Date: Sat, 28 Oct 2023 19:10:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:104.0) Gecko/20100101 Thunderbird/104.0 Subject: Re: [PATCH] dm: remove dm_set_md_type() To: CC: , , , , , , , References: <20230912122605.3487911-1-lilingfeng3@huawei.com> From: Li Lingfeng In-Reply-To: <20230912122605.3487911-1-lilingfeng3@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.155] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500011.china.huawei.com (7.185.36.110) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Friendly ping ... Thanks 在 2023/9/12 20:26, Li Lingfeng 写道: > Commit ba30585936b0 ("dm: move setting md->type into dm_setup_md_queue") > has removed the only reference to dm_set_md_type(), so remove > dm_set_md_type() now. > > Signed-off-by: Li Lingfeng > --- > drivers/md/dm.c | 6 ------ > drivers/md/dm.h | 1 - > 2 files changed, 7 deletions(-) > > diff --git a/drivers/md/dm.c b/drivers/md/dm.c > index f0f118ab20fa..6b9d04ca09d0 100644 > --- a/drivers/md/dm.c > +++ b/drivers/md/dm.c > @@ -2316,12 +2316,6 @@ void dm_unlock_md_type(struct mapped_device *md) > mutex_unlock(&md->type_lock); > } > > -void dm_set_md_type(struct mapped_device *md, enum dm_queue_mode type) > -{ > - BUG_ON(!mutex_is_locked(&md->type_lock)); > - md->type = type; > -} > - > enum dm_queue_mode dm_get_md_type(struct mapped_device *md) > { > return md->type; > diff --git a/drivers/md/dm.h b/drivers/md/dm.h > index f682295af91f..cc55ef3441be 100644 > --- a/drivers/md/dm.h > +++ b/drivers/md/dm.h > @@ -76,7 +76,6 @@ bool dm_table_request_based(struct dm_table *t); > > void dm_lock_md_type(struct mapped_device *md); > void dm_unlock_md_type(struct mapped_device *md); > -void dm_set_md_type(struct mapped_device *md, enum dm_queue_mode type); > enum dm_queue_mode dm_get_md_type(struct mapped_device *md); > struct target_type *dm_get_immutable_target_type(struct mapped_device *md); >